Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/48763/?format=api
{ "id": 48763, "url": "http://patchwork.dpdk.org/api/patches/48763/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/633b56ce7ee5551bfc456bd2f7968fd2f61b7529.1544701282.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<633b56ce7ee5551bfc456bd2f7968fd2f61b7529.1544701282.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/633b56ce7ee5551bfc456bd2f7968fd2f61b7529.1544701282.git.anatoly.burakov@intel.com", "date": "2018-12-13T11:43:15", "name": "[v3,1/5] mem: fix error code for segment fd API for external segs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "831aac104c710507727aabae6a3638fa0af0cb07", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/633b56ce7ee5551bfc456bd2f7968fd2f61b7529.1544701282.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 2758, "url": "http://patchwork.dpdk.org/api/series/2758/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=2758", "date": "2018-12-13T11:43:14", "name": "Allow using virtio-user without hugepages", "version": 3, "mbox": "http://patchwork.dpdk.org/series/2758/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/48763/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/48763/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 88A781B503;\n\tThu, 13 Dec 2018 12:43:29 +0100 (CET)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 663AF2BC7;\n\tThu, 13 Dec 2018 12:43:24 +0100 (CET)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t13 Dec 2018 03:43:22 -0800", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga004.jf.intel.com with ESMTP; 13 Dec 2018 03:43:20 -0800", "from sivswdev05.ir.intel.com (sivswdev05.ir.intel.com\n\t[10.243.17.64])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\twBDBhJMD032151; Thu, 13 Dec 2018 11:43:19 GMT", "from sivswdev05.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev05.ir.intel.com with ESMTP id wBDBhJ47012537;\n\tThu, 13 Dec 2018 11:43:19 GMT", "(from aburakov@localhost)\n\tby sivswdev05.ir.intel.com with LOCAL id wBDBhJ9c012533;\n\tThu, 13 Dec 2018 11:43:19 GMT" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.56,348,1539673200\"; d=\"scan'208\";a=\"259162199\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "John McNamara <john.mcnamara@intel.com>,\n\tMarko Kovacevic <marko.kovacevic@intel.com>, przemyslawx.lal@intel.com,\n\tkuralamudhan.ramakrishnan@intel.com, ivan.coughlan@intel.com,\n\ttiwei.bie@intel.com, ray.kinsella@intel.com,\n\tmaxime.coquelin@redhat.com, stable@dpdk.org", "Date": "Thu, 13 Dec 2018 11:43:15 +0000", "Message-Id": "<633b56ce7ee5551bfc456bd2f7968fd2f61b7529.1544701282.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": [ "<cover.1544701282.git.anatoly.burakov@intel.com>", "<cover.1544701282.git.anatoly.burakov@intel.com>" ], "References": [ "<cover.1544701282.git.anatoly.burakov@intel.com>", "<cover.1544546363.git.anatoly.burakov@intel.com>\n\t<cover.1544701282.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH v3 1/5] mem: fix error code for segment fd API\n\tfor external segs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Segment fd API does not support getting segment fd's from\nexternally allocated memory, so return proper error code\non any attempts to do so. This changes API behavior, so\ndocument the change as well.\n\nFixes: 5282bb1c3695 (\"mem: allow memseg lists to be marked as external\")\nCc: stable@dpdk.org\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\nAcked-by: Tiwei Bie <tiwei.bie@intel.com>\n---\n\nNotes:\n The API is experimental, no deprecation notice needed.\n\n doc/guides/rel_notes/release_19_02.rst | 6 ++++++\n lib/librte_eal/common/eal_common_memory.c | 12 ++++++++++++\n 2 files changed, 18 insertions(+)", "diff": "diff --git a/doc/guides/rel_notes/release_19_02.rst b/doc/guides/rel_notes/release_19_02.rst\nindex a94fa86a7..ade41b9c8 100644\n--- a/doc/guides/rel_notes/release_19_02.rst\n+++ b/doc/guides/rel_notes/release_19_02.rst\n@@ -84,6 +84,12 @@ API Changes\n =========================================================\n \n \n+* eal: segment fd API on Linux now sets error code to ``ENOTSUP`` in more cases\n+ where segment fd API is not expected to be supported:\n+\n+ - On attempt to get segment fd for an externally allocated memory segment\n+\n+\n ABI Changes\n -----------\n \ndiff --git a/lib/librte_eal/common/eal_common_memory.c b/lib/librte_eal/common/eal_common_memory.c\nindex d47ea4938..999ba24b4 100644\n--- a/lib/librte_eal/common/eal_common_memory.c\n+++ b/lib/librte_eal/common/eal_common_memory.c\n@@ -704,6 +704,12 @@ rte_memseg_get_fd_thread_unsafe(const struct rte_memseg *ms)\n \t\treturn -1;\n \t}\n \n+\t/* segment fd API is not supported for external segments */\n+\tif (msl->external) {\n+\t\trte_errno = ENOTSUP;\n+\t\treturn -1;\n+\t}\n+\n \tret = eal_memalloc_get_seg_fd(msl_idx, seg_idx);\n \tif (ret < 0) {\n \t\trte_errno = -ret;\n@@ -754,6 +760,12 @@ rte_memseg_get_fd_offset_thread_unsafe(const struct rte_memseg *ms,\n \t\treturn -1;\n \t}\n \n+\t/* segment fd API is not supported for external segments */\n+\tif (msl->external) {\n+\t\trte_errno = ENOTSUP;\n+\t\treturn -1;\n+\t}\n+\n \tret = eal_memalloc_get_seg_fd_offset(msl_idx, seg_idx, offset);\n \tif (ret < 0) {\n \t\trte_errno = -ret;\n", "prefixes": [ "v3", "1/5" ] }