Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/61912/?format=api
{ "id": 61912, "url": "http://patchwork.dpdk.org/api/patches/61912/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20191024142814.10979-1-fbl@sysclose.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191024142814.10979-1-fbl@sysclose.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20191024142814.10979-1-fbl@sysclose.org", "date": "2019-10-24T14:28:14", "name": "vhost: fix IPv4 csum calculation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9d34de5a5817a4b120bd067a7c920ed383788007", "submitter": { "id": 159, "url": "http://patchwork.dpdk.org/api/people/159/?format=api", "name": "Flavio Leitner", "email": "fbl@sysclose.org" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20191024142814.10979-1-fbl@sysclose.org/mbox/", "series": [ { "id": 7051, "url": "http://patchwork.dpdk.org/api/series/7051/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=7051", "date": "2019-10-24T14:28:14", "name": "vhost: fix IPv4 csum calculation", "version": 1, "mbox": "http://patchwork.dpdk.org/series/7051/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/61912/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/61912/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 929EF1EA7A;\n\tThu, 24 Oct 2019 16:28:30 +0200 (CEST)", "from sysclose.org (smtp.sysclose.org [69.164.214.230])\n\tby dpdk.org (Postfix) with ESMTP id B51001EA79\n\tfor <dev@dpdk.org>; Thu, 24 Oct 2019 16:28:28 +0200 (CEST)", "by sysclose.org (Postfix, from userid 5001)\n\tid 075922EF9; Thu, 24 Oct 2019 14:28:28 +0000 (UTC)", "from localhost (unknown [177.183.215.210])\n\tby sysclose.org (Postfix) with ESMTPSA id 301A3181;\n\tThu, 24 Oct 2019 14:28:27 +0000 (UTC)" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sysclose.org 075922EF9", "OpenDKIM Filter v2.11.0 sysclose.org 301A3181" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=sysclose.org;\n\ts=201903; t=1571927308;\n\tbh=o4Q3DoPZEUJFB5aZ5YihPCOlktlSz+mndPGnDzMinrk=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=byowdIukiJFPsGLtyjGFO9idefNek8S20k9lioaG4ulfFj0BcEFwUFVsUwtFKGBFs\n\t+WYFQQQY7gD3BakwnfENMbs/Z8HSvgrlu38n6nXPt29TxxntGazRuFlTK4Qh3RGiVK\n\tj0DYEOehOK7u03KxeyKp1qT9DC6XettvSem7cW+4gmZr1+9AUA8nxrXgTeGj6P2eS0\n\tZHo8ox+pWeeNBbs91yG/ruS+96wN0mUdFq1cGc8mCaPdT0J+zUK82W2ox1qB6EZ9Pn\n\tAOuKYSLLsIdL4mccDOAHdEyFMQIMarRM4IYSFt/yq6rH5YpJ11WVmN9vuVnelCl/79\n\t5ghHcM5sTXINg==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=sysclose.org;\n\ts=201903; t=1571927307;\n\tbh=o4Q3DoPZEUJFB5aZ5YihPCOlktlSz+mndPGnDzMinrk=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=YO0x4t5VFCoyWa0i8lHoTA8jvzAhN9iwl9OcT2jr+A01wj4Q3kCpaGY9mMsBDO5YO\n\t4dFn0MqRLvHg8cUkVAx2T9mNZiVz+O/7sNNxfcQ2D5AhRzKASs8MmpZc+oT3EOW5ob\n\toAx/aBio41DyX857AStlmmquK7RLCjPHbewEJDT/bHrdjFe5LfTY6AiG2Ci/xICehe\n\tNmtkKL6e+ycbaXOKWiA+sw2/E30IZ/zpwPyfYM1ZXmu/37Vbw0W4F8VIPT5tpgdURh\n\tkapG76HXcLArb5a2saSiGRP9B3ecxV/UZ4sY08mZ/PO/5ErIxKeb3npRfOD6fUHgFX\n\tfMl14dYD9HypA==" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on mail.sysclose.org", "X-Spam-Level": "", "X-Spam-Status": "No, score=-1.1 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,\n\tDKIM_VALID, DKIM_VALID_AU,\n\tURIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0", "From": "Flavio Leitner <fbl@sysclose.org>", "To": "dev@dpdk.org", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>,\n\tTiwei Bie <tiwei.bie@intel.com>,\n\tObrembski MichalX <michalx.obrembski@intel.com>", "Date": "Thu, 24 Oct 2019 11:28:14 -0300", "Message-Id": "<20191024142814.10979-1-fbl@sysclose.org>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] vhost: fix IPv4 csum calculation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently the IPv4 header checksum is calculated including its\ncurrent value, which can be a valid checksum or just garbage.\nIn any case, if the original value is not zero, then the result\nis always wrong.\n\nThe IPv4 checksum is defined in RFC791, page 14 says:\n Header Checksum: 16 bits\n\n The checksum algorithm is:\n The checksum field is the 16 bit one's complement of the one's\n complement sum of all 16 bit words in the header. For purposes of\n computing the checksum, the value of the checksum field is zero.\n\nThus force the csum field to always be zero.\n\nSigned-off-by: Flavio Leitner <fbl@sysclose.org>\n---\n lib/librte_vhost/virtio_net.c | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c\nindex eae7825f04..cde7498c76 100644\n--- a/lib/librte_vhost/virtio_net.c\n+++ b/lib/librte_vhost/virtio_net.c\n@@ -445,6 +445,7 @@ virtio_enqueue_offload(struct rte_mbuf *m_buf, struct virtio_net_hdr *net_hdr)\n \n \t\tipv4_hdr = rte_pktmbuf_mtod_offset(m_buf, struct rte_ipv4_hdr *,\n \t\t\t\t\t\t m_buf->l2_len);\n+\t\tipv4_hdr->hdr_checksum = 0;\n \t\tipv4_hdr->hdr_checksum = rte_ipv4_cksum(ipv4_hdr);\n \t}\n \n", "prefixes": [] }