Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 66029,
    "url": "http://patchwork.dpdk.org/api/patches/66029/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1582620228-25629-1-git-send-email-matan@mellanox.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1582620228-25629-1-git-send-email-matan@mellanox.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1582620228-25629-1-git-send-email-matan@mellanox.com",
    "date": "2020-02-25T08:43:48",
    "name": "vdpa/mlx5: fix event setup",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "8f2f213ad40b9fbdfd7702e848d8b53f6254a0de",
    "submitter": {
        "id": 796,
        "url": "http://patchwork.dpdk.org/api/people/796/?format=api",
        "name": "Matan Azrad",
        "email": "matan@mellanox.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1582620228-25629-1-git-send-email-matan@mellanox.com/mbox/",
    "series": [
        {
            "id": 8676,
            "url": "http://patchwork.dpdk.org/api/series/8676/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=8676",
            "date": "2020-02-25T08:43:48",
            "name": "vdpa/mlx5: fix event setup",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/8676/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/66029/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/66029/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C4BE6A0524;\n\tTue, 25 Feb 2020 09:43:55 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9E9931BFAB;\n\tTue, 25 Feb 2020 09:43:54 +0100 (CET)",
            "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id 4E5E23B5\n for <dev@dpdk.org>; Tue, 25 Feb 2020 09:43:52 +0100 (CET)",
            "from Internal Mail-Server by MTLPINE1 (envelope-from\n asafp@mellanox.com)\n with ESMTPS (AES256-SHA encrypted); 25 Feb 2020 10:43:51 +0200",
            "from pegasus07.mtr.labs.mlnx (pegasus07.mtr.labs.mlnx\n [10.210.16.112])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 01P8hpIW025015;\n Tue, 25 Feb 2020 10:43:51 +0200"
        ],
        "From": "Matan Azrad <matan@mellanox.com>",
        "To": "dev@dpdk.org",
        "Cc": "Viacheslav Ovsiienko <viacheslavo@mellanox.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Maxime Coquelin <maxime.coquelin@redhat.com>",
        "Date": "Tue, 25 Feb 2020 08:43:48 +0000",
        "Message-Id": "<1582620228-25629-1-git-send-email-matan@mellanox.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "Subject": "[dpdk-dev] [PATCH] vdpa/mlx5: fix event setup",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The completion event mechanism should work only if at least one of the\nvirtqs has valid callfd to be notified on.\n\nWhen all the virtqs works with poll mode, the event mechanism should not\nbe configured.\n\nThe driver didn't take it into account and crashed in the above case.\n\nDo not configure event interrupt when all the virtqs are in poll mode.\n\nFixes: 8395927cdfaf (\"vdpa/mlx5: prepare HW queues\")\n\nSigned-off-by: Matan Azrad <matan@mellanox.com>\n---\n drivers/vdpa/mlx5/mlx5_vdpa_event.c | 10 ++++++++--\n 1 file changed, 8 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_event.c b/drivers/vdpa/mlx5/mlx5_vdpa_event.c\nindex 16276f5..dd60150 100644\n--- a/drivers/vdpa/mlx5/mlx5_vdpa_event.c\n+++ b/drivers/vdpa/mlx5/mlx5_vdpa_event.c\n@@ -237,8 +237,14 @@\n int\n mlx5_vdpa_cqe_event_setup(struct mlx5_vdpa_priv *priv)\n {\n-\tint flags = fcntl(priv->eventc->fd, F_GETFL);\n-\tint ret = fcntl(priv->eventc->fd, F_SETFL, flags | O_NONBLOCK);\n+\tint flags;\n+\tint ret;\n+\n+\tif (!priv->eventc)\n+\t\t/* All virtqs are in poll mode. */\n+\t\treturn 0;\n+\tflags = fcntl(priv->eventc->fd, F_GETFL);\n+\tret = fcntl(priv->eventc->fd, F_SETFL, flags | O_NONBLOCK);\n \tif (ret) {\n \t\tDRV_LOG(ERR, \"Failed to change event channel FD.\");\n \t\trte_errno = errno;\n",
    "prefixes": []
}