Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 6614,
    "url": "http://patchwork.dpdk.org/api/patches/6614/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1437986559-31016-12-git-send-email-xiao.w.wang@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1437986559-31016-12-git-send-email-xiao.w.wang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1437986559-31016-12-git-send-email-xiao.w.wang@intel.com",
    "date": "2015-07-27T08:42:35",
    "name": "[dpdk-dev,12/16] fm10k: pack TLV overlay structures correctly",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "da57b6ed7f124776446aaa286b04200853568fb2",
    "submitter": {
        "id": 281,
        "url": "http://patchwork.dpdk.org/api/people/281/?format=api",
        "name": "Xiao Wang",
        "email": "xiao.w.wang@intel.com"
    },
    "delegate": null,
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1437986559-31016-12-git-send-email-xiao.w.wang@intel.com/mbox/",
    "series": [],
    "comments": "http://patchwork.dpdk.org/api/patches/6614/comments/",
    "check": "pending",
    "checks": "http://patchwork.dpdk.org/api/patches/6614/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 61D0CC560;\n\tMon, 27 Jul 2015 10:43:18 +0200 (CEST)",
            "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 4BB9DC55A\n\tfor <dev@dpdk.org>; Mon, 27 Jul 2015 10:43:15 +0200 (CEST)",
            "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP; 27 Jul 2015 01:43:15 -0700",
            "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga002.fm.intel.com with ESMTP; 27 Jul 2015 01:43:14 -0700",
            "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t6R8hCxo023360;\n\tMon, 27 Jul 2015 16:43:12 +0800",
            "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t6R8h8aX031129; Mon, 27 Jul 2015 16:43:10 +0800",
            "(from xiaowan1@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t6R8h8we031125; \n\tMon, 27 Jul 2015 16:43:08 +0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.15,552,1432623600\"; d=\"scan'208\";a=\"770335393\"",
        "From": "Wang Xiao W <xiao.w.wang@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Mon, 27 Jul 2015 16:42:35 +0800",
        "Message-Id": "<1437986559-31016-12-git-send-email-xiao.w.wang@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "In-Reply-To": "<1437986559-31016-1-git-send-email-xiao.w.wang@intel.com>",
        "References": "<1437986559-31016-1-git-send-email-xiao.w.wang@intel.com>",
        "Cc": "Wang Xiao W <xiao.w.wang@intel.com>",
        "Subject": "[dpdk-dev] [PATCH 12/16] fm10k: pack TLV overlay structures\n\tcorrectly",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This patch adds #pragma pack(push, 1) around some structures which are passed\nvia TLV messages. These structures must not be left unpacked as GCC and\nother compilers are wont to do. Otherwise, we get invalid message\nresponses from the Switch Manager software since it sends 20 bytes and\nwe expect 24.\n\nSigned-off-by: Wang Xiao W <xiao.w.wang@intel.com>\n---\n drivers/net/fm10k/base/fm10k_pf.h | 8 ++++++++\n 1 file changed, 8 insertions(+)",
    "diff": "diff --git a/drivers/net/fm10k/base/fm10k_pf.h b/drivers/net/fm10k/base/fm10k_pf.h\nindex 5a40d5b..b7a1758 100644\n--- a/drivers/net/fm10k/base/fm10k_pf.h\n+++ b/drivers/net/fm10k/base/fm10k_pf.h\n@@ -90,6 +90,12 @@ enum fm10k_pf_tlv_attr_id_v1 {\n #define FM10K_MSG_UPDATE_PVID_PVID_SHIFT\t16\n #define FM10K_MSG_UPDATE_PVID_PVID_SIZE\t\t16\n \n+/* The following data structures are overlayed specifically to TLV mailbox\n+ * messages, and must not have gaps between their values. They must line up\n+ * correctly to the TLV definition.\n+ */\n+#pragma pack(push, 1)\n+\n struct fm10k_mac_update {\n \t__le32\tmac_lower;\n \t__le16\tmac_upper;\n@@ -124,6 +130,8 @@ struct fm10k_swapi_tx_timestamp_mode {\n \t__le32 status;\n };\n \n+#pragma pack(pop)\n+\n #define FM10K_PF_MSG_LPORT_CREATE_HANDLER(func) \\\n \tFM10K_MSG_HANDLER(FM10K_PF_MSG_ID_LPORT_CREATE, NULL, func)\n #define FM10K_PF_MSG_LPORT_DELETE_HANDLER(func) \\\n",
    "prefixes": [
        "dpdk-dev",
        "12/16"
    ]
}