Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/69303/?format=api
{ "id": 69303, "url": "http://patchwork.dpdk.org/api/patches/69303/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200425105620.73021-4-haiyue.wang@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200425105620.73021-4-haiyue.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200425105620.73021-4-haiyue.wang@intel.com", "date": "2020-04-25T10:56:17", "name": "[v7,3/6] mk: add internal tag check", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1d98c22165ad0bc435d909407f0fdf3296fa9f79", "submitter": { "id": 1044, "url": "http://patchwork.dpdk.org/api/people/1044/?format=api", "name": "Wang, Haiyue", "email": "haiyue.wang@intel.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200425105620.73021-4-haiyue.wang@intel.com/mbox/", "series": [ { "id": 9633, "url": "http://patchwork.dpdk.org/api/series/9633/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=9633", "date": "2020-04-25T10:56:14", "name": "dpdk: introduce __rte_internal tag", "version": 7, "mbox": "http://patchwork.dpdk.org/series/9633/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/69303/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/69303/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BBE1FA00C2;\n\tSat, 25 Apr 2020 13:02:44 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BABE41C1FE;\n\tSat, 25 Apr 2020 13:02:22 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by dpdk.org (Postfix) with ESMTP id D7EFF1C1E0\n for <dev@dpdk.org>; Sat, 25 Apr 2020 13:02:19 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 25 Apr 2020 04:02:19 -0700", "from npg-dpdk-haiyue-3.sh.intel.com ([10.67.119.46])\n by fmsmga005.fm.intel.com with ESMTP; 25 Apr 2020 04:02:17 -0700" ], "IronPort-SDR": [ "\n UywustxEyC5Z/+PT7yhNdwrMr092ymgiIjLlvdb8UrZy7fLzj3/BSGPhVuciPDZBPiJ5W6qkIX\n fMA8xoFh3CbA==", "\n /ofVvQqsOcQgI8dMrsSBIY/26H4nqymbm01YeCYL013bSN6vXboIlNRoPnL7KwB9yzTGenYSxM\n +q8d77O7ddUQ==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,315,1583222400\"; d=\"scan'208\";a=\"457729302\"", "From": "Haiyue Wang <haiyue.wang@intel.com>", "To": "dev@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com,\n bruce.richardson@intel.com, ferruh.yigit@intel.com, nhorman@tuxdriver.com,\n mdr@ashroe.eu", "Cc": "Haiyue Wang <haiyue.wang@intel.com>", "Date": "Sat, 25 Apr 2020 18:56:17 +0800", "Message-Id": "<20200425105620.73021-4-haiyue.wang@intel.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20200425105620.73021-1-haiyue.wang@intel.com>", "References": "<20190613142344.9188-1-nhorman@tuxdriver.com>\n <20200425105620.73021-1-haiyue.wang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v7 3/6] mk: add internal tag check", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add checks during build to ensure that all symbols in the INTERNAL\nversion map section have __internal tags on their definitions, and\nenable the warnings needed to announce their use.\n\nSigned-off-by: Haiyue Wang <haiyue.wang@intel.com>\n---\n MAINTAINERS | 2 +-\n ...-experimental-syms.sh => check-symbols.sh} | 31 +++++++++++++++++++\n buildtools/meson.build | 2 +-\n mk/internal/rte.compile-pre.mk | 6 ++--\n 4 files changed, 36 insertions(+), 5 deletions(-)\n rename buildtools/{check-experimental-syms.sh => check-symbols.sh} (61%)", "diff": "diff --git a/MAINTAINERS b/MAINTAINERS\nindex a8d24e332..85298d426 100644\n--- a/MAINTAINERS\n+++ b/MAINTAINERS\n@@ -153,7 +153,7 @@ F: devtools/libabigail.abignore\n F: devtools/update-abi.sh\n F: devtools/update_version_map_abi.py\n F: devtools/validate-abi.sh\n-F: buildtools/check-experimental-syms.sh\n+F: buildtools/check-symbols.sh\n F: buildtools/map-list-symbol.sh\n \n Driver information\ndiff --git a/buildtools/check-experimental-syms.sh b/buildtools/check-symbols.sh\nsimilarity index 61%\nrename from buildtools/check-experimental-syms.sh\nrename to buildtools/check-symbols.sh\nindex f3603e5ba..3df57c322 100755\n--- a/buildtools/check-experimental-syms.sh\n+++ b/buildtools/check-symbols.sh\n@@ -54,4 +54,35 @@ do\n \t}\n done\n \n+for SYM in `$LIST_SYMBOL -S INTERNAL $MAPFILE |cut -d ' ' -f 3`\n+do\n+\tif grep -q \"\\.text.*[[:space:]]$SYM$\" $DUMPFILE &&\n+\t\t! grep -q \"\\.text\\.internal.*[[:space:]]$SYM$\" $DUMPFILE\n+\tthen\n+\t\tcat >&2 <<- END_OF_MESSAGE\n+\t\t$SYM is not flagged as internal\n+\t\tbut is listed in version map\n+\t\tPlease add __rte_internal to the definition of $SYM\n+\t\tEND_OF_MESSAGE\n+\t\tret=1\n+\tfi\n+done\n+\n+# Filter out symbols suffixed with a . for icc\n+for SYM in `awk '{\n+\tif ($2 != \"l\" && $4 == \".text.internal\" && !($NF ~ /\\.$/)) {\n+\t\tprint $NF\n+\t}\n+}' $DUMPFILE`\n+do\n+\t$LIST_SYMBOL -S INTERNAL -s $SYM -q $MAPFILE || {\n+\t\tcat >&2 <<- END_OF_MESSAGE\n+\t\t$SYM is flagged as internal\n+\t\tbut is not listed in version map\n+\t\tPlease add $SYM to the version map\n+\t\tEND_OF_MESSAGE\n+\t\tret=1\n+\t}\n+done\n+\n exit $ret\ndiff --git a/buildtools/meson.build b/buildtools/meson.build\nindex 9812917e5..3e8d31b0c 100644\n--- a/buildtools/meson.build\n+++ b/buildtools/meson.build\n@@ -6,7 +6,7 @@ subdir('pmdinfogen')\n pkgconf = find_program('pkg-config', 'pkgconf', required: false)\n pmdinfo = find_program('gen-pmdinfo-cfile.sh')\n list_dir_globs = find_program('list-dir-globs.py')\n-check_experimental_syms = find_program('check-experimental-syms.sh')\n+check_experimental_syms = find_program('check-symbols.sh')\n ldflags_ibverbs_static = find_program('options-ibverbs-static.sh')\n \n # set up map-to-def script using python, either built-in or external\ndiff --git a/mk/internal/rte.compile-pre.mk b/mk/internal/rte.compile-pre.mk\nindex 82fe098f7..df05b5576 100644\n--- a/mk/internal/rte.compile-pre.mk\n+++ b/mk/internal/rte.compile-pre.mk\n@@ -56,8 +56,8 @@ C_TO_O = $(CC) -Wp,-MD,$(call obj2dep,$(@)).tmp $(CPPFLAGS) $(CFLAGS) \\\n C_TO_O_STR = $(subst ','\\'',$(C_TO_O)) #'# fix syntax highlight\n C_TO_O_DISP = $(if $(V),\"$(C_TO_O_STR)\",\" CC $(@)\")\n endif\n-EXPERIMENTAL_CHECK = $(RTE_SDK)/buildtools/check-experimental-syms.sh\n-CHECK_EXPERIMENTAL = $(EXPERIMENTAL_CHECK) $(SRCDIR)/$(EXPORT_MAP) $@\n+CHECK_SYMBOLS_SCRIPT = $(RTE_SDK)/buildtools/check-symbols.sh\n+CHECK_SYMBOLS = $(CHECK_SYMBOLS_SCRIPT) $(SRCDIR)/$(EXPORT_MAP) $@\n \n PMDINFO_GEN = $(RTE_SDK_BIN)/app/dpdk-pmdinfogen $@ $@.pmd.c\n PMDINFO_CC = $(CC) $(CPPFLAGS) $(CFLAGS) $(EXTRA_CFLAGS) -c -o $@.pmd.o $@.pmd.c\n@@ -75,7 +75,7 @@ C_TO_O_DO = @set -e; \\\n \techo $(C_TO_O_DISP); \\\n \t$(C_TO_O) && \\\n \t$(PMDINFO_TO_O) && \\\n-\t$(CHECK_EXPERIMENTAL) && \\\n+\t$(CHECK_SYMBOLS) && \\\n \techo $(C_TO_O_CMD) > $(call obj2cmd,$(@)) && \\\n \tsed 's,'$@':,dep_'$@' =,' $(call obj2dep,$(@)).tmp > $(call obj2dep,$(@)) && \\\n \trm -f $(call obj2dep,$(@)).tmp\n", "prefixes": [ "v7", "3/6" ] }