Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/69721/?format=api
{ "id": 69721, "url": "http://patchwork.dpdk.org/api/patches/69721/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200504203915.9602-2-akhil.goyal@nxp.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200504203915.9602-2-akhil.goyal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200504203915.9602-2-akhil.goyal@nxp.com", "date": "2020-05-04T20:39:15", "name": "[2/2] crypto/dpaa_sec: improve error handling", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9f1d902f72ed929a1d4f931bf3ffc3641bd77c16", "submitter": { "id": 517, "url": "http://patchwork.dpdk.org/api/people/517/?format=api", "name": "Akhil Goyal", "email": "akhil.goyal@nxp.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200504203915.9602-2-akhil.goyal@nxp.com/mbox/", "series": [ { "id": 9816, "url": "http://patchwork.dpdk.org/api/series/9816/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=9816", "date": "2020-05-04T20:39:14", "name": "[1/2] crypto/dpaa2_sec: improve error handling", "version": 1, "mbox": "http://patchwork.dpdk.org/series/9816/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/69721/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/69721/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3799AA04AE;\n\tMon, 4 May 2020 23:00:22 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C8B251D567;\n\tMon, 4 May 2020 23:00:13 +0200 (CEST)", "from inva020.nxp.com (inva020.nxp.com [92.121.34.13])\n by dpdk.org (Postfix) with ESMTP id 5A6291D551\n for <dev@dpdk.org>; Mon, 4 May 2020 23:00:12 +0200 (CEST)", "from inva020.nxp.com (localhost [127.0.0.1])\n by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id D41D01A0519;\n Mon, 4 May 2020 23:00:11 +0200 (CEST)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n [165.114.16.14])\n by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 117331A0501;\n Mon, 4 May 2020 23:00:10 +0200 (CEST)", "from GDB1.ap.freescale.net (gdb1.ap.freescale.net [10.232.132.179])\n by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id E638B4030B;\n Tue, 5 May 2020 05:00:07 +0800 (SGT)" ], "From": "Akhil Goyal <akhil.goyal@nxp.com>", "To": "dev@dpdk.org", "Cc": "hemant.agrawal@nxp.com,\n\tAkhil Goyal <akhil.goyal@nxp.com>", "Date": "Tue, 5 May 2020 02:09:15 +0530", "Message-Id": "<20200504203915.9602-2-akhil.goyal@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200504203915.9602-1-akhil.goyal@nxp.com>", "References": "<20200504203915.9602-1-akhil.goyal@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH 2/2] crypto/dpaa_sec: improve error handling", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The return values in cases of errors were not\nspecified properly. With this patch appropriate\nerror numbers are returned.\n\nSigned-off-by: Akhil Goyal <akhil.goyal@nxp.com>\n---\n drivers/crypto/dpaa_sec/dpaa_sec.c | 33 ++++++++++++++++--------------\n 1 file changed, 18 insertions(+), 15 deletions(-)", "diff": "diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c\nindex a11b17bda..c8110aa50 100644\n--- a/drivers/crypto/dpaa_sec/dpaa_sec.c\n+++ b/drivers/crypto/dpaa_sec/dpaa_sec.c\n@@ -2041,7 +2041,7 @@ dpaa_sec_cipher_init(struct rte_cryptodev *dev __rte_unused,\n \t\tDPAA_SEC_ERR(\"Crypto: Undefined Cipher specified %u\",\n \t\t\t xform->cipher.algo);\n \t\trte_free(session->cipher_key.data);\n-\t\treturn -1;\n+\t\treturn -ENOTSUP;\n \t}\n \tsession->dir = (xform->cipher.op == RTE_CRYPTO_CIPHER_OP_ENCRYPT) ?\n \t\t\tDIR_ENC : DIR_DEC;\n@@ -2109,7 +2109,7 @@ dpaa_sec_auth_init(struct rte_cryptodev *dev __rte_unused,\n \t\tDPAA_SEC_ERR(\"Crypto: Unsupported Auth specified %u\",\n \t\t\t xform->auth.algo);\n \t\trte_free(session->auth_key.data);\n-\t\treturn -1;\n+\t\treturn -ENOTSUP;\n \t}\n \n \tsession->dir = (xform->auth.op == RTE_CRYPTO_AUTH_OP_GENERATE) ?\n@@ -2126,6 +2126,7 @@ dpaa_sec_chain_init(struct rte_cryptodev *dev __rte_unused,\n \n \tstruct rte_crypto_cipher_xform *cipher_xform;\n \tstruct rte_crypto_auth_xform *auth_xform;\n+\tint ret = 0;\n \n \tsession->ctxt = DPAA_SEC_CIPHER_HASH;\n \tif (session->auth_cipher_text) {\n@@ -2144,7 +2145,7 @@ dpaa_sec_chain_init(struct rte_cryptodev *dev __rte_unused,\n \t\t\t\t\t RTE_CACHE_LINE_SIZE);\n \tif (session->cipher_key.data == NULL && cipher_xform->key.length > 0) {\n \t\tDPAA_SEC_ERR(\"No Memory for cipher key\");\n-\t\treturn -1;\n+\t\treturn -ENOMEM;\n \t}\n \tsession->cipher_key.length = cipher_xform->key.length;\n \tsession->auth_key.data = rte_zmalloc(NULL, auth_xform->key.length,\n@@ -2191,6 +2192,7 @@ dpaa_sec_chain_init(struct rte_cryptodev *dev __rte_unused,\n \tdefault:\n \t\tDPAA_SEC_ERR(\"Crypto: Unsupported Auth specified %u\",\n \t\t\t auth_xform->algo);\n+\t\tret = -ENOTSUP;\n \t\tgoto error_out;\n \t}\n \n@@ -2212,16 +2214,17 @@ dpaa_sec_chain_init(struct rte_cryptodev *dev __rte_unused,\n \tdefault:\n \t\tDPAA_SEC_ERR(\"Crypto: Undefined Cipher specified %u\",\n \t\t\t cipher_xform->algo);\n+\t\tret = -ENOTSUP;\n \t\tgoto error_out;\n \t}\n \tsession->dir = (cipher_xform->op == RTE_CRYPTO_CIPHER_OP_ENCRYPT) ?\n \t\t\t\tDIR_ENC : DIR_DEC;\n-\treturn 0;\n+\treturn ret;\n \n error_out:\n \trte_free(session->cipher_key.data);\n \trte_free(session->auth_key.data);\n-\treturn -1;\n+\treturn ret;\n }\n \n static int\n@@ -2254,7 +2257,7 @@ dpaa_sec_aead_init(struct rte_cryptodev *dev __rte_unused,\n \tdefault:\n \t\tDPAA_SEC_ERR(\"unsupported AEAD alg %d\", session->aead_alg);\n \t\trte_free(session->aead_key.data);\n-\t\treturn -ENOMEM;\n+\t\treturn -ENOTSUP;\n \t}\n \n \tsession->dir = (xform->aead.op == RTE_CRYPTO_AEAD_OP_ENCRYPT) ?\n@@ -2501,7 +2504,7 @@ dpaa_sec_ipsec_aead_init(struct rte_crypto_aead_xform *aead_xform,\n \t\t\t\t\t RTE_CACHE_LINE_SIZE);\n \tif (session->aead_key.data == NULL && aead_xform->key.length > 0) {\n \t\tDPAA_SEC_ERR(\"No Memory for aead key\");\n-\t\treturn -1;\n+\t\treturn -ENOMEM;\n \t}\n \tmemcpy(session->aead_key.data, aead_xform->key.data,\n \t aead_xform->key.length);\n@@ -2524,7 +2527,7 @@ dpaa_sec_ipsec_aead_init(struct rte_crypto_aead_xform *aead_xform,\n \t\tdefault:\n \t\t\tDPAA_SEC_ERR(\"Crypto: Undefined GCM digest %d\",\n \t\t\t\t session->digest_length);\n-\t\t\treturn -1;\n+\t\t\treturn -EINVAL;\n \t\t}\n \t\tif (session->dir == DIR_ENC) {\n \t\t\tmemcpy(session->encap_pdb.gcm.salt,\n@@ -2539,7 +2542,7 @@ dpaa_sec_ipsec_aead_init(struct rte_crypto_aead_xform *aead_xform,\n \tdefault:\n \t\tDPAA_SEC_ERR(\"Crypto: Undefined AEAD specified %u\",\n \t\t\t aead_xform->algo);\n-\t\treturn -1;\n+\t\treturn -ENOTSUP;\n \t}\n \treturn 0;\n }\n@@ -2636,11 +2639,11 @@ dpaa_sec_ipsec_proto_init(struct rte_crypto_cipher_xform *cipher_xform,\n \tcase RTE_CRYPTO_AUTH_ZUC_EIA3:\n \t\tDPAA_SEC_ERR(\"Crypto: Unsupported auth alg %u\",\n \t\t\t session->auth_alg);\n-\t\treturn -1;\n+\t\treturn -ENOTSUP;\n \tdefault:\n \t\tDPAA_SEC_ERR(\"Crypto: Undefined Auth specified %u\",\n \t\t\t session->auth_alg);\n-\t\treturn -1;\n+\t\treturn -ENOTSUP;\n \t}\n \n \tswitch (session->cipher_alg) {\n@@ -2673,11 +2676,11 @@ dpaa_sec_ipsec_proto_init(struct rte_crypto_cipher_xform *cipher_xform,\n \tcase RTE_CRYPTO_CIPHER_KASUMI_F8:\n \t\tDPAA_SEC_ERR(\"Crypto: Unsupported Cipher alg %u\",\n \t\t\t session->cipher_alg);\n-\t\treturn -1;\n+\t\treturn -ENOTSUP;\n \tdefault:\n \t\tDPAA_SEC_ERR(\"Crypto: Undefined Cipher specified %u\",\n \t\t\t session->cipher_alg);\n-\t\treturn -1;\n+\t\treturn -ENOTSUP;\n \t}\n \n \treturn 0;\n@@ -2893,7 +2896,7 @@ dpaa_sec_set_pdcp_session(struct rte_cryptodev *dev,\n \t\tdefault:\n \t\t\tDPAA_SEC_ERR(\"Crypto: Undefined Cipher specified %u\",\n \t\t\t\t session->cipher_alg);\n-\t\t\treturn -1;\n+\t\t\treturn -EINVAL;\n \t\t}\n \n \t\tsession->cipher_key.data = rte_zmalloc(NULL,\n@@ -2944,7 +2947,7 @@ dpaa_sec_set_pdcp_session(struct rte_cryptodev *dev,\n \t\t\tDPAA_SEC_ERR(\"Crypto: Unsupported auth alg %u\",\n \t\t\t\t session->auth_alg);\n \t\t\trte_free(session->cipher_key.data);\n-\t\t\treturn -1;\n+\t\t\treturn -EINVAL;\n \t\t}\n \t\tsession->auth_key.data = rte_zmalloc(NULL,\n \t\t\t\t\t\t auth_xform->key.length,\n", "prefixes": [ "2/2" ] }