Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73994/?format=api
{ "id": 73994, "url": "http://patchwork.dpdk.org/api/patches/73994/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1594711565-28309-1-git-send-email-wangzhike@jd.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1594711565-28309-1-git-send-email-wangzhike@jd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1594711565-28309-1-git-send-email-wangzhike@jd.com", "date": "2020-07-14T07:26:05", "name": "[v2] mempool: fix memory allocation in memzones during retry.", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "531ac23a51f9069ea1cc07756b7f36d422a83e92", "submitter": { "id": 873, "url": "http://patchwork.dpdk.org/api/people/873/?format=api", "name": "王志克", "email": "wangzhike@jd.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1594711565-28309-1-git-send-email-wangzhike@jd.com/mbox/", "series": [ { "id": 11012, "url": "http://patchwork.dpdk.org/api/series/11012/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=11012", "date": "2020-07-14T07:26:05", "name": "[v2] mempool: fix memory allocation in memzones during retry.", "version": 2, "mbox": "http://patchwork.dpdk.org/series/11012/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/73994/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/73994/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CBAA4A0540;\n\tTue, 14 Jul 2020 09:26:46 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 87F051D53D;\n\tTue, 14 Jul 2020 09:26:45 +0200 (CEST)", "from m12-14.163.com (m12-14.163.com [220.181.12.14])\n by dpdk.org (Postfix) with ESMTP id 521831D40F;\n Tue, 14 Jul 2020 09:26:43 +0200 (CEST)", "from localhost.localdomain (unknown [106.38.115.12])\n by smtp10 (Coremail) with SMTP id DsCowABHn9sPXg1fUZSzAw--.40266S2;\n Tue, 14 Jul 2020 15:26:11 +0800 (CST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;\n s=s110527; h=From:Subject:Date:Message-Id; bh=T/5SE0xi8XdZPbuiSa\n 8n9cCOVXJr0508FKRuhaP5UIE=; b=VYmAOYzKRhoptIdtqwVeMV6Fo1cnzP7s18\n ssheLztD2drVgPDqEQKSdY+UNmmkUudt/VNAAfTw0+xks+61z5sXENMqx38vaC2w\n y8j8ngq7tVLovsZ2yQfzST6lRPVZKIC0dzBeIlDICGIzjz7LjhhrpzsCcPrV4nlt\n BTpMJk3A4=", "From": "Zhike Wang <wangzhike@jd.com>", "To": "dev@dpdk.org", "Cc": "olivier.matz@6wind.com, arybchenko@solarflare.com, stable@dpdk.org,\n Zhike Wang <wangzhike@jd.com>", "Date": "Tue, 14 Jul 2020 15:26:05 +0800", "Message-Id": "<1594711565-28309-1-git-send-email-wangzhike@jd.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1594611634-7730-1-git-send-email-wangzhike@jd.com>", "References": "<1594611634-7730-1-git-send-email-wangzhike@jd.com>", "X-CM-TRANSID": "DsCowABHn9sPXg1fUZSzAw--.40266S2", "X-Coremail-Antispam": "1Uf129KBjvJXoW7Zr1kJF48KF4kur43Xw1xAFb_yoW8Xr18pr\n 43Gwn5tFnFqrWxArs7W3WrWa48G3Z29r17try0vr4vvrnxJ3W5Janrt34YqrWxZrs5JF45\n t3yDWF1fA3yjga7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07j7Oz3UUUUU=", "X-Originating-IP": "[106.38.115.12]", "X-CM-SenderInfo": "pzdqw6bntsiqqrwthudrp/1tbiVghgulqzl3uNcgABs-", "Subject": "[dpdk-dev] [PATCH v2] mempool: fix memory allocation in memzones\n\tduring retry.", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If allocation is successful on the first attempt, typically\nthere is no problem since we allocated everything required and\nwe'll terminate the loop (if memory chunk is really sufficient\nto populate required number of mempool elements).\n\nIf the first attempt fails, we try to allocate half\nof mem_size and it succeed, we'll have one more iteration of\nthe for-loop to allocate memory for remaining elements and\nshould not try the next time with quarter of the mem_size.\n\nIt is wrong that max_alloc_size is divided by 2 in the\ncase of successful allocation as well, or invalid memory\ncan be allocated, and leads to population failure, then errno\nother than ENOMEM may be returned.\n\nFixes: 3a3d0c75b43e (\"mempool: fix slow allocation of large pools\")\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nSigned-off-by: Zhike Wang <wangzhike@jd.com>\n---\n lib/librte_mempool/rte_mempool.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c\nindex a2bd249..7774f0c 100644\n--- a/lib/librte_mempool/rte_mempool.c\n+++ b/lib/librte_mempool/rte_mempool.c\n@@ -635,7 +635,7 @@ struct pagesz_walk_arg {\n \t\t\t\tRTE_MIN((size_t)mem_size, max_alloc_size),\n \t\t\t\tmp->socket_id, mz_flags, align);\n \n-\t\t\tif (mz == NULL && rte_errno != ENOMEM)\n+\t\t\tif (mz != NULL || rte_errno != ENOMEM)\n \t\t\t\tbreak;\n \n \t\t\tmax_alloc_size = RTE_MIN(max_alloc_size,\n", "prefixes": [ "v2" ] }