Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87030/?format=api
{ "id": 87030, "url": "http://patchwork.dpdk.org/api/patches/87030/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210121142316.84087-1-haiyue.wang@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210121142316.84087-1-haiyue.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210121142316.84087-1-haiyue.wang@intel.com", "date": "2021-01-21T14:23:16", "name": "[v2] net/ice: drain out DCF AdminQ command queue", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "62f9ecb71220d3c083a3e1b839b3122e9805b29d", "submitter": { "id": 1044, "url": "http://patchwork.dpdk.org/api/people/1044/?format=api", "name": "Wang, Haiyue", "email": "haiyue.wang@intel.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210121142316.84087-1-haiyue.wang@intel.com/mbox/", "series": [ { "id": 14888, "url": "http://patchwork.dpdk.org/api/series/14888/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=14888", "date": "2021-01-21T14:23:16", "name": "[v2] net/ice: drain out DCF AdminQ command queue", "version": 2, "mbox": "http://patchwork.dpdk.org/series/14888/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/87030/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/87030/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 06399A09E4;\n\tThu, 21 Jan 2021 15:39:17 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A83D6140E23;\n\tThu, 21 Jan 2021 15:39:17 +0100 (CET)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by mails.dpdk.org (Postfix) with ESMTP id 8E109140E22;\n Thu, 21 Jan 2021 15:39:15 +0100 (CET)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Jan 2021 06:39:13 -0800", "from npg-dpdk-haiyue-3.sh.intel.com ([10.67.118.189])\n by fmsmga001.fm.intel.com with ESMTP; 21 Jan 2021 06:39:11 -0800" ], "IronPort-SDR": [ "\n //QEhRFLwZhBcQaRle2ycssStHdg/G2Q4WFQANVvccKZakKLCJc1LTQZ7b17g1P72OkzCf9ehw\n o5hbnJRSbbVg==", "\n PtLjmEbRmSMsxUBLqbA9RWBEkBp+eGq91vxg0y/wICWQCfTLM45MFEyymrDsDm0S2w5lSkh6GW\n WoibLOPeYD7A==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9870\"; a=\"175769622\"", "E=Sophos;i=\"5.79,364,1602572400\"; d=\"scan'208\";a=\"175769622\"", "E=Sophos;i=\"5.79,364,1602572400\"; d=\"scan'208\";a=\"467470051\"" ], "X-ExtLoop1": "1", "From": "Haiyue Wang <haiyue.wang@intel.com>", "To": "dev@dpdk.org", "Cc": "qiming.yang@intel.com, qi.z.zhang@intel.com, qi.fu@intel.com,\n Haiyue Wang <haiyue.wang@intel.com>, stable@dpdk.org", "Date": "Thu, 21 Jan 2021 22:23:16 +0800", "Message-Id": "<20210121142316.84087-1-haiyue.wang@intel.com>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<220210121141804.83855-1-haiyue.wang@intel.com>", "References": "<220210121141804.83855-1-haiyue.wang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2] net/ice: drain out DCF AdminQ command queue", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The virtchnl command message response is handled by matching the opcode\nonly for limitation.\n\nThe DCF AdminQ command with buffer data needs two virtchnl commands, one\nis to handle the AdminQ header, the other is to handle AdminQ buffer. If\nthe AdminQ header command gets the failure response, the AdminQ buffer\ncommand needs to wait for the buffer message response until timeout to\ndrain out the virtchnl command queue, since both of them are sent to PF,\nthe PF will handle them one by one, and send back the response. If not,\nit will cause the next AdminQ command failure with the stall response.\n\nFixes: daa714d55c72 (\"net/ice: handle AdminQ command by DCF\")\nCc: stable@dpdk.org\n\nSigned-off-by: Haiyue Wang <haiyue.wang@intel.com>\n---\nv2: Fix the commit message typo : 'matchiing' should be 'matching'\n---\n drivers/net/ice/ice_dcf.c | 1 -\n 1 file changed, 1 deletion(-)", "diff": "diff --git a/drivers/net/ice/ice_dcf.c b/drivers/net/ice/ice_dcf.c\nindex 4a9af3292c..a211797d9e 100644\n--- a/drivers/net/ice/ice_dcf.c\n+++ b/drivers/net/ice/ice_dcf.c\n@@ -506,7 +506,6 @@ ice_dcf_send_aq_cmd(void *dcf_hw, struct ice_aq_desc *desc,\n \n \tdo {\n \t\tif ((!desc_cmd.pending && !buff_cmd.pending) ||\n-\t\t (!desc_cmd.pending && desc_cmd.v_ret != IAVF_SUCCESS) ||\n \t\t (!buff_cmd.pending && buff_cmd.v_ret != IAVF_SUCCESS))\n \t\t\tbreak;\n \n", "prefixes": [ "v2" ] }