Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92729/?format=api
{ "id": 92729, "url": "http://patchwork.dpdk.org/api/patches/92729/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210504131458.593429-6-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210504131458.593429-6-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210504131458.593429-6-bruce.richardson@intel.com", "date": "2021-05-04T13:14:51", "name": "[v5,05/12] raw/ioat: fix script for configuring small number of queues", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0c458274e6eccfef29a487ae0174ac1f2cd86c09", "submitter": { "id": 20, "url": "http://patchwork.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210504131458.593429-6-bruce.richardson@intel.com/mbox/", "series": [ { "id": 16807, "url": "http://patchwork.dpdk.org/api/series/16807/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=16807", "date": "2021-05-04T13:14:50", "name": "ioat driver updates", "version": 5, "mbox": "http://patchwork.dpdk.org/series/16807/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/92729/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/92729/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3B2D8A0562;\n\tTue, 4 May 2021 15:15:40 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 87D72410DB;\n\tTue, 4 May 2021 15:15:35 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by mails.dpdk.org (Postfix) with ESMTP id 30F3F40147;\n Tue, 4 May 2021 15:15:33 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 04 May 2021 06:15:32 -0700", "from silpixa00399126.ir.intel.com ([10.237.223.78])\n by orsmga002.jf.intel.com with ESMTP; 04 May 2021 06:15:31 -0700" ], "IronPort-SDR": [ "\n nFbHTsXIPozSF6yeebhXSkNJsrFSYtN6K62gopPBjFr9K1PmGN8mqQe7XJYfgd9UEvvxqsf8UL\n KvmCxpRjjXYA==", "\n 8qtt2FD4QDy7aqmG7NPBhHYu0CPuHvLlIPCwjrA7z6zQV7s7EyQUCYV5cLtI9y5uKdO6CZykVs\n sgrmnUxjGFQg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,9973\"; a=\"195922135\"", "E=Sophos;i=\"5.82,272,1613462400\"; d=\"scan'208\";a=\"195922135\"", "E=Sophos;i=\"5.82,272,1613462400\"; d=\"scan'208\";a=\"406105545\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "kevin.laatz@intel.com, sunil.pai.g@intel.com, jiayu.hu@intel.com,\n Bruce Richardson <bruce.richardson@intel.com>, stable@dpdk.org", "Date": "Tue, 4 May 2021 14:14:51 +0100", "Message-Id": "<20210504131458.593429-6-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210504131458.593429-1-bruce.richardson@intel.com>", "References": "<20210318182042.43658-1-bruce.richardson@intel.com>\n <20210504131458.593429-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v5 05/12] raw/ioat: fix script for configuring\n small number of queues", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The dpdk_idxd_cfg.py script included with the driver for convenience did\nnot work properly where the number of queues to be configured was\nless than the number of groups or engines. This was because there would\nbe configured groups/engines not assigned to queues. Fix this by\nlimiting the engine and group counts to be no bigger than the number of\nqueues.\n\nFixes: 01863b9d2354 (\"raw/ioat: include example configuration script\")\nCc: stable@dpdk.org\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/raw/ioat/dpdk_idxd_cfg.py | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/raw/ioat/dpdk_idxd_cfg.py b/drivers/raw/ioat/dpdk_idxd_cfg.py\nindex bce4bb5bd4..56e44063e4 100755\n--- a/drivers/raw/ioat/dpdk_idxd_cfg.py\n+++ b/drivers/raw/ioat/dpdk_idxd_cfg.py\n@@ -39,15 +39,15 @@ def configure_dsa(dsa_id, queues):\n max_queues = dsa_dir.read_int(\"max_work_queues\")\n max_tokens = dsa_dir.read_int(\"max_tokens\")\n \n- # we want one engine per group\n- nb_groups = min(max_engines, max_groups)\n- for grp in range(nb_groups):\n- dsa_dir.write_values({f\"engine{dsa_id}.{grp}/group_id\": grp})\n-\n nb_queues = min(queues, max_queues)\n if queues > nb_queues:\n print(f\"Setting number of queues to max supported value: {max_queues}\")\n \n+ # we want one engine per group, and no more engines than queues\n+ nb_groups = min(max_engines, max_groups, nb_queues)\n+ for grp in range(nb_groups):\n+ dsa_dir.write_values({f\"engine{dsa_id}.{grp}/group_id\": grp})\n+\n # configure each queue\n for q in range(nb_queues):\n wq_dir = SysfsDir(os.path.join(dsa_dir.path, f\"wq{dsa_id}.{q}\"))\n", "prefixes": [ "v5", "05/12" ] }