Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/93307/?format=api
{ "id": 93307, "url": "http://patchwork.dpdk.org/api/patches/93307/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210518151012.14277-1-ivan.malov@oktetlabs.ru/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210518151012.14277-1-ivan.malov@oktetlabs.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20210518151012.14277-1-ivan.malov@oktetlabs.ru", "date": "2021-05-18T15:10:11", "name": "[1/2] common/sfc_efx/base: limit reported MCDI response length", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "56772a8aa39facdadd30e639cd1fc3983a5e72d4", "submitter": { "id": 869, "url": "http://patchwork.dpdk.org/api/people/869/?format=api", "name": "Ivan Malov", "email": "Ivan.Malov@oktetlabs.ru" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210518151012.14277-1-ivan.malov@oktetlabs.ru/mbox/", "series": [ { "id": 17019, "url": "http://patchwork.dpdk.org/api/series/17019/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=17019", "date": "2021-05-18T15:10:11", "name": "[1/2] common/sfc_efx/base: limit reported MCDI response length", "version": 1, "mbox": "http://patchwork.dpdk.org/series/17019/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/93307/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/93307/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 46FDCA0A02;\n\tTue, 18 May 2021 17:10:23 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 06F3F4068E;\n\tTue, 18 May 2021 17:10:23 +0200 (CEST)", "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id 31E9F40041;\n Tue, 18 May 2021 17:10:21 +0200 (CEST)", "from localhost.localdomain (unknown [5.144.120.183])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by shelob.oktetlabs.ru (Postfix) with ESMTPSA id B14897F53B;\n Tue, 18 May 2021 18:10:20 +0300 (MSK)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru B14897F53B", "DKIM-Signature": "v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;\n s=default; t=1621350620;\n bh=GgnoTAxNcaP9JJkQhOe3VuSd0X2hIIu769OrN15zzFU=;\n h=From:To:Cc:Subject:Date;\n b=kvJA49hE+7qnFLcAiD8TcZyfRk5uNE18fxtX4nLtfdRd8fZPw1PjxBsv89F+QoIcn\n eT+wSvIHfKCwigOHhq7apCQKPMqwLbgbPuOdPi7JYQ1jwUMBIJOpSPtff2K/yeC0lY\n JveynmtDkvX7atgsT5+CM8VnhdvhFW2a9AQbhyOg=", "From": "Ivan Malov <ivan.malov@oktetlabs.ru>", "To": "dev@dpdk.org", "Cc": "Andy Moreton <amoreton@xilinx.com>, stable@dpdk.org,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Ferruh Yigit <ferruh.yigit@intel.com>", "Date": "Tue, 18 May 2021 18:10:11 +0300", "Message-Id": "<20210518151012.14277-1-ivan.malov@oktetlabs.ru>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/2] common/sfc_efx/base: limit reported MCDI\n response length", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Andy Moreton <amoreton@xilinx.com>\n\nMCDI helper routines in libefx include length checks for response\nmessages, to ensure that short replies and optional fields are\nhandled correctly.\n\nIf the MCDI response message from the firmware is larger than the\ncaller's buffer then the response length reported to the caller\nshould be limited to the buffer size. Otherwise length checks in\nthe caller may allow reading past the end of the buffer.\n\nFixes: 6f619653b9b1 (\"net/sfc/base: import MCDI implementation\")\nCc: stable@dpdk.org\n\nSigned-off-by: Andy Moreton <amoreton@xilinx.com>\nSigned-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>\nReviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\n---\n drivers/common/sfc_efx/base/efx_mcdi.c | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/drivers/common/sfc_efx/base/efx_mcdi.c b/drivers/common/sfc_efx/base/efx_mcdi.c\nindex ff676f8a0..f4e1384d0 100644\n--- a/drivers/common/sfc_efx/base/efx_mcdi.c\n+++ b/drivers/common/sfc_efx/base/efx_mcdi.c\n@@ -516,6 +516,9 @@ efx_mcdi_finish_response(\n \tbytes = MIN(emrp->emr_out_length_used, emrp->emr_out_length);\n \tefx_mcdi_read_response(enp, emrp->emr_out_buf, resp_off, bytes);\n \n+\t/* Report bytes copied to caller (response message may be larger) */\n+\temrp->emr_out_length_used = bytes;\n+\n #if EFSYS_OPT_MCDI_LOGGING\n \tif (emtp->emt_logger != NULL) {\n \t\temtp->emt_logger(emtp->emt_context,\n", "prefixes": [ "1/2" ] }