Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 96490,
    "url": "http://patchwork.dpdk.org/api/patches/96490/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1627684312-28630-11-git-send-email-navasile@linux.microsoft.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1627684312-28630-11-git-send-email-navasile@linux.microsoft.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1627684312-28630-11-git-send-email-navasile@linux.microsoft.com",
    "date": "2021-07-30T22:31:52",
    "name": "[v11,10/10] Add unit tests for thread API",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "15d71525a037bd5f907ccc20ec4e248b6e0236f6",
    "submitter": {
        "id": 1668,
        "url": "http://patchwork.dpdk.org/api/people/1668/?format=api",
        "name": "Narcisa Ana Maria Vasile",
        "email": "navasile@linux.microsoft.com"
    },
    "delegate": null,
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1627684312-28630-11-git-send-email-navasile@linux.microsoft.com/mbox/",
    "series": [
        {
            "id": 18112,
            "url": "http://patchwork.dpdk.org/api/series/18112/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=18112",
            "date": "2021-07-30T22:31:42",
            "name": "eal: Add EAL API for threading",
            "version": 11,
            "mbox": "http://patchwork.dpdk.org/series/18112/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/96490/comments/",
    "check": "fail",
    "checks": "http://patchwork.dpdk.org/api/patches/96490/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C6365A0C40;\n\tSat, 31 Jul 2021 00:32:58 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4D63D41157;\n\tSat, 31 Jul 2021 00:32:12 +0200 (CEST)",
            "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 81DC0410F8\n for <dev@dpdk.org>; Sat, 31 Jul 2021 00:32:00 +0200 (CEST)",
            "by linux.microsoft.com (Postfix, from userid 1059)\n id 46D192077046; Fri, 30 Jul 2021 15:31:59 -0700 (PDT)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 46D192077046",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1627684319;\n bh=sySs/gBjzl6wGVbdaNTzPpWLFGv/XjnKl1looBKp2a0=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=I3ccwh1qSPyZ7nXQN5uo7IURWznPLiEZby96f4zrO1e+b3pXGeX/sJnVTIpMpjcqF\n 81bYRT76skfMt51ymn70ySwlW/h56IU952zfL7TqoBUWQyThGxVXckOUn9gSJh0ziG\n wQEssdYyvM08FRZxtIIIMw23FFU9uU5xSnRlUl7s=",
        "From": "Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>",
        "To": "dev@dpdk.org, thomas@monjalon.net, dmitry.kozliuk@gmail.com,\n khot@microsoft.com, navasile@microsoft.com, dmitrym@microsoft.com,\n roretzla@microsoft.com, talshn@nvidia.com, ocardona@microsoft.com",
        "Cc": "bruce.richardson@intel.com, david.marchand@redhat.com,\n pallavi.kadam@intel.com",
        "Date": "Fri, 30 Jul 2021 15:31:52 -0700",
        "Message-Id": "<1627684312-28630-11-git-send-email-navasile@linux.microsoft.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "In-Reply-To": "<1627684312-28630-1-git-send-email-navasile@linux.microsoft.com>",
        "References": "<1624051606-26779-1-git-send-email-navasile@linux.microsoft.com>\n <1627684312-28630-1-git-send-email-navasile@linux.microsoft.com>",
        "Subject": "[dpdk-dev] [PATCH v11 10/10] Add unit tests for thread API",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Narcisa Vasile <navasile@microsoft.com>\n\nAs a new API for threading is introduced,\na set of unit tests have been added to test the new interface.\n\nSigned-off-by: Narcisa Vasile <navasile@microsoft.com>\n---\n app/test/meson.build    |   2 +\n app/test/test_threads.c | 419 ++++++++++++++++++++++++++++++++++++++++\n 2 files changed, 421 insertions(+)\n create mode 100644 app/test/test_threads.c",
    "diff": "diff --git a/app/test/meson.build b/app/test/meson.build\nindex a7611686ad..6fe8b02459 100644\n--- a/app/test/meson.build\n+++ b/app/test/meson.build\n@@ -140,6 +140,7 @@ test_sources = files(\n         'test_table_tables.c',\n         'test_tailq.c',\n         'test_thash.c',\n+\t'test_threads.c',\n         'test_timer.c',\n         'test_timer_perf.c',\n         'test_timer_racecond.c',\n@@ -276,6 +277,7 @@ fast_tests = [\n         ['reorder_autotest', true],\n         ['service_autotest', true],\n         ['thash_autotest', true],\n+\t['threads_autotest, true'],\n         ['trace_autotest', true],\n ]\n \ndiff --git a/app/test/test_threads.c b/app/test/test_threads.c\nnew file mode 100644\nindex 0000000000..ce614942eb\n--- /dev/null\n+++ b/app/test/test_threads.c\n@@ -0,0 +1,419 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright (c) 2021 Microsoft.\n+ */\n+\n+#include <pthread.h>\n+\n+#include <rte_thread.h>\n+\n+#include \"test.h\"\n+\n+#define THREADS_COUNT 20\n+\n+#define TEST_THREADS_LOG(func) \\\n+\t\tprintf(\"Error at line %d. %s failed!\\n\", __LINE__, func)\n+\n+static void *\n+thread_loop_self(void *arg)\n+{\n+\trte_thread_t *id = arg;\n+\n+\t*id = rte_thread_self();\n+\n+\treturn NULL;\n+}\n+\n+static int\n+test_thread_self(void)\n+{\n+\trte_thread_t threads_ids[THREADS_COUNT];\n+\trte_thread_t self_ids[THREADS_COUNT] = {0};\n+\tsize_t i;\n+\tsize_t j;\n+\tint ret = 0;\n+\n+\tfor (i = 0; i < THREADS_COUNT; ++i) {\n+\t\tif (rte_thread_create(&threads_ids[i], NULL, thread_loop_self,\n+\t\t\t\t&self_ids[i]) != 0) {\n+\t\t\tprintf(\"Error, Only %zu threads created.\\n\", i);\n+\t\t\tbreak;\n+\t\t}\n+\t}\n+\n+\tfor (j = 0; j < i; ++j) {\n+\t\tret = rte_thread_join(threads_ids[j], NULL);\n+\t\tif (ret != 0) {\n+\t\t\tTEST_THREADS_LOG(\"rte_thread_join()\");\n+\t\t\treturn -1;\n+\t\t}\n+\n+\t\tif (rte_thread_equal(threads_ids[j], self_ids[j]) == 0)\n+\t\t\tret = -1;\n+\t}\n+\n+\treturn ret;\n+}\n+\n+struct thread_context {\n+\trte_thread_barrier *barrier;\n+\tsize_t *thread_count;\n+};\n+\n+static void *\n+thread_loop_barrier(void *arg)\n+{\n+\n+\tstruct thread_context *ctx = arg;\n+\n+\t(void)__atomic_add_fetch(ctx->thread_count, 1, __ATOMIC_RELAXED);\n+\n+\tif (rte_thread_barrier_wait(ctx->barrier) > 0)\n+\t\tTEST_THREADS_LOG(\"rte_thread_barrier_wait()\");\n+\n+\treturn NULL;\n+}\n+\n+static int\n+test_thread_barrier(void)\n+{\n+\trte_thread_t threads_ids[THREADS_COUNT];\n+\tstruct thread_context ctx[THREADS_COUNT] = {0};\n+\trte_thread_barrier barrier;\n+\tsize_t count = 0;\n+\tsize_t i;\n+\tsize_t j;\n+\tint ret = 0;\n+\n+\tret = rte_thread_barrier_init(&barrier, THREADS_COUNT + 1);\n+\tif (ret != 0) {\n+\t\tTEST_THREADS_LOG(\"rte_thread_barrier_init()\");\n+\t\treturn -1;\n+\t}\n+\n+\tfor (i = 0; i < THREADS_COUNT; ++i) {\n+\t\tctx[i].thread_count = &count;\n+\t\tctx[i].barrier = &barrier;\n+\t\tif (rte_thread_create(&threads_ids[i], NULL,\n+\t\t\t\tthread_loop_barrier, &ctx[i]) != 0) {\n+\t\t\tprintf(\"Error, Only %zu threads created.\\n\", i);\n+\t\t\tret = -1;\n+\t\t\tgoto error;\n+\t\t}\n+\t}\n+\n+\tret = rte_thread_barrier_wait(ctx->barrier);\n+\tif (ret > 0) {\n+\t\tTEST_THREADS_LOG(\"rte_thread_barrier_wait()\");\n+\t\tret = -1;\n+\t\tgoto error;\n+\t}\n+\n+\tif (count != i) {\n+\t\tret = -1;\n+\t\tprintf(\"Error, expected thread count(%zu) to be equal \"\n+\t\t\t\"to the number of threads that wait at the barrier(%zu)\\n\",\n+\t\t\tcount, i);\n+\t\tgoto error;\n+\t}\n+\n+error:\n+\tfor (j = 0; j < i; ++j) {\n+\t\tret = rte_thread_join(threads_ids[j], NULL);\n+\t\tif (ret != 0) {\n+\t\t\tTEST_THREADS_LOG(\"rte_thread_join()\");\n+\t\t\tret = -1;\n+\t\t\tbreak;\n+\t\t}\n+\t}\n+\n+\tret = rte_thread_barrier_destroy(&barrier);\n+\tif (ret != 0) {\n+\t\tTEST_THREADS_LOG(\"rte_thread_barrier_destroy()\");\n+\t\tret = -1;\n+\t}\n+\n+\treturn ret;\n+}\n+\n+static size_t val;\n+\n+static void *\n+thread_loop_mutex(void *arg)\n+{\n+\trte_thread_mutex *mutex = arg;\n+\n+\trte_thread_mutex_lock(mutex);\n+\tval++;\n+\trte_thread_mutex_unlock(mutex);\n+\n+\treturn NULL;\n+}\n+\n+static int\n+test_thread_mutex(void)\n+{\n+\trte_thread_t threads_ids[THREADS_COUNT];\n+\trte_thread_mutex mutex;\n+\tsize_t i;\n+\tsize_t j;\n+\tint ret = 0;\n+\n+\t/*\n+\t * The value that each thread will increment while holding the mutex.\n+\t */\n+\tval = 0;\n+\n+\tret = rte_thread_mutex_init(&mutex);\n+\tif (ret != 0) {\n+\t\tTEST_THREADS_LOG(\"rte_thread_mutex_init()\");\n+\t\treturn -1;\n+\t}\n+\n+\tfor (i = 0; i < THREADS_COUNT; ++i) {\n+\t\tif (rte_thread_create(&threads_ids[i], NULL,\n+\t\t\t\tthread_loop_mutex, &mutex) != 0) {\n+\t\t\tprintf(\"Error, created only %zu threads\\n\", i);\n+\t\t\tret = -1;\n+\t\t\tgoto error;\n+\t\t}\n+\t}\n+\n+error:\n+\tfor (j = 0; j < i; ++j) {\n+\t\tret = rte_thread_join(threads_ids[j], NULL);\n+\t\tif (ret != 0) {\n+\t\t\tTEST_THREADS_LOG(\"rte_thread_join()\");\n+\t\t\tret = -1;\n+\t\t}\n+\t}\n+\n+\tret = rte_thread_mutex_destroy(&mutex);\n+\tif (ret != 0) {\n+\t\tTEST_THREADS_LOG(\"rte_thread_mutex_destroy()\");\n+\t\tret = -1;\n+\t}\n+\n+\tif (i != val) {\n+\t\tprintf(\"Unexpected value: %zu!. Expected %zu. \"\n+\t\t\t\"Each thread should increment the value once.\\n\",\n+\t\t\tval, i);\n+\t\tret = -1;\n+\t}\n+\n+\treturn ret;\n+}\n+\n+struct thread_affinity_ctx {\n+\tsize_t idx;\n+\tunsigned int result;\n+};\n+\n+static void *\n+thread_loop_attributes_affinity(void *arg)\n+{\n+\tstruct thread_affinity_ctx *ctx = arg;\n+\trte_cpuset_t cpuset;\n+\tsize_t i;\n+\n+\tctx->result = 0;\n+\n+\tCPU_ZERO(&cpuset);\n+\tif (pthread_getaffinity_np(pthread_self(), sizeof(cpuset),\n+\t\t\t&cpuset) != 0) {\n+\t\tctx->result = 1;\n+\t\tTEST_THREADS_LOG(\"pthread_getaffinity_np()\");\n+\t\treturn NULL;\n+\t}\n+\n+\tif (!CPU_ISSET(ctx->idx, &cpuset)) {\n+\t\tctx->result = 1;\n+\t\tprintf(\"CPU %zu should be set for thread %zu\\n\",\n+\t\t\tctx->idx, ctx->idx);\n+\t\treturn NULL;\n+\t}\n+\n+\tfor (i = 0; i < CPU_SETSIZE; ++i) {\n+\t\tif (i != ctx->idx && CPU_ISSET(i, &cpuset)) {\n+\t\t\tctx->result = 1;\n+\t\t\tprintf(\"CPU %zu should not be set for thread %zu\\n\",\n+\t\t\t\ti, ctx->idx);\n+\t\t\treturn NULL;\n+\t\t}\n+\t}\n+\treturn NULL;\n+}\n+\n+static int\n+test_thread_attributes_affinity(void)\n+{\n+\trte_thread_t threads_ids[THREADS_COUNT];\n+\tstruct thread_affinity_ctx ctx[THREADS_COUNT] = {0};\n+\trte_thread_attr_t attr;\n+\trte_cpuset_t cpuset;\n+\tsize_t i;\n+\tsize_t j;\n+\tint ret = 0;\n+\n+\tret = rte_thread_attr_init(&attr);\n+\tif (ret != 0) {\n+\t\tTEST_THREADS_LOG(\"rte_thread_attr_init()\");\n+\t\treturn -1;\n+\t}\n+\n+\tfor (i = 0; i < THREADS_COUNT; ++i) {\n+\t\tCPU_ZERO(&cpuset);\n+\t\tCPU_SET(i, &cpuset);\n+\n+\t\tret = rte_thread_attr_set_affinity(&attr, &cpuset);\n+\t\tif (ret != 0) {\n+\t\t\tret = -1;\n+\t\t\tTEST_THREADS_LOG(\"rte_thread_attr_set_affinity()\");\n+\t\t\tgoto error;\n+\t\t}\n+\n+\t\tctx[i].idx = i;\n+\t\tif (rte_thread_create(&threads_ids[i], &attr,\n+\t\t\t\tthread_loop_attributes_affinity,\n+\t\t\t\t&ctx[i]) != 0) {\n+\t\t\tprintf(\"Error, created only %zu threads\\n\", i);\n+\t\t\tret = -1;\n+\t\t\tgoto error;\n+\t\t}\n+\n+\t}\n+\n+error:\n+\tfor (j = 0; j < i; ++j) {\n+\t\tret = rte_thread_join(threads_ids[j], NULL);\n+\t\tif (ret != 0) {\n+\t\t\tTEST_THREADS_LOG(\"rte_thread_join()\");\n+\t\t\tret = -1;\n+\t\t\tbreak;\n+\t\t}\n+\n+\t\tif (ctx[j].result != 0)\n+\t\t\tret = -1;\n+\t}\n+\n+\treturn ret;\n+}\n+\n+static void *\n+thread_loop_return(void *arg)\n+{\n+\tRTE_SET_USED(arg);\n+\treturn NULL;\n+}\n+\n+static int\n+test_thread_attributes_priority(void)\n+{\n+\trte_thread_t threads_ids[THREADS_COUNT];\n+\trte_thread_attr_t attr;\n+\tsize_t i;\n+\tsize_t j;\n+\tint ret = 0;\n+\tint policy;\n+\tstruct sched_param param;\n+\n+\tret = rte_thread_attr_init(&attr);\n+\tif (ret != 0) {\n+\t\tTEST_THREADS_LOG(\"rte_thread_attr_init()\");\n+\t\treturn -1;\n+\t}\n+\n+\tret = rte_thread_attr_set_priority(&attr, RTE_THREAD_PRIORITY_NORMAL);\n+\tif (ret != 0) {\n+\t\tTEST_THREADS_LOG(\"rte_thread_attr_set_priority()\");\n+\t\treturn -1;\n+\t}\n+\n+\tfor (i = 0; i < THREADS_COUNT; ++i) {\n+\t\tif (rte_thread_create(&threads_ids[i], &attr,\n+\t\t\t\tthread_loop_return, NULL) != 0) {\n+\t\t\tprintf(\"Error, created only %zu threads\\n\", i);\n+\t\t\tret = -1;\n+\t\t\tgoto error;\n+\t\t}\n+\n+\t\tret = pthread_getschedparam(\n+\t\t\t\t(pthread_t)threads_ids[i].opaque_id,\n+\t\t\t\t&policy, &param);\n+\t\tif (ret != 0) {\n+\t\t\tret = -1;\n+\t\t\tTEST_THREADS_LOG(\"pthread_getschedparam()\");\n+\t\t\tgoto error;\n+\t\t}\n+\n+\t\tif (policy != SCHED_OTHER || param.sched_priority != 0) {\n+\t\t\tret = -1;\n+\t\t\tprintf(\"Unexpected priority: %d or policy: %d\\n\",\n+\t\t\t\t\tparam.sched_priority, SCHED_OTHER);\n+\t\t\tgoto error;\n+\t\t}\n+\n+\t}\n+\n+error:\n+\tfor (j = 0; j < i; ++j) {\n+\t\tret = rte_thread_join(threads_ids[j], NULL);\n+\t\tif (ret != 0) {\n+\t\t\tTEST_THREADS_LOG(\"rte_thread_join()\");\n+\t\t\tret = -1;\n+\t\t\tbreak;\n+\t\t}\n+\t}\n+\n+\treturn ret;\n+}\n+\n+static int\n+test_thread_detach(void)\n+{\n+\trte_thread_t threads_ids[THREADS_COUNT];\n+\tsize_t i;\n+\tsize_t j;\n+\tint ret = 0;\n+\n+\tfor (i = 0; i < THREADS_COUNT; ++i) {\n+\t\tif (rte_thread_create(&threads_ids[i], NULL,\n+\t\t\t\tthread_loop_return, NULL) != 0) {\n+\t\t\tprintf(\"Error, Only %zu threads created.\\n\", i);\n+\t\t\tgoto error;\n+\t\t}\n+\t}\n+\n+error:\n+\tfor (j = 0; j < i; ++j) {\n+\t\tret = rte_thread_detach(threads_ids[j]);\n+\t\tif (ret != 0) {\n+\t\t\tTEST_THREADS_LOG(\"rte_thread_detach()\");\n+\t\t\treturn -1;\n+\t\t}\n+\t}\n+\n+\treturn ret;\n+}\n+\n+static struct unit_test_suite threads_test_suite = {\n+\t.suite_name = \"threads autotest\",\n+\t.setup = NULL,\n+\t.teardown = NULL,\n+\t.unit_test_cases = {\n+\t\t\tTEST_CASE(test_thread_self),\n+\t\t\tTEST_CASE(test_thread_barrier),\n+\t\t\tTEST_CASE(test_thread_mutex),\n+\t\t\tTEST_CASE(test_thread_attributes_affinity),\n+\t\t\tTEST_CASE(test_thread_attributes_priority),\n+\t\t\tTEST_CASE(test_thread_detach),\n+\t\t\tTEST_CASES_END()\n+\t}\n+};\n+\n+static int\n+test_threads(void)\n+{\n+\treturn unit_test_suite_runner(&threads_test_suite);\n+}\n+\n+REGISTER_TEST_COMMAND(threads_autotest, test_threads);\n",
    "prefixes": [
        "v11",
        "10/10"
    ]
}