Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 96526,
    "url": "http://patchwork.dpdk.org/api/patches/96526/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210802101847.3462-11-joyce.kong@arm.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20210802101847.3462-11-joyce.kong@arm.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20210802101847.3462-11-joyce.kong@arm.com",
    "date": "2021-08-02T10:18:45",
    "name": "[v1,10/12] app/testpmd: use compiler atomic builtins for port sync",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "30e5f8f68559c7e92bebdec5749cf90cd438ced6",
    "submitter": {
        "id": 970,
        "url": "http://patchwork.dpdk.org/api/people/970/?format=api",
        "name": "Joyce Kong",
        "email": "joyce.kong@arm.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210802101847.3462-11-joyce.kong@arm.com/mbox/",
    "series": [
        {
            "id": 18128,
            "url": "http://patchwork.dpdk.org/api/series/18128/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=18128",
            "date": "2021-08-02T10:18:35",
            "name": "use compiler atomic builtins for app",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/18128/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/96526/comments/",
    "check": "warning",
    "checks": "http://patchwork.dpdk.org/api/patches/96526/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 25B81A0C41;\n\tMon,  2 Aug 2021 12:21:08 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 12E8641136;\n\tMon,  2 Aug 2021 12:21:08 +0200 (CEST)",
            "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id 47BD641136\n for <dev@dpdk.org>; Mon,  2 Aug 2021 12:21:06 +0200 (CEST)",
            "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CB46DD6E;\n Mon,  2 Aug 2021 03:21:05 -0700 (PDT)",
            "from net-arm-n1sdp.shanghai.arm.com (net-arm-n1sdp.shanghai.arm.com\n [10.169.208.222])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1E6543F70D;\n Mon,  2 Aug 2021 03:20:58 -0700 (PDT)"
        ],
        "From": "Joyce Kong <joyce.kong@arm.com>",
        "To": "thomas@monjalon.net, david.marchand@redhat.com,\n honnappa.nagarahalli@arm.com, ruifeng.wang@arm.com,\n konstantin.ananyev@intel.com, rsanford@akamai.com,\n erik.g.carrillo@intel.com, olivier.matz@6wind.com, yipeng1.wang@intel.com,\n sameh.gobriel@intel.com, bruce.richardson@intel.com,\n vladimir.medvedkin@intel.com, anatoly.burakov@intel.com,\n andrew.rybchenko@oktetlabs.ru, jerinj@marvell.com,\n declan.doherty@intel.com, ciara.power@intel.com, xiaoyun.li@intel.com,\n nicolas.chautru@intel.com, maryam.tahhan@intel.com,\n reshma.pattan@intel.com, cristian.dumitrescu@intel.com",
        "Cc": "dev@dpdk.org,\n\tnd@arm.com",
        "Date": "Mon,  2 Aug 2021 05:18:45 -0500",
        "Message-Id": "<20210802101847.3462-11-joyce.kong@arm.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20210802101847.3462-1-joyce.kong@arm.com>",
        "References": "<20210802101847.3462-1-joyce.kong@arm.com>",
        "Subject": "[dpdk-dev] [PATCH v1 10/12] app/testpmd: use compiler atomic\n builtins for port sync",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Replace rte_atomic16_cmpset operation with compiler atomic\nCAS operation for port status sync in testpmd case.\n\nSigned-off-by: Joyce Kong <joyce.kong@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n app/test-pmd/testpmd.c | 75 +++++++++++++++++++++++++++---------------\n 1 file changed, 48 insertions(+), 27 deletions(-)",
    "diff": "diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 6cbe9ba3c8..22579dd438 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -36,7 +36,6 @@\n #include <rte_alarm.h>\n #include <rte_per_lcore.h>\n #include <rte_lcore.h>\n-#include <rte_atomic.h>\n #include <rte_branch_prediction.h>\n #include <rte_mempool.h>\n #include <rte_malloc.h>\n@@ -2302,6 +2301,7 @@ setup_hairpin_queues(portid_t pi, portid_t p_pi, uint16_t cnt_pi)\n \tuint16_t peer_tx_port = pi;\n \tuint32_t manual = 1;\n \tuint32_t tx_exp = hairpin_mode & 0x10;\n+\tuint16_t port_exp;\n \n \tif (!(hairpin_mode & 0xf)) {\n \t\tpeer_rx_port = pi;\n@@ -2347,10 +2347,11 @@ setup_hairpin_queues(portid_t pi, portid_t p_pi, uint16_t cnt_pi)\n \t\tif (diag == 0)\n \t\t\tcontinue;\n \n+\t\tport_exp = RTE_PORT_HANDLING;\n \t\t/* Fail to setup rx queue, return */\n-\t\tif (rte_atomic16_cmpset(&(port->port_status),\n-\t\t\t\t\tRTE_PORT_HANDLING,\n-\t\t\t\t\tRTE_PORT_STOPPED) == 0)\n+\t\tif (__atomic_compare_exchange_n(&(port->port_status),\n+\t\t\t\t&port_exp, RTE_PORT_STOPPED, 0,\n+\t\t\t\t__ATOMIC_RELAXED, __ATOMIC_RELAXED) == 0)\n \t\t\tfprintf(stderr,\n \t\t\t\t\"Port %d can not be set back to stopped\\n\", pi);\n \t\tfprintf(stderr, \"Fail to configure port %d hairpin queues\\n\",\n@@ -2370,10 +2371,11 @@ setup_hairpin_queues(portid_t pi, portid_t p_pi, uint16_t cnt_pi)\n \t\tif (diag == 0)\n \t\t\tcontinue;\n \n+\t\tport_exp = RTE_PORT_HANDLING;\n \t\t/* Fail to setup rx queue, return */\n-\t\tif (rte_atomic16_cmpset(&(port->port_status),\n-\t\t\t\t\tRTE_PORT_HANDLING,\n-\t\t\t\t\tRTE_PORT_STOPPED) == 0)\n+\t\tif (__atomic_compare_exchange_n(&(port->port_status),\n+\t\t\t\t&port_exp, RTE_PORT_STOPPED, 0,\n+\t\t\t\t__ATOMIC_RELAXED, __ATOMIC_RELAXED) == 0)\n \t\t\tfprintf(stderr,\n \t\t\t\t\"Port %d can not be set back to stopped\\n\", pi);\n \t\tfprintf(stderr, \"Fail to configure port %d hairpin queues\\n\",\n@@ -2444,6 +2446,7 @@ start_port(portid_t pid)\n \tqueueid_t qi;\n \tstruct rte_port *port;\n \tstruct rte_eth_hairpin_cap cap;\n+\tuint16_t port_exp;\n \n \tif (port_id_is_invalid(pid, ENABLED_WARN))\n \t\treturn 0;\n@@ -2454,8 +2457,10 @@ start_port(portid_t pid)\n \n \t\tneed_check_link_status = 0;\n \t\tport = &ports[pi];\n-\t\tif (rte_atomic16_cmpset(&(port->port_status), RTE_PORT_STOPPED,\n-\t\t\t\t\t\t RTE_PORT_HANDLING) == 0) {\n+\t\tport_exp = RTE_PORT_STOPPED;\n+\t\tif (__atomic_compare_exchange_n(&(port->port_status),\n+\t\t\t\t&port_exp, RTE_PORT_HANDLING, 0,\n+\t\t\t\t__ATOMIC_RELAXED, __ATOMIC_RELAXED) == 0) {\n \t\t\tfprintf(stderr, \"Port %d is now not stopped\\n\", pi);\n \t\t\tcontinue;\n \t\t}\n@@ -2487,8 +2492,10 @@ start_port(portid_t pid)\n \t\t\t\t\t\t     nb_txq + nb_hairpinq,\n \t\t\t\t\t\t     &(port->dev_conf));\n \t\t\tif (diag != 0) {\n-\t\t\t\tif (rte_atomic16_cmpset(&(port->port_status),\n-\t\t\t\tRTE_PORT_HANDLING, RTE_PORT_STOPPED) == 0)\n+\t\t\t\tport_exp = RTE_PORT_HANDLING;\n+\t\t\t\tif (__atomic_compare_exchange_n(&(port->port_status),\n+\t\t\t\t\t\t&port_exp, RTE_PORT_STOPPED, 0,\n+\t\t\t\t\t\t__ATOMIC_RELAXED, __ATOMIC_RELAXED) == 0)\n \t\t\t\t\tfprintf(stderr,\n \t\t\t\t\t\t\"Port %d can not be set back to stopped\\n\",\n \t\t\t\t\t\tpi);\n@@ -2518,10 +2525,11 @@ start_port(portid_t pid)\n \t\t\t\tif (diag == 0)\n \t\t\t\t\tcontinue;\n \n+\t\t\t\tport_exp = RTE_PORT_HANDLING;\n \t\t\t\t/* Fail to setup tx queue, return */\n-\t\t\t\tif (rte_atomic16_cmpset(&(port->port_status),\n-\t\t\t\t\t\t\tRTE_PORT_HANDLING,\n-\t\t\t\t\t\t\tRTE_PORT_STOPPED) == 0)\n+\t\t\t\tif (__atomic_compare_exchange_n(&(port->port_status),\n+\t\t\t\t\t\t&port_exp, RTE_PORT_STOPPED, 0,\n+\t\t\t\t\t\t__ATOMIC_RELAXED, __ATOMIC_RELAXED) == 0)\n \t\t\t\t\tfprintf(stderr,\n \t\t\t\t\t\t\"Port %d can not be set back to stopped\\n\",\n \t\t\t\t\t\tpi);\n@@ -2570,10 +2578,11 @@ start_port(portid_t pid)\n \t\t\t\tif (diag == 0)\n \t\t\t\t\tcontinue;\n \n+\t\t\t\tport_exp = RTE_PORT_HANDLING;\n \t\t\t\t/* Fail to setup rx queue, return */\n-\t\t\t\tif (rte_atomic16_cmpset(&(port->port_status),\n-\t\t\t\t\t\t\tRTE_PORT_HANDLING,\n-\t\t\t\t\t\t\tRTE_PORT_STOPPED) == 0)\n+\t\t\t\tif (__atomic_compare_exchange_n(&(port->port_status),\n+\t\t\t\t\t\t&port_exp, RTE_PORT_STOPPED, 0,\n+\t\t\t\t\t\t__ATOMIC_RELAXED, __ATOMIC_RELAXED) == 0)\n \t\t\t\t\tfprintf(stderr,\n \t\t\t\t\t\t\"Port %d can not be set back to stopped\\n\",\n \t\t\t\t\t\tpi);\n@@ -2607,17 +2616,21 @@ start_port(portid_t pid)\n \t\t\tfprintf(stderr, \"Fail to start port %d: %s\\n\",\n \t\t\t\tpi, rte_strerror(-diag));\n \n+\t\t\tport_exp = RTE_PORT_HANDLING;\n \t\t\t/* Fail to setup rx queue, return */\n-\t\t\tif (rte_atomic16_cmpset(&(port->port_status),\n-\t\t\t\tRTE_PORT_HANDLING, RTE_PORT_STOPPED) == 0)\n+\t\t\tif (__atomic_compare_exchange_n(&(port->port_status),\n+\t\t\t\t\t&port_exp, RTE_PORT_STOPPED, 0,\n+\t\t\t\t\t__ATOMIC_RELAXED, __ATOMIC_RELAXED) == 0)\n \t\t\t\tfprintf(stderr,\n \t\t\t\t\t\"Port %d can not be set back to stopped\\n\",\n \t\t\t\t\tpi);\n \t\t\tcontinue;\n \t\t}\n \n-\t\tif (rte_atomic16_cmpset(&(port->port_status),\n-\t\t\tRTE_PORT_HANDLING, RTE_PORT_STARTED) == 0)\n+\t\tport_exp = RTE_PORT_HANDLING;\n+\t\tif (__atomic_compare_exchange_n(&(port->port_status),\n+\t\t\t\t&port_exp, RTE_PORT_STARTED, 0,\n+\t\t\t\t__ATOMIC_RELAXED, __ATOMIC_RELAXED) == 0)\n \t\t\tfprintf(stderr, \"Port %d can not be set into started\\n\",\n \t\t\t\tpi);\n \n@@ -2697,6 +2710,7 @@ stop_port(portid_t pid)\n \tint need_check_link_status = 0;\n \tportid_t peer_pl[RTE_MAX_ETHPORTS];\n \tint peer_pi;\n+\tuint16_t port_exp;\n \n \tif (port_id_is_invalid(pid, ENABLED_WARN))\n \t\treturn;\n@@ -2722,8 +2736,10 @@ stop_port(portid_t pid)\n \t\t}\n \n \t\tport = &ports[pi];\n-\t\tif (rte_atomic16_cmpset(&(port->port_status), RTE_PORT_STARTED,\n-\t\t\t\t\t\tRTE_PORT_HANDLING) == 0)\n+\t\tport_exp = RTE_PORT_STARTED;\n+\t\tif (__atomic_compare_exchange_n(&(port->port_status),\n+\t\t\t\t&port_exp, RTE_PORT_HANDLING, 0,\n+\t\t\t\t__ATOMIC_RELAXED, __ATOMIC_RELAXED) == 0)\n \t\t\tcontinue;\n \n \t\tif (hairpin_mode & 0xf) {\n@@ -2749,8 +2765,10 @@ stop_port(portid_t pid)\n \t\t\tRTE_LOG(ERR, EAL, \"rte_eth_dev_stop failed for port %u\\n\",\n \t\t\t\tpi);\n \n-\t\tif (rte_atomic16_cmpset(&(port->port_status),\n-\t\t\tRTE_PORT_HANDLING, RTE_PORT_STOPPED) == 0)\n+\t\tport_exp = RTE_PORT_HANDLING;\n+\t\tif (__atomic_compare_exchange_n(&(port->port_status),\n+\t\t\t\t&port_exp, RTE_PORT_STOPPED, 0,\n+\t\t\t\t__ATOMIC_RELAXED, __ATOMIC_RELAXED) == 0)\n \t\t\tfprintf(stderr, \"Port %d can not be set into stopped\\n\",\n \t\t\t\tpi);\n \t\tneed_check_link_status = 1;\n@@ -2788,6 +2806,7 @@ close_port(portid_t pid)\n {\n \tportid_t pi;\n \tstruct rte_port *port;\n+\tuint16_t port_exp;\n \n \tif (port_id_is_invalid(pid, ENABLED_WARN))\n \t\treturn;\n@@ -2813,8 +2832,10 @@ close_port(portid_t pid)\n \t\t}\n \n \t\tport = &ports[pi];\n-\t\tif (rte_atomic16_cmpset(&(port->port_status),\n-\t\t\tRTE_PORT_CLOSED, RTE_PORT_CLOSED) == 1) {\n+\t\tport_exp = RTE_PORT_CLOSED;\n+\t\tif (__atomic_compare_exchange_n(&(port->port_status),\n+\t\t\t\t&port_exp, RTE_PORT_CLOSED, 0,\n+\t\t\t\t__ATOMIC_RELAXED, __ATOMIC_RELAXED)) {\n \t\t\tfprintf(stderr, \"Port %d is already closed\\n\", pi);\n \t\t\tcontinue;\n \t\t}\n",
    "prefixes": [
        "v1",
        "10/12"
    ]
}