Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/96999/?format=api
{ "id": 96999, "url": "http://patchwork.dpdk.org/api/patches/96999/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210817134441.1966618-9-michaelba@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210817134441.1966618-9-michaelba@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210817134441.1966618-9-michaelba@nvidia.com", "date": "2021-08-17T13:44:28", "name": "[RFC,08/21] net/mlx5: improve probe function on Linux", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": true, "hash": "c131b0915b502959e1c543a47551db88107000dc", "submitter": { "id": 1949, "url": "http://patchwork.dpdk.org/api/people/1949/?format=api", "name": "Michael Baum", "email": "michaelba@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patchwork.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210817134441.1966618-9-michaelba@nvidia.com/mbox/", "series": [ { "id": 18314, "url": "http://patchwork.dpdk.org/api/series/18314/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=18314", "date": "2021-08-17T13:44:20", "name": "mlx5: sharing global MR cache between drivers", "version": 1, "mbox": "http://patchwork.dpdk.org/series/18314/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/96999/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/96999/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1FC6BA0548;\n\tTue, 17 Aug 2021 15:46:35 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D60D5411ED;\n\tTue, 17 Aug 2021 15:45:32 +0200 (CEST)", "from NAM10-BN7-obe.outbound.protection.outlook.com\n (mail-bn7nam10on2041.outbound.protection.outlook.com [40.107.92.41])\n by mails.dpdk.org (Postfix) with ESMTP id A672A411DD\n for <dev@dpdk.org>; Tue, 17 Aug 2021 15:45:29 +0200 (CEST)", "from MWHPR04CA0053.namprd04.prod.outlook.com (2603:10b6:300:6c::15)\n by SA0PR12MB4480.namprd12.prod.outlook.com (2603:10b6:806:99::10)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.14; Tue, 17 Aug\n 2021 13:45:28 +0000", "from CO1NAM11FT034.eop-nam11.prod.protection.outlook.com\n (2603:10b6:300:6c:cafe::bf) by MWHPR04CA0053.outlook.office365.com\n (2603:10b6:300:6c::15) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19 via Frontend\n Transport; Tue, 17 Aug 2021 13:45:28 +0000", "from mail.nvidia.com (216.228.112.32) by\n CO1NAM11FT034.mail.protection.outlook.com (10.13.174.248) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4415.14 via Frontend Transport; Tue, 17 Aug 2021 13:45:28 +0000", "from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL109.nvidia.com\n (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 17 Aug\n 2021 06:45:27 -0700", "from nvidia.com (172.20.187.6) by DRHQMAIL107.nvidia.com\n (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 17 Aug\n 2021 13:45:26 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=O9C3MP9BA1AEsAcn9g3046i/HARJO7TWNrqiTK7fucNC/ym0ynwdzUqogFgCCuT8+f1DZJwQYXweG077EPsRi/rd2QBntHnIHF4IiOouQW2HLOH3Zeby2svc/2lkXdw3022KxZSX9DJ0G2T+pKQugdJ8uUY7TvAst5V8vlhyR4j1WdRF03kgelVG9Z8XAL2efeP1/G5l2t0QIisQ5q2HGIsolQpQScDCUFIiipxNzWQoUipPnKqHY9+ev31aebzRAGHf2n8EznivqbOv+nLeSDJCMiN8w2S0Zpo7q05YFuEBn10vrByMwZswWS5uCThNUQ/qRxVEZkc8+wU605SLjA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=8Zx1kK4VZC4/lrxToNWcmpObEPh8PdI6sG0yMr3/OnM=;\n b=DZWyrTnkDwltBdqSM/RW4T/l81pBS7yLJ+WltKSaIVU/4OKzIdpFFPG4S94vRs1yx1ypd6J1KLYxsR0X1+DujI4bYKvfu66PQ0kvesXB0DKapuvWuchskykLp0IyWU2a/607U1kJc+WkZhUrcFX23huzwt7ThnhCIoZL5bIXB4ZJW7eQqo6AgRK9CzjlXb/l+HIpLoCRriNbmp/2Vp4T+Mo1w/bYsmrnnIAXKyjcvvtW0k6aRUKm8IhUCjXO/xRNtbbtpulxX+YnCO0rBX1e4B7KZkPfRAzb0DBhYg+A2wWUB72RjCzdKaOfZDaiHZT9wItc7P6vUQAVPy2cMRUhYw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.32) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=8Zx1kK4VZC4/lrxToNWcmpObEPh8PdI6sG0yMr3/OnM=;\n b=Cdi0aqdEY5axVlWfeAFPLberWiZdHsaAF9cMX25wJVVmOlmLcgSiNkahNC/DDJf7zI43goueznJZZu7XR9EYV2c4XEHlv+eYBnLujyHZXdS7jZ5BuwAOVffQYkLiznDBKaEQgQotUBxZSfYDHlVxpG1DlZ3dbvWgJUO8/thzt//0oQwc8R3Xk+ckP1weAtvuuLDjF21BoPixn5J3URJkqeef7T2n5fGLosqiswT3vW1M5SlagoqziYEjOoqMaKIg99ewwyaCp5bTaJ8AQTXtwQh0YNc8nFT7V2tCbPzPV3+TyKciCWeceSYupz5qvoDzQqa8+D+VXiyDv6zCHC3UqQ==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.32)\n smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.32 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.32; helo=mail.nvidia.com;", "From": "Michael Baum <michaelba@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "Matan Azrad <matan@nvidia.com>, Raslan Darawsheh <rasland@nvidia.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>", "Date": "Tue, 17 Aug 2021 16:44:28 +0300", "Message-ID": "<20210817134441.1966618-9-michaelba@nvidia.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210817134441.1966618-1-michaelba@nvidia.com>", "References": "<20210817134441.1966618-1-michaelba@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.187.6]", "X-ClientProxiedBy": "HQMAIL111.nvidia.com (172.20.187.18) To\n DRHQMAIL107.nvidia.com (10.27.9.16)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "220e2380-142e-4234-82ef-08d961854615", "X-MS-TrafficTypeDiagnostic": "SA0PR12MB4480:", "X-Microsoft-Antispam-PRVS": "\n <SA0PR12MB448087658C3CD62EF7DBD1FACCFE9@SA0PR12MB4480.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:6790;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n x5sdsBhlApU9OzX9iB4e5dJYc/i0fjourFW/x0cHJmp4Nr2LLVvfbIBxUyTw54WarufybRyS1kRq2he0/+8N8HnHFdCmX5f4lEh12IiCfdvNNSZcsAfXszEps2nkZ5fk2WZS2L3vu39depqiD/fAUpZvIB6bmWZA2/yaANQlYyrPJwgFoKlvZwdR/BtmL0Ii+vdXf4h00Lq4fYS71r4icb+vgymNJn009ZmswsNtvWyIbeom3NcJU8mukK8yRPreq+u8P5kA/zHB5+l3OcO9xD7PTL/O4FiQBdZUMGYbJ39zg/tfW9Y9oXrW/XXHuE/9GFyiVIy+NUpOMbJS1X+YaYKPy6gN4DeKqNF7tvA1E2AYCJQltIvr9f6sV9PVHPM5m0RWmatMXkaFNcq86oetIdcrw2YbiPBK7ATc6i3Whuw1CWSCz1tsWHQPB/UK+UIdOop1+Wr3hyONstZNZ1UE52vmNwju1HsZELf/lIIkEK9CipA18t2/AsOHyFEWSk2S6EFh8LQ3LMrHaxfbyIbtPKkKy1oM12JMDBwnmkf8rsniCdtpmXJ8uF9k1ree/0Nk3hdozEC4ZQtIsTp7N+wSxo0grlAterT2lHS84kZjyAZwOqkN2A5/L+FAf+uH1kQY7q2P47An+VrkQMDUZr9G0166YjtReXinaESz88s8OOhC+L4WQZgh79PchOWZ50djajLRpra1dXYcMqcQ6OvHqg==", "X-Forefront-Antispam-Report": "CIP:216.228.112.32; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid01.nvidia.com; CAT:NONE;\n SFS:(4636009)(46966006)(36840700001)(36860700001)(336012)(47076005)(16526019)(186003)(26005)(54906003)(356005)(6916009)(426003)(2616005)(2906002)(1076003)(7636003)(107886003)(5660300002)(83380400001)(316002)(82310400003)(4326008)(7696005)(508600001)(8936002)(86362001)(70206006)(36756003)(8676002)(70586007)(6286002)(55016002);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "17 Aug 2021 13:45:28.3045 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 220e2380-142e-4234-82ef-08d961854615", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.32];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT034.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SA0PR12MB4480", "Subject": "[dpdk-dev] [RFC 08/21] net/mlx5: improve probe function on Linux", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "some improvements:\n- Update parameters for mlx5_device_bond_pci_match function.\n- Fix spelling and typos in comments.\n- Prevent breaking lines on drv logs.\n\nSigned-off-by: Michael Baum <michaelba@nvidia.com>\n---\n drivers/net/mlx5/linux/mlx5_os.c | 96 ++++++++++++++------------------\n 1 file changed, 42 insertions(+), 54 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c\nindex 3d204f99f7..375bc55e79 100644\n--- a/drivers/net/mlx5/linux/mlx5_os.c\n+++ b/drivers/net/mlx5/linux/mlx5_os.c\n@@ -1984,14 +1984,14 @@ mlx5_dev_spawn_data_cmp(const void *a, const void *b)\n /**\n * Match PCI information for possible slaves of bonding device.\n *\n- * @param[in] ibv_dev\n- * Pointer to Infiniband device structure.\n+ * @param[in] ibdev_name\n+ * Name of Infiniband device.\n * @param[in] pci_dev\n * Pointer to primary PCI address structure to match.\n * @param[in] nl_rdma\n * Netlink RDMA group socket handle.\n * @param[in] owner\n- * Rerepsentor owner PF index.\n+ * Representor owner PF index.\n * @param[out] bond_info\n * Pointer to bonding information.\n *\n@@ -2000,7 +2000,7 @@ mlx5_dev_spawn_data_cmp(const void *a, const void *b)\n * positive index of slave PF in bonding.\n */\n static int\n-mlx5_device_bond_pci_match(const struct ibv_device *ibv_dev,\n+mlx5_device_bond_pci_match(const char *ibdev_name,\n \t\t\t const struct rte_pci_addr *pci_dev,\n \t\t\t int nl_rdma, uint16_t owner,\n \t\t\t struct mlx5_bond_info *bond_info)\n@@ -2013,27 +2013,25 @@ mlx5_device_bond_pci_match(const struct ibv_device *ibv_dev,\n \tint ret;\n \n \t/*\n-\t * Try to get master device name. If something goes\n-\t * wrong suppose the lack of kernel support and no\n-\t * bonding devices.\n+\t * Try to get master device name. If something goes wrong suppose\n+\t * the lack of kernel support and no bonding devices.\n \t */\n \tmemset(bond_info, 0, sizeof(*bond_info));\n \tif (nl_rdma < 0)\n \t\treturn -1;\n-\tif (!strstr(ibv_dev->name, \"bond\"))\n+\tif (!strstr(ibdev_name, \"bond\"))\n \t\treturn -1;\n-\tnp = mlx5_nl_portnum(nl_rdma, ibv_dev->name);\n+\tnp = mlx5_nl_portnum(nl_rdma, ibdev_name);\n \tif (!np)\n \t\treturn -1;\n \t/*\n-\t * The Master device might not be on the predefined\n-\t * port (not on port index 1, it is not garanted),\n-\t * we have to scan all Infiniband device port and\n-\t * find master.\n+\t * The master device might not be on the predefined port(not on port\n+\t * index 1, it is not guaranteed), we have to scan all Infiniband\n+\t * device ports and find master.\n \t */\n \tfor (i = 1; i <= np; ++i) {\n \t\t/* Check whether Infiniband port is populated. */\n-\t\tifindex = mlx5_nl_ifindex(nl_rdma, ibv_dev->name, i);\n+\t\tifindex = mlx5_nl_ifindex(nl_rdma, ibdev_name, i);\n \t\tif (!ifindex)\n \t\t\tcontinue;\n \t\tif (!if_indextoname(ifindex, ifname))\n@@ -2058,8 +2056,9 @@ mlx5_device_bond_pci_match(const struct ibv_device *ibv_dev,\n \t\tsnprintf(tmp_str, sizeof(tmp_str),\n \t\t\t \"/sys/class/net/%s\", ifname);\n \t\tif (mlx5_get_pci_addr(tmp_str, &pci_addr)) {\n-\t\t\tDRV_LOG(WARNING, \"can not get PCI address\"\n-\t\t\t\t\t \" for netdev \\\"%s\\\"\", ifname);\n+\t\t\tDRV_LOG(WARNING,\n+\t\t\t\t\"Cannot get PCI address for netdev \\\"%s\\\".\",\n+\t\t\t\tifname);\n \t\t\tcontinue;\n \t\t}\n \t\t/* Slave interface PCI address match found. */\n@@ -2218,9 +2217,8 @@ mlx5_os_pci_probe_pf(struct rte_pci_device *pci_dev,\n \t\tstruct rte_pci_addr pci_addr;\n \n \t\tDRV_LOG(DEBUG, \"checking device \\\"%s\\\"\", ibv_list[ret]->name);\n-\t\tbd = mlx5_device_bond_pci_match\n-\t\t\t\t(ibv_list[ret], &owner_pci, nl_rdma, owner_id,\n-\t\t\t\t &bond_info);\n+\t\tbd = mlx5_device_bond_pci_match(ibv_list[ret]->name, &owner_pci,\n+\t\t\t\t\t\tnl_rdma, owner_id, &bond_info);\n \t\tif (bd >= 0) {\n \t\t\t/*\n \t\t\t * Bonding device detected. Only one match is allowed,\n@@ -2240,9 +2238,9 @@ mlx5_os_pci_probe_pf(struct rte_pci_device *pci_dev,\n \t\t\t/* Amend owner pci address if owner PF ID specified. */\n \t\t\tif (eth_da.nb_representor_ports)\n \t\t\t\towner_pci.function += owner_id;\n-\t\t\tDRV_LOG(INFO, \"PCI information matches for\"\n-\t\t\t\t \" slave %d bonding device \\\"%s\\\"\",\n-\t\t\t\t bd, ibv_list[ret]->name);\n+\t\t\tDRV_LOG(INFO,\n+\t\t\t\t\"PCI information matches for slave %d bonding device \\\"%s\\\"\",\n+\t\t\t\tbd, ibv_list[ret]->name);\n \t\t\tibv_match[nd++] = ibv_list[ret];\n \t\t\tbreak;\n \t\t} else {\n@@ -2281,23 +2279,19 @@ mlx5_os_pci_probe_pf(struct rte_pci_device *pci_dev,\n \t\tif (nl_rdma >= 0)\n \t\t\tnp = mlx5_nl_portnum(nl_rdma, ibv_match[0]->name);\n \t\tif (!np)\n-\t\t\tDRV_LOG(WARNING, \"can not get IB device \\\"%s\\\"\"\n-\t\t\t\t\t \" ports number\", ibv_match[0]->name);\n+\t\t\tDRV_LOG(WARNING,\n+\t\t\t\t\"Cannot get IB device \\\"%s\\\" ports number.\",\n+\t\t\t\tibv_match[0]->name);\n \t\tif (bd >= 0 && !np) {\n-\t\t\tDRV_LOG(ERR, \"can not get ports\"\n-\t\t\t\t \" for bonding device\");\n+\t\t\tDRV_LOG(ERR, \"Cannot get ports for bonding device.\");\n \t\t\trte_errno = ENOENT;\n \t\t\tret = -rte_errno;\n \t\t\tgoto exit;\n \t\t}\n \t}\n-\t/*\n-\t * Now we can determine the maximal\n-\t * amount of devices to be spawned.\n-\t */\n+\t/* Now we can determine the maximal amount of devices to be spawned. */\n \tlist = mlx5_malloc(MLX5_MEM_ZERO,\n-\t\t\t sizeof(struct mlx5_dev_spawn_data) *\n-\t\t\t (np ? np : nd),\n+\t\t\t sizeof(struct mlx5_dev_spawn_data) * (np ? np : nd),\n \t\t\t RTE_CACHE_LINE_SIZE, SOCKET_ID_ANY);\n \tif (!list) {\n \t\tDRV_LOG(ERR, \"spawn data array allocation failure\");\n@@ -2339,10 +2333,9 @@ mlx5_os_pci_probe_pf(struct rte_pci_device *pci_dev,\n \t\t\t}\n \t\t\tret = -1;\n \t\t\tif (nl_route >= 0)\n-\t\t\t\tret = mlx5_nl_switch_info\n-\t\t\t\t\t (nl_route,\n-\t\t\t\t\t\tlist[ns].ifindex,\n-\t\t\t\t\t\t&list[ns].info);\n+\t\t\t\tret = mlx5_nl_switch_info(nl_route,\n+\t\t\t\t\t\t\t list[ns].ifindex,\n+\t\t\t\t\t\t\t &list[ns].info);\n \t\t\tif (ret || (!list[ns].info.representor &&\n \t\t\t\t !list[ns].info.master)) {\n \t\t\t\t/*\n@@ -2350,9 +2343,8 @@ mlx5_os_pci_probe_pf(struct rte_pci_device *pci_dev,\n \t\t\t\t * Netlink, let's try to perform the task\n \t\t\t\t * with sysfs.\n \t\t\t\t */\n-\t\t\t\tret = mlx5_sysfs_switch_info\n-\t\t\t\t\t\t(list[ns].ifindex,\n-\t\t\t\t\t\t &list[ns].info);\n+\t\t\t\tret = mlx5_sysfs_switch_info(list[ns].ifindex,\n+\t\t\t\t\t\t\t &list[ns].info);\n \t\t\t}\n \t\t\tif (!ret && bd >= 0) {\n \t\t\t\tswitch (list[ns].info.name_type) {\n@@ -2465,10 +2457,9 @@ mlx5_os_pci_probe_pf(struct rte_pci_device *pci_dev,\n \t\t\t}\n \t\t\tret = -1;\n \t\t\tif (nl_route >= 0)\n-\t\t\t\tret = mlx5_nl_switch_info\n-\t\t\t\t\t (nl_route,\n-\t\t\t\t\t\tlist[ns].ifindex,\n-\t\t\t\t\t\t&list[ns].info);\n+\t\t\t\tret = mlx5_nl_switch_info(nl_route,\n+\t\t\t\t\t\t\t list[ns].ifindex,\n+\t\t\t\t\t\t\t &list[ns].info);\n \t\t\tif (ret || (!list[ns].info.representor &&\n \t\t\t\t !list[ns].info.master)) {\n \t\t\t\t/*\n@@ -2476,9 +2467,8 @@ mlx5_os_pci_probe_pf(struct rte_pci_device *pci_dev,\n \t\t\t\t * Netlink, let's try to perform the task\n \t\t\t\t * with sysfs.\n \t\t\t\t */\n-\t\t\t\tret = mlx5_sysfs_switch_info\n-\t\t\t\t\t\t(list[ns].ifindex,\n-\t\t\t\t\t\t &list[ns].info);\n+\t\t\t\tret = mlx5_sysfs_switch_info(list[ns].ifindex,\n+\t\t\t\t\t\t\t &list[ns].info);\n \t\t\t}\n \t\t\tif (!ret && (list[ns].info.representor ^\n \t\t\t\t list[ns].info.master)) {\n@@ -2487,11 +2477,10 @@ mlx5_os_pci_probe_pf(struct rte_pci_device *pci_dev,\n \t\t\t\t !list[ns].info.representor &&\n \t\t\t\t !list[ns].info.master) {\n \t\t\t\t/*\n-\t\t\t\t * Single IB device with\n-\t\t\t\t * one physical port and\n+\t\t\t\t * Single IB device with one physical port and\n \t\t\t\t * attached network device.\n-\t\t\t\t * May be SRIOV is not enabled\n-\t\t\t\t * or there is no representors.\n+\t\t\t\t * May be SRIOV is not enabled or there is no\n+\t\t\t\t * representors.\n \t\t\t\t */\n \t\t\t\tDRV_LOG(INFO, \"no E-Switch support detected\");\n \t\t\t\tns++;\n@@ -2508,10 +2497,9 @@ mlx5_os_pci_probe_pf(struct rte_pci_device *pci_dev,\n \t\t}\n \t\t/*\n \t\t * New kernels may add the switch_id attribute for the case\n-\t\t * there is no E-Switch and we wrongly recognized the\n-\t\t * only device as master. Override this if there is the\n-\t\t * single device with single port and new device name\n-\t\t * format present.\n+\t\t * there is no E-Switch and we wrongly recognized the only\n+\t\t * device as master. Override this if there is the single\n+\t\t * device with single port and new device name format present.\n \t\t */\n \t\tif (nd == 1 &&\n \t\t list[0].info.name_type == MLX5_PHYS_PORT_NAME_TYPE_UPLINK) {\n", "prefixes": [ "RFC", "08/21" ] }