mbox series

[v5,0/2] introduce NitroSketch Mode into membership library

Message ID 20220916030317.3111820-1-leyi.rong@intel.com (mailing list archive)
Headers
Series introduce NitroSketch Mode into membership library |

Message

Leyi Rong Sept. 16, 2022, 3:03 a.m. UTC 
  This patchset introduce a brand new NitroSketch Mode into membership
library. This algorithm provides high-fidelity approximate measurements
and appears as a promissing alternative to triditional approches such as
packet sampling.

---
v5:
- meson.build rework.

v4:
- remove extra avx512 complier flags from the cflags.

v3:
- mark below new added APIs as "experimental":
	rte_member_add_byte_count()
	rte_member_query_count()
	rte_member_report_heavyhitter()
- meson build file rework for potential runtime issue.

v2:
- attach paper link to commit log.
- fix potential memory leaks in test_member.c.
- build error fix according to CI build fail log.

Leyi Rong (2):
  member: implement NitroSketch mode
  test/member: add functional and perf tests for sketch

 app/test/test_member.c                | 272 ++++++++++++
 app/test/test_member_perf.c           | 153 ++++++-
 lib/member/meson.build                |  49 ++-
 lib/member/rte_member.c               |  75 ++++
 lib/member/rte_member.h               | 154 ++++++-
 lib/member/rte_member_heap.h          | 424 ++++++++++++++++++
 lib/member/rte_member_sketch.c        | 594 ++++++++++++++++++++++++++
 lib/member/rte_member_sketch.h        |  97 +++++
 lib/member/rte_member_sketch_avx512.c |  70 +++
 lib/member/rte_member_sketch_avx512.h |  35 ++
 lib/member/rte_xxh64_avx512.h         | 117 +++++
 lib/member/version.map                |   9 +
 12 files changed, 2040 insertions(+), 9 deletions(-)
 create mode 100644 lib/member/rte_member_heap.h
 create mode 100644 lib/member/rte_member_sketch.c
 create mode 100644 lib/member/rte_member_sketch.h
 create mode 100644 lib/member/rte_member_sketch_avx512.c
 create mode 100644 lib/member/rte_member_sketch_avx512.h
 create mode 100644 lib/member/rte_xxh64_avx512.h

Comments

Thomas Monjalon Oct. 9, 2022, 11:13 p.m. UTC | #1 
16/09/2022 05:03, Leyi Rong:
> This patchset introduce a brand new NitroSketch Mode into membership
> library. This algorithm provides high-fidelity approximate measurements
> and appears as a promissing alternative to triditional approches such as
> packet sampling.
[...]
> Leyi Rong (2):
>   member: implement NitroSketch mode
>   test/member: add functional and perf tests for sketch

Fixed few code style warnings, added a release note,
and applied, thanks.
Leyi Rong Oct. 10, 2022, 2:36 a.m. UTC | #2 
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Monday, October 10, 2022 7:13 AM
> To: Rong, Leyi <leyi.rong@intel.com>
> Cc: ferruh.yigit@xilinx.com; Richardson, Bruce <bruce.richardson@intel.com>;
> david.marchand@redhat.com; suanmingm@nvidia.com; Wang, Yipeng1
> <yipeng1.wang@intel.com>; zaoxingliu@gmail.com; Gobriel, Sameh
> <sameh.gobriel@intel.com>; dev@dpdk.org; dev@dpdk.org
> Subject: Re: [PATCH v5 0/2] introduce NitroSketch Mode into membership
> library
> 
> 16/09/2022 05:03, Leyi Rong:
> > This patchset introduce a brand new NitroSketch Mode into membership
> > library. This algorithm provides high-fidelity approximate
> > measurements and appears as a promissing alternative to triditional
> > approches such as packet sampling.
> [...]
> > Leyi Rong (2):
> >   member: implement NitroSketch mode
> >   test/member: add functional and perf tests for sketch
> 
> Fixed few code style warnings, added a release note, and applied, thanks.
> 

Thank you, Thomas!
Thomas Monjalon Oct. 10, 2022, 7:30 a.m. UTC | #3 
10/10/2022 04:36, Rong, Leyi:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 16/09/2022 05:03, Leyi Rong:
> > > This patchset introduce a brand new NitroSketch Mode into membership
> > > library. This algorithm provides high-fidelity approximate
> > > measurements and appears as a promissing alternative to triditional
> > > approches such as packet sampling.
> > [...]
> > > Leyi Rong (2):
> > >   member: implement NitroSketch mode
> > >   test/member: add functional and perf tests for sketch
> > 
> > Fixed few code style warnings, added a release note, and applied, thanks.
> > 
> 
> Thank you, Thomas!

Please, could you check this compilation issue?
https://bugs.dpdk.org/show_bug.cgi?id=1096
Leyi Rong Oct. 10, 2022, 8:28 a.m. UTC | #4 
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Monday, October 10, 2022 3:30 PM
> To: Rong, Leyi <leyi.rong@intel.com>
> Cc: ferruh.yigit@xilinx.com; Richardson, Bruce <bruce.richardson@intel.com>;
> david.marchand@redhat.com; suanmingm@nvidia.com; Wang, Yipeng1
> <yipeng1.wang@intel.com>; zaoxingliu@gmail.com; Gobriel, Sameh
> <sameh.gobriel@intel.com>; dev@dpdk.org
> Subject: Re: [PATCH v5 0/2] introduce NitroSketch Mode into membership
> library
> 
> 10/10/2022 04:36, Rong, Leyi:
> > From: Thomas Monjalon <thomas@monjalon.net>
> > > 16/09/2022 05:03, Leyi Rong:
> > > > This patchset introduce a brand new NitroSketch Mode into
> > > > membership library. This algorithm provides high-fidelity
> > > > approximate measurements and appears as a promissing alternative
> > > > to triditional approches such as packet sampling.
> > > [...]
> > > > Leyi Rong (2):
> > > >   member: implement NitroSketch mode
> > > >   test/member: add functional and perf tests for sketch
> > >
> > > Fixed few code style warnings, added a release note, and applied, thanks.
> > >
> >
> > Thank you, Thomas!
> 
> Please, could you check this compilation issue?
> https://bugs.dpdk.org/show_bug.cgi?id=1096
> 

Yes, fix patch is sent with https://patchwork.dpdk.org/project/dpdk/patch/20221010082245.2868071-1-leyi.rong@intel.com/
> 
> 
>