[dpdk-dev,v2] drivers/net: document missing speed capabilities feature
Checks
Commit Message
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Please fix partially support to fully supported speed capabilities.
Please check other features of PMD and document missing ones in features
file.
Thanks.
v2:
* Mark PMDs that return speed capabilities without checking real
hardware capabilities to Partially supported "P".
* Mark PMDs return fake speed capabilities to "P", like virtio and
vmxnet3.
---
doc/guides/nics/features/ark.ini | 1 +
doc/guides/nics/features/bnx2x.ini | 1 +
doc/guides/nics/features/bnx2x_vf.ini | 1 +
doc/guides/nics/features/cxgbe.ini | 1 +
doc/guides/nics/features/dpaa2.ini | 1 +
doc/guides/nics/features/e1000.ini | 1 +
doc/guides/nics/features/ena.ini | 1 +
doc/guides/nics/features/fm10k.ini | 1 +
doc/guides/nics/features/fm10k_vec.ini | 1 +
doc/guides/nics/features/fm10k_vf.ini | 1 +
doc/guides/nics/features/fm10k_vf_vec.ini | 1 +
doc/guides/nics/features/i40e.ini | 1 +
doc/guides/nics/features/i40e_vec.ini | 1 +
doc/guides/nics/features/igb.ini | 1 +
doc/guides/nics/features/ixgbe.ini | 1 +
doc/guides/nics/features/ixgbe_vec.ini | 1 +
doc/guides/nics/features/mlx4.ini | 1 +
doc/guides/nics/features/szedata2.ini | 1 +
doc/guides/nics/features/tap.ini | 2 +-
doc/guides/nics/features/virtio.ini | 1 +
doc/guides/nics/features/virtio_vec.ini | 1 +
doc/guides/nics/features/vmxnet3.ini | 1 +
22 files changed, 22 insertions(+), 1 deletion(-)
Comments
Hi,
In the case of tap PMD, I would say it's rather partially supported (P).
Best regards,
Pascal
On Mon, 15 May 2017 11:59:46 +0100
Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>
> Please fix partially support to fully supported speed capabilities.
>
> Please check other features of PMD and document missing ones in features
> file.
>
> Thanks.
>
> v2:
> * Mark PMDs that return speed capabilities without checking real
> hardware capabilities to Partially supported "P".
> * Mark PMDs return fake speed capabilities to "P", like virtio and
> vmxnet3.
> ---
> doc/guides/nics/features/ark.ini | 1 +
> doc/guides/nics/features/bnx2x.ini | 1 +
> doc/guides/nics/features/bnx2x_vf.ini | 1 +
> doc/guides/nics/features/cxgbe.ini | 1 +
> doc/guides/nics/features/dpaa2.ini | 1 +
> doc/guides/nics/features/e1000.ini | 1 +
> doc/guides/nics/features/ena.ini | 1 +
> doc/guides/nics/features/fm10k.ini | 1 +
> doc/guides/nics/features/fm10k_vec.ini | 1 +
> doc/guides/nics/features/fm10k_vf.ini | 1 +
> doc/guides/nics/features/fm10k_vf_vec.ini | 1 +
> doc/guides/nics/features/i40e.ini | 1 +
> doc/guides/nics/features/i40e_vec.ini | 1 +
> doc/guides/nics/features/igb.ini | 1 +
> doc/guides/nics/features/ixgbe.ini | 1 +
> doc/guides/nics/features/ixgbe_vec.ini | 1 +
> doc/guides/nics/features/mlx4.ini | 1 +
> doc/guides/nics/features/szedata2.ini | 1 +
> doc/guides/nics/features/tap.ini | 2 +-
> doc/guides/nics/features/virtio.ini | 1 +
> doc/guides/nics/features/virtio_vec.ini | 1 +
> doc/guides/nics/features/vmxnet3.ini | 1 +
> 22 files changed, 22 insertions(+), 1 deletion(-)
[...]
> diff --git a/doc/guides/nics/features/tap.ini b/doc/guides/nics/features/tap.ini
> index 3efae75..d410409 100644
> --- a/doc/guides/nics/features/tap.ini
> +++ b/doc/guides/nics/features/tap.ini
> @@ -4,6 +4,7 @@
> ; Refer to default.ini for the full list of available PMD features.
> ;
> [Features]
> +Speed capabilities = Y
> Link status = Y
> Link status event = Y
> Jumbo frame = Y
> @@ -13,7 +14,6 @@ Basic stats = Y
> Flow API = Y
> MTU update = Y
> Multicast MAC filter = Y
> -Speed capabilities = Y
> Unicast MAC filter = Y
> Packet type parsing = Y
> Flow control = Y
[...]
On 5/15/2017 1:17 PM, Pascal Mazon wrote:
> Hi,
>
> In the case of tap PMD, I would say it's rather partially supported (P).
Hi Pascal,
Thanks, I will update it.
>
> Best regards,
>
> Pascal
>
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Monday, May 15, 2017 12:00 PM
> To: Shepard Siegel <shepard.siegel@atomicrules.com>; Ed Czeck
> <ed.czeck@atomicrules.com>; John Miller <john.miller@atomicrules.com>;
> Mcnamara, John <john.mcnamara@intel.com>; Harish Patil
> <harish.patil@cavium.com>; Rasesh Mody <rasesh.mody@cavium.com>; Rahul
> Lakkireddy <rahul.lakkireddy@chelsio.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>; Shreyansh Jain <shreyansh.jain@nxp.com>; Lu,
> Wenzhuo <wenzhuo.lu@intel.com>; Marcin Wojtas <mw@semihalf.com>; Michal
> Krawczyk <mk@semihalf.com>; Guy Tzalik <gtzalik@amazon.com>; Evgeny
> Schemeilin <evgenys@amazon.com>; Chen, Jing D <jing.d.chen@intel.com>;
> Zhang, Helin <helin.zhang@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Adrien Mazarguil
> <adrien.mazarguil@6wind.com>; Nelio Laranjeiro
> <nelio.laranjeiro@6wind.com>; Matej Vido <vido@cesnet.cz>; Pascal Mazon
> <pascal.mazon@6wind.com>; Yuanhan Liu <yuanhan.liu@linux.intel.com>;
> Maxime Coquelin <maxime.coquelin@redhat.com>; Shrikrishna Khare
> <skhare@vmware.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>
> Subject: [PATCH v2] drivers/net: document missing speed capabilities
> feature
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
This needs to be checked/updated by the PMD maintainers but from a update/documentation point of view:
Acked-by: John McNamara <john.mcnamara@intel.com>
@@ -4,6 +4,7 @@
; Refer to default.ini for the full list of available PMD features.
;
[Features]
+Speed capabilities = Y
Queue start/stop = Y
Jumbo frame = Y
Scattered Rx = Y
@@ -4,6 +4,7 @@
; Refer to default.ini for the full list of available PMD features.
;
[Features]
+Speed capabilities = P
Link status = Y
Link status event = Y
Promiscuous mode = Y
@@ -4,6 +4,7 @@
; Refer to default.ini for the full list of available PMD features.
;
[Features]
+Speed capabilities = P
Link status = Y
Link status event = Y
Promiscuous mode = Y
@@ -4,6 +4,7 @@
; Refer to default.ini for the full list of available PMD features.
;
[Features]
+Speed capabilities = P
Link status = Y
Queue start/stop = Y
MTU update = Y
@@ -4,6 +4,7 @@
; Refer to default.ini for the full list of available PMD features.
;
[Features]
+Speed capabilities = P
Link status = Y
Queue start/stop = Y
MTU update = Y
@@ -4,6 +4,7 @@
; Refer to default.ini for the full list of available PMD features.
;
[Features]
+Speed capabilities = P
Link status = Y
Link status event = Y
Rx interrupt = Y
@@ -4,6 +4,7 @@
; Refer to default.ini for the full list of available PMD features.
;
[Features]
+Speed capabilities = P
Queue start/stop = Y
MTU update = Y
Jumbo frame = Y
@@ -4,6 +4,7 @@
; Refer to default.ini for the full list of available PMD features.
;
[Features]
+Speed capabilities = P
Rx interrupt = Y
Queue start/stop = Y
Jumbo frame = Y
@@ -4,6 +4,7 @@
; Refer to default.ini for the full list of available PMD features.
;
[Features]
+Speed capabilities = P
Rx interrupt = Y
Queue start/stop = Y
Jumbo frame = Y
@@ -4,6 +4,7 @@
; Refer to default.ini for the full list of available PMD features.
;
[Features]
+Speed capabilities = P
Rx interrupt = Y
Queue start/stop = Y
Jumbo frame = Y
@@ -4,6 +4,7 @@
; Refer to default.ini for the full list of available PMD features.
;
[Features]
+Speed capabilities = P
Rx interrupt = Y
Queue start/stop = Y
Jumbo frame = Y
@@ -4,6 +4,7 @@
; Refer to default.ini for the full list of available PMD features.
;
[Features]
+Speed capabilities = Y
Link status = Y
Link status event = Y
Rx interrupt = Y
@@ -4,6 +4,7 @@
; Refer to default.ini for the full list of available PMD features.
;
[Features]
+Speed capabilities = Y
Link status = Y
Link status event = Y
Rx interrupt = Y
@@ -4,6 +4,7 @@
; Refer to default.ini for the full list of available PMD features.
;
[Features]
+Speed capabilities = P
Link status = Y
Link status event = Y
Rx interrupt = Y
@@ -4,6 +4,7 @@
; Refer to default.ini for the full list of available PMD features.
;
[Features]
+Speed capabilities = Y
Link status = Y
Link status event = Y
Rx interrupt = Y
@@ -4,6 +4,7 @@
; Refer to default.ini for the full list of available PMD features.
;
[Features]
+Speed capabilities = Y
Link status = Y
Link status event = Y
Rx interrupt = Y
@@ -4,6 +4,7 @@
; Refer to default.ini for the full list of available PMD features.
;
[Features]
+Speed capabilities = P
Link status = Y
Link status event = Y
Removal event = Y
@@ -4,6 +4,7 @@
; Refer to default.ini for the full list of available PMD features.
;
[Features]
+Speed capabilities = P
Link status = Y
Queue start/stop = Y
Scattered Rx = Y
@@ -4,6 +4,7 @@
; Refer to default.ini for the full list of available PMD features.
;
[Features]
+Speed capabilities = Y
Link status = Y
Link status event = Y
Jumbo frame = Y
@@ -13,7 +14,6 @@ Basic stats = Y
Flow API = Y
MTU update = Y
Multicast MAC filter = Y
-Speed capabilities = Y
Unicast MAC filter = Y
Packet type parsing = Y
Flow control = Y
@@ -4,6 +4,7 @@
; Refer to default.ini for the full list of available PMD features.
;
[Features]
+Speed capabilities = P
Link status = Y
Rx interrupt = Y
Queue start/stop = Y
@@ -4,6 +4,7 @@
; Refer to default.ini for the full list of available PMD features.
;
[Features]
+Speed capabilities = P
Link status = Y
Rx interrupt = Y
Queue start/stop = Y
@@ -4,6 +4,7 @@
; Refer to default.ini for the full list of available PMD features.
;
[Features]
+Speed capabilities = P
Link status = Y
Link status event = Y
Queue start/stop = Y