diff mbox series

ring: remove unnecessary forward declaration

Message ID 20190516072856.27086-1-xiaolong.ye@intel.com (mailing list archive)
State Accepted, archived
Headers
Series ring: remove unnecessary forward declaration |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/Intel-compilation success Compilation OK

Commit Message

Xiaolong Ye May 16, 2019, 7:28 a.m. UTC 
  As memzone.h is introduced by commit 38c9817ee1d8 ("mempool: adjust name
size in related data types"), forward declaration for rte_memzone is no
longer needed.

Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
---
 lib/librte_ring/rte_ring.h | 2 --
 1 file changed, 2 deletions(-)

Comments

Olivier Matz May 16, 2019, 7:58 a.m. UTC | #1 
On Thu, May 16, 2019 at 03:28:56PM +0800, Xiaolong Ye wrote:
> As memzone.h is introduced by commit 38c9817ee1d8 ("mempool: adjust name
> size in related data types"), forward declaration for rte_memzone is no
> longer needed.
> 
> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>

Acked-by: Olivier Matz <olivier.matz@6wind.com>

Thanks
Thomas Monjalon June 4, 2019, 11:10 a.m. UTC | #2 
16/05/2019 09:58, Olivier Matz:
> On Thu, May 16, 2019 at 03:28:56PM +0800, Xiaolong Ye wrote:
> > As memzone.h is introduced by commit 38c9817ee1d8 ("mempool: adjust name
> > size in related data types"), forward declaration for rte_memzone is no
> > longer needed.
> > 
> > Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> 
> Acked-by: Olivier Matz <olivier.matz@6wind.com>

Applied, thanks
diff mbox series

Patch

diff --git a/lib/librte_ring/rte_ring.h b/lib/librte_ring/rte_ring.h
index e265e9479..e5a175cb3 100644
--- a/lib/librte_ring/rte_ring.h
+++ b/lib/librte_ring/rte_ring.h
@@ -61,8 +61,6 @@  enum rte_ring_queue_behavior {
 #define RTE_RING_NAMESIZE (RTE_MEMZONE_NAMESIZE - \
 			   sizeof(RTE_RING_MZ_PREFIX) + 1)
 
-struct rte_memzone; /* forward declaration, so as not to require memzone.h */
-
 /* structure to hold a pair of head/tail values and other metadata */
 struct rte_ring_headtail {
 	volatile uint32_t head;  /**< Prod/consumer head. */