diff mbox series

[1/2] mk: add Marvell ARMADA architecture based on armv8-a

Message ID 1558128867-15941-2-git-send-email-lironh@marvell.com (mailing list archive)
State Superseded, archived
Headers
Series Introduces armada target |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/Intel-compilation success Compilation OK

Commit Message

Liron Himi May 17, 2019, 9:34 p.m. UTC 
  From: Liron Himi <lironh@marvell.com>

This patch introduces armada target to address difference
in number of cores, no numa support

Signed-off-by: Liron Himi <lironh@marvell.com>
Reviewed-by: Alan Winkowski <walan@marvell.com>
Tested-by: Liron Himi <lironh@marvell.com>
---
 config/defconfig_arm64-armada-linux-gcc    | 24 ++++++++++++++++++++++++
 config/defconfig_arm64-armada-linuxapp-gcc | 24 ++++++++++++++++++++++++
 2 files changed, 48 insertions(+)
 create mode 100644 config/defconfig_arm64-armada-linux-gcc
 create mode 100644 config/defconfig_arm64-armada-linuxapp-gcc

Comments

Jerin Jacob Kollanukkaran May 18, 2019, 10:59 a.m. UTC | #1 
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of lironh@marvell.com
> Sent: Saturday, May 18, 2019 3:04 AM
> To: thomas@monjalon.net
> Cc: dev@dpdk.org; Liron Himi <lironh@marvell.com>
> Subject: [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture based
> on armv8-a
> 
> From: Liron Himi <lironh@marvell.com>
> 
> This patch introduces armada target to address difference in number of cores,
> no numa support
> 
> Signed-off-by: Liron Himi <lironh@marvell.com>
> Reviewed-by: Alan Winkowski <walan@marvell.com>
> Tested-by: Liron Himi <lironh@marvell.com>
> ---
>  config/defconfig_arm64-armada-linux-gcc    | 24 ++++++++++++++++++++++++
>  config/defconfig_arm64-armada-linuxapp-gcc | 24 ++++++++++++++++++++++++

Don't create a new file for linuxapp-gcc, instead make sym link like other armv8 config.

>  2 files changed, 48 insertions(+)
>  create mode 100644 config/defconfig_arm64-armada-linux-gcc
>  create mode 100644 config/defconfig_arm64-armada-linuxapp-gcc
> 
> diff --git a/config/defconfig_arm64-armada-linux-gcc
> b/config/defconfig_arm64-armada-linux-gcc
> new file mode 100644
> index 0000000..573b278
> --- /dev/null
> +++ b/config/defconfig_arm64-armada-linux-gcc
> @@ -0,0 +1,24 @@
> +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Marvell

s/2018/2019

> +International Ltd #
> +
> +#include "defconfig_arm64-armv8a-linux-gcc"
> +
> +CONFIG_RTE_LIBRTE_MVEP_COMMON=y
> +CONFIG_RTE_LIBRTE_MVPP2_PMD=y
> +CONFIG_RTE_LIBRTE_MVNETA_PMD=y
> +CONFIG_RTE_LIBRTE_PMD_MVSAM_CRYPTO=y
> +
> +#
> +# Compile Environment Abstraction Layer #
> +CONFIG_RTE_MAX_LCORE=16e 
> +CONFIG_RTE_MAX_NUMA_NODES=1
> +CONFIG_RTE_CACHE_LINE_SIZE=64

Please move this section first, to have symmetry  with other armv8 config file
i.e

# core changes
# PMD changes

With above changes:
Acked-by: Jerin Jacob <jerinj@marvell.com>
Ruifeng Wang May 24, 2019, 7:50 a.m. UTC | #2 
Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of lironh@marvell.com
> Sent: Saturday, May 18, 2019 05:34
> To: thomas@monjalon.net
> Cc: dev@dpdk.org; Liron Himi <lironh@marvell.com>
> Subject: [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture
> based on armv8-a
> 
> From: Liron Himi <lironh@marvell.com>
> 
> This patch introduces armada target to address difference in number of cores,
> no numa support
> 
> Signed-off-by: Liron Himi <lironh@marvell.com>
> Reviewed-by: Alan Winkowski <walan@marvell.com>
> Tested-by: Liron Himi <lironh@marvell.com>
> ---
>  config/defconfig_arm64-armada-linux-gcc    | 24
> ++++++++++++++++++++++++
>  config/defconfig_arm64-armada-linuxapp-gcc | 24
> ++++++++++++++++++++++++
>  2 files changed, 48 insertions(+)
>  create mode 100644 config/defconfig_arm64-armada-linux-gcc
>  create mode 100644 config/defconfig_arm64-armada-linuxapp-gcc
> 
> diff --git a/config/defconfig_arm64-armada-linux-gcc
> b/config/defconfig_arm64-armada-linux-gcc
> new file mode 100644
> index 0000000..573b278
> --- /dev/null
> +++ b/config/defconfig_arm64-armada-linux-gcc
> @@ -0,0 +1,24 @@
> +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Marvell
> +International Ltd #
> +
> +#include "defconfig_arm64-armv8a-linux-gcc"
> +
> +CONFIG_RTE_LIBRTE_MVEP_COMMON=y
> +CONFIG_RTE_LIBRTE_MVPP2_PMD=y
> +CONFIG_RTE_LIBRTE_MVNETA_PMD=y
> +CONFIG_RTE_LIBRTE_PMD_MVSAM_CRYPTO=y
> +
> +#
> +# Compile Environment Abstraction Layer #
> +CONFIG_RTE_MAX_LCORE=16
> +CONFIG_RTE_MAX_NUMA_NODES=1
> +CONFIG_RTE_CACHE_LINE_SIZE=64
> +
> +# Disable NXP as it is conflict with MUSDK
> CONFIG_RTE_LIBRTE_DPAA_BUS=n
> +
> +# Doesn't support NUMA
> +CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=n
> +CONFIG_RTE_LIBRTE_VHOST_NUMA=n
> diff --git a/config/defconfig_arm64-armada-linuxapp-gcc
> b/config/defconfig_arm64-armada-linuxapp-gcc
> new file mode 100644
> index 0000000..573b278
> --- /dev/null
> +++ b/config/defconfig_arm64-armada-linuxapp-gcc
> @@ -0,0 +1,24 @@
> +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Marvell
> +International Ltd #
> +
> +#include "defconfig_arm64-armv8a-linux-gcc"
> +

Maybe CONFIG_RTE_MACHINE and CONFIG_RTE_ARCH_ARM_TUNE can be added as well.
I referred to defconfig_arm64-dpaa2-linuxapp-gcc.

> +CONFIG_RTE_LIBRTE_MVEP_COMMON=y
> +CONFIG_RTE_LIBRTE_MVPP2_PMD=y
> +CONFIG_RTE_LIBRTE_MVNETA_PMD=y
> +CONFIG_RTE_LIBRTE_PMD_MVSAM_CRYPTO=y
> +
> +#
> +# Compile Environment Abstraction Layer #
> +CONFIG_RTE_MAX_LCORE=16
> +CONFIG_RTE_MAX_NUMA_NODES=1
> +CONFIG_RTE_CACHE_LINE_SIZE=64
> +
> +# Disable NXP as it is conflict with MUSDK
> CONFIG_RTE_LIBRTE_DPAA_BUS=n
> +
> +# Doesn't support NUMA
> +CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=n
> +CONFIG_RTE_LIBRTE_VHOST_NUMA=n
> --
> 2.7.4
Liron Himi May 26, 2019, 5:33 a.m. UTC | #3 
Hi,

Regards,
Liron

-----Original Message-----
From: Ruifeng Wang (Arm Technology China) <Ruifeng.Wang@arm.com> 
Sent: Friday, May 24, 2019 10:51
To: Liron Himi <lironh@marvell.com>; thomas@monjalon.net
Cc: dev@dpdk.org; nd <nd@arm.com>
Subject: [EXT] RE: [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture based on armv8-a

External Email

----------------------------------------------------------------------
Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of lironh@marvell.com
> Sent: Saturday, May 18, 2019 05:34
> To: thomas@monjalon.net
> Cc: dev@dpdk.org; Liron Himi <lironh@marvell.com>
> Subject: [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture 
> based on armv8-a
> 
> From: Liron Himi <lironh@marvell.com>
> 
> This patch introduces armada target to address difference in number of 
> cores, no numa support
> 
> Signed-off-by: Liron Himi <lironh@marvell.com>
> Reviewed-by: Alan Winkowski <walan@marvell.com>
> Tested-by: Liron Himi <lironh@marvell.com>
> ---
>  config/defconfig_arm64-armada-linux-gcc    | 24
> ++++++++++++++++++++++++
>  config/defconfig_arm64-armada-linuxapp-gcc | 24
> ++++++++++++++++++++++++
>  2 files changed, 48 insertions(+)
>  create mode 100644 config/defconfig_arm64-armada-linux-gcc
>  create mode 100644 config/defconfig_arm64-armada-linuxapp-gcc
> 
> diff --git a/config/defconfig_arm64-armada-linux-gcc
> b/config/defconfig_arm64-armada-linux-gcc
> new file mode 100644
> index 0000000..573b278
> --- /dev/null
> +++ b/config/defconfig_arm64-armada-linux-gcc
> @@ -0,0 +1,24 @@
> +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Marvell 
> +International Ltd #
> +
> +#include "defconfig_arm64-armv8a-linux-gcc"
> +
> +CONFIG_RTE_LIBRTE_MVEP_COMMON=y
> +CONFIG_RTE_LIBRTE_MVPP2_PMD=y
> +CONFIG_RTE_LIBRTE_MVNETA_PMD=y
> +CONFIG_RTE_LIBRTE_PMD_MVSAM_CRYPTO=y
> +
> +#
> +# Compile Environment Abstraction Layer #
> +CONFIG_RTE_MAX_LCORE=16
> +CONFIG_RTE_MAX_NUMA_NODES=1
> +CONFIG_RTE_CACHE_LINE_SIZE=64
> +
> +# Disable NXP as it is conflict with MUSDK
> CONFIG_RTE_LIBRTE_DPAA_BUS=n
> +
> +# Doesn't support NUMA
> +CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=n
> +CONFIG_RTE_LIBRTE_VHOST_NUMA=n
> diff --git a/config/defconfig_arm64-armada-linuxapp-gcc
> b/config/defconfig_arm64-armada-linuxapp-gcc
> new file mode 100644
> index 0000000..573b278
> --- /dev/null
> +++ b/config/defconfig_arm64-armada-linuxapp-gcc
> @@ -0,0 +1,24 @@
> +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Marvell 
> +International Ltd #
> +
> +#include "defconfig_arm64-armv8a-linux-gcc"
> +

Maybe CONFIG_RTE_MACHINE and CONFIG_RTE_ARCH_ARM_TUNE can be added as well.
[L.H.] currently we are not using special machine flags, just the defaults ones.
As for the TUNE, this config file support two platforms which have different arm cores, in this  moment I don't want to split it to
two config files just for this parameter. 
I referred to defconfig_arm64-dpaa2-linuxapp-gcc.

> +CONFIG_RTE_LIBRTE_MVEP_COMMON=y
> +CONFIG_RTE_LIBRTE_MVPP2_PMD=y
> +CONFIG_RTE_LIBRTE_MVNETA_PMD=y
> +CONFIG_RTE_LIBRTE_PMD_MVSAM_CRYPTO=y
> +
> +#
> +# Compile Environment Abstraction Layer #
> +CONFIG_RTE_MAX_LCORE=16
> +CONFIG_RTE_MAX_NUMA_NODES=1
> +CONFIG_RTE_CACHE_LINE_SIZE=64
> +
> +# Disable NXP as it is conflict with MUSDK
> CONFIG_RTE_LIBRTE_DPAA_BUS=n
> +
> +# Doesn't support NUMA
> +CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=n
> +CONFIG_RTE_LIBRTE_VHOST_NUMA=n
> --
> 2.7.4
diff mbox series

Patch

diff --git a/config/defconfig_arm64-armada-linux-gcc b/config/defconfig_arm64-armada-linux-gcc
new file mode 100644
index 0000000..573b278
--- /dev/null
+++ b/config/defconfig_arm64-armada-linux-gcc
@@ -0,0 +1,24 @@ 
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Marvell International Ltd
+#
+
+#include "defconfig_arm64-armv8a-linux-gcc"
+
+CONFIG_RTE_LIBRTE_MVEP_COMMON=y
+CONFIG_RTE_LIBRTE_MVPP2_PMD=y
+CONFIG_RTE_LIBRTE_MVNETA_PMD=y
+CONFIG_RTE_LIBRTE_PMD_MVSAM_CRYPTO=y
+
+#
+# Compile Environment Abstraction Layer
+#
+CONFIG_RTE_MAX_LCORE=16
+CONFIG_RTE_MAX_NUMA_NODES=1
+CONFIG_RTE_CACHE_LINE_SIZE=64
+
+# Disable NXP as it is conflict with MUSDK
+CONFIG_RTE_LIBRTE_DPAA_BUS=n
+
+# Doesn't support NUMA
+CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=n
+CONFIG_RTE_LIBRTE_VHOST_NUMA=n
diff --git a/config/defconfig_arm64-armada-linuxapp-gcc b/config/defconfig_arm64-armada-linuxapp-gcc
new file mode 100644
index 0000000..573b278
--- /dev/null
+++ b/config/defconfig_arm64-armada-linuxapp-gcc
@@ -0,0 +1,24 @@ 
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Marvell International Ltd
+#
+
+#include "defconfig_arm64-armv8a-linux-gcc"
+
+CONFIG_RTE_LIBRTE_MVEP_COMMON=y
+CONFIG_RTE_LIBRTE_MVPP2_PMD=y
+CONFIG_RTE_LIBRTE_MVNETA_PMD=y
+CONFIG_RTE_LIBRTE_PMD_MVSAM_CRYPTO=y
+
+#
+# Compile Environment Abstraction Layer
+#
+CONFIG_RTE_MAX_LCORE=16
+CONFIG_RTE_MAX_NUMA_NODES=1
+CONFIG_RTE_CACHE_LINE_SIZE=64
+
+# Disable NXP as it is conflict with MUSDK
+CONFIG_RTE_LIBRTE_DPAA_BUS=n
+
+# Doesn't support NUMA
+CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=n
+CONFIG_RTE_LIBRTE_VHOST_NUMA=n