[1/6] net/virtio: remove remaining simple Tx related stuff

Message ID 20190813020730.10038-2-tiwei.bie@intel.com
State New
Delegated to: Maxime Coquelin
Headers show
  • Some updates for virtio guide
Related show


Context Check Description
ci/intel-Performance-Testing success Performance Testing PASS
ci/iol-Compile-Testing success Compile Testing PASS
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Tiwei Bie Aug. 13, 2019, 2:07 a.m.
The simple Tx path in virtio has been removed in below commit.
This patch removes an undefined function declaration of simple
Tx and all related descriptions in the doc.

Fixes: 57f818963d80 ("net/virtio: remove simple Tx path")
Cc: stable@dpdk.org

Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
 doc/guides/nics/virtio.rst         | 15 ++-------------
 drivers/net/virtio/virtio_ethdev.h |  3 ---
 2 files changed, 2 insertions(+), 16 deletions(-)


diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst
index 2ae875cb4..da9cd6ba6 100644
--- a/doc/guides/nics/virtio.rst
+++ b/doc/guides/nics/virtio.rst
@@ -201,7 +201,7 @@  The packet transmission flow is:
 Virtio PMD Rx/Tx Callbacks
-Virtio driver has 4 Rx callbacks and 3 Tx callbacks.
+Virtio driver has 4 Rx callbacks and 2 Tx callbacks.
 Rx callbacks:
@@ -223,9 +223,6 @@  Tx callbacks:
 #. ``virtio_xmit_pkts``:
    Regular version.
-#. ``virtio_xmit_pkts_simple``:
-   Vector version fixes the available ring indexes to optimize performance.
 #. ``virtio_xmit_pkts_inorder``:
    In-order version.
@@ -239,25 +236,17 @@  By default, the non-vector callbacks are used:
 Vector callbacks will be used when:
-*   ``txmode.offloads`` is set to ``0x0``, which implies:
-    *   Single segment is specified.
-    *   No offload support is needed.
 *   Mergeable Rx buffers is disabled.
 The corresponding callbacks are:
 *   For Rx: ``virtio_recv_pkts_vec``.
-*   For Tx: ``virtio_xmit_pkts_simple``.
 Example of using the vector version of the virtio poll mode driver in
-   testpmd -l 0-2 -n 4 -- -i --tx-offloads=0x0 --rxq=1 --txq=1 --nb-cores=1
+   testpmd -l 0-2 -n 4 -- -i --rxq=1 --txq=1 --nb-cores=1
 In-order callbacks only work on simulated virtio user vdev.
diff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethdev.h
index 20d331795..a10111758 100644
--- a/drivers/net/virtio/virtio_ethdev.h
+++ b/drivers/net/virtio/virtio_ethdev.h
@@ -103,9 +103,6 @@  uint16_t virtio_xmit_pkts_inorder(void *tx_queue, struct rte_mbuf **tx_pkts,
 uint16_t virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,
 		uint16_t nb_pkts);
-uint16_t virtio_xmit_pkts_simple(void *tx_queue, struct rte_mbuf **tx_pkts,
-		uint16_t nb_pkts);
 int eth_virtio_dev_init(struct rte_eth_dev *eth_dev);
 void virtio_interrupt_handler(void *param);