mbox series

[RESEND,v2,00/11] codeql fixes for various subsystems

Message ID 20221122153053.1172434-1-okaya@kernel.org (mailing list archive)
Headers
Series codeql fixes for various subsystems |

Message

Sinan Kaya Nov. 22, 2022, 3:30 p.m. UTC 
  From: Sinan Kaya <okaya@kernel.org>

Following up the codeql reported problems first submitted
by Stephen Hemminger here:

https://lore.kernel.org/all/20220527161210.77212d0b@hermes.local/t/

Posting a series of fixes about potential null pointer accesses.

Changes from v1:
- Remove braces around single line statements
- use NULL comparisons

Sinan Kaya (11):
  ethdev: check return result of rte_eth_dev_info_get
  net/tap: check if name is null
  memzone: check result of rte_fbarray_get
  memzone: check result of malloc_elem_from_data
  malloc: malloc_elem_join_adjacent_free can return null
  malloc: check result of rte_mem_virt2memseg_list
  malloc: check result of rte_fbarray_get
  malloc: check result of rte_mem_virt2memseg
  malloc: check result of malloc_elem_free
  malloc: check result of elem_start_pt
  bus/vdev: check result of rte_vdev_device_name

 drivers/net/tap/rte_eth_tap.c        |  3 +++
 lib/eal/common/eal_common_memalloc.c |  5 ++++-
 lib/eal/common/eal_common_memzone.c  | 10 +++++++++-
 lib/eal/common/malloc_elem.c         | 14 +++++++++++---
 lib/eal/common/malloc_heap.c         |  9 ++++++++-
 lib/ethdev/ethdev_vdev.h             |  2 ++
 lib/ethdev/rte_class_eth.c           |  4 +++-
 7 files changed, 40 insertions(+), 7 deletions(-)

Comments

Sinan Kaya Dec. 13, 2022, 4:43 p.m. UTC | #1 
On Tue, 2022-11-22 at 10:30 -0500, okaya@kernel.org wrote:
> From: Sinan Kaya <okaya@kernel.org>
> Following up the codeql reported problems first submittedby Stephen
> Hemminger here:
> https://lore.kernel.org/all/20220527161210.77212d0b@hermes.local/t/
> 
> Posting a series of fixes about potential null pointer accesses.
> Changes from v1:- Remove braces around single line statements- use
> NULL comparisons
> Sinan Kaya (11):  ethdev: check return result of
> rte_eth_dev_info_get  net/tap: check if name is null  memzone: check
> result of rte_fbarray_get  memzone: check result of
> malloc_elem_from_data  malloc: malloc_elem_join_adjacent_free can
> return null  malloc: check result of
> rte_mem_virt2memseg_list  malloc: check result of
> rte_fbarray_get  malloc: check result of rte_mem_virt2memseg  malloc:
> check result of malloc_elem_free  malloc: check result of
> elem_start_pt  bus/vdev: check result of rte_vdev_device_name
>  drivers/net/tap/rte_eth_tap.c        |  3 +++
> lib/eal/common/eal_common_memalloc.c |  5 ++++-
> lib/eal/common/eal_common_memzone.c  | 10 +++++++++-
> lib/eal/common/malloc_elem.c         | 14 +++++++++++---
> lib/eal/common/malloc_heap.c         |  9 ++++++++-
> lib/ethdev/ethdev_vdev.h             |  2 ++
> lib/ethdev/rte_class_eth.c           |  4 +++- 7 files changed, 40
> insertions(+), 7 deletions(-)
> 

Checking to see if I need to cover any feedback.
Dmitry Kozlyuk Dec. 13, 2022, 4:59 p.m. UTC | #2 
2022-12-13 11:43 (UTC-0500), Sinan Kaya:
> Checking to see if I need to cover any feedback.

There was some feedback to pre-resend v2 that is not visible on patchwork:

http://inbox.dpdk.org/dev/CAJFAV8yEe9awya3OVLuqavfW0MzonSQJQ-K+2q4WampmyrjEGg@mail.gmail.com/
Sinan Kaya Dec. 13, 2022, 5:02 p.m. UTC | #3 
On Tue, 2022-12-13 at 19:59 +0300, Dmitry Kozlyuk wrote:
> 2022-12-13 11:43 (UTC-0500), Sinan Kaya:
> > Checking to see if I need to cover any feedback.
> 
> There was some feedback to pre-resend v2 that is not visible on
> patchwork:
> 
> http://inbox.dpdk.org/dev/CAJFAV8yEe9awya3OVLuqavfW0MzonSQJQ-K+2q4WampmyrjEGg@mail.gmail.com/
> 
> 

Yes, I sent it again with RESEND tag this time on this series.
Just checking to see if it went through this time.
I do see the RESEND series on patchwork.
Sinan Kaya Dec. 16, 2022, 3:26 p.m. UTC | #4 
On Tue, 2022-12-13 at 12:02 -0500, Sinan Kaya wrote:
> On Tue, 2022-12-13 at 19:59 +0300, Dmitry Kozlyuk wrote:
> > 2022-12-13 11:43 (UTC-0500), Sinan Kaya:
> > > Checking to see if I need to cover any feedback.
> > 
> > There was some feedback to pre-resend v2 that is not visible on
> > patchwork:
> > 
> > http://inbox.dpdk.org/dev/CAJFAV8yEe9awya3OVLuqavfW0MzonSQJQ-K+2q4WampmyrjEGg@mail.gmail.com/
> > 
> > 
> > 
> 
> Yes, I sent it again with RESEND tag this time on this series.
> Just checking to see if it went through this time.
> I do see the RESEND series on patchwork.
> 
> 

I was planning to send the fixes in batches hoping this one to
merge first. I guess I'll post the remaning bugfixes using a
different series.