mbox series

[00/13] Sync the kernel driver logic

Message ID 20230410110015.2973660-1-chaoyong.he@corigine.com (mailing list archive)
Headers
Series Sync the kernel driver logic |

Message

Chaoyong He April 10, 2023, 11 a.m. UTC 
  The DPDK NFP PMD share the same underlying data structure and API with
the NFP kernel driver, because they use the same firmware.

The DPDK NFP PMD only has a very initial version and not changed for a
long time, but the NFP kernel driver keeps evolve at the same time, so
the differece between them are keeping expand.

This patch series try to sync the needed logics to narrow the gap.

Chaoyong He (13):
  net/nfp: define correct size for configuration BAR
  net/nfp: move shared target logic to own source file
  net/nfp: remove the redundant macro about CPP target
  net/nfp: drop usage of return error helpers
  net/nfp: use generic macros for array size and to set bits
  net/nfp: remove dead code related to CPP
  net/nfp: remove duplicated nffw defines
  net/nfp: move NFD3 logic to own source file
  net/nfp: adjust the coding style for NFD3
  net/nfp: rename macro name of NFD3 Tx descriptor
  net/nfp: move NFDk logic to own source file
  net/nfp: adjust the coding style for NFDk
  net/nfp: modify the logic of some NFDk function

 drivers/net/nfp/flower/nfp_flower.c           |   9 +-
 drivers/net/nfp/flower/nfp_flower_ctrl.c      |   3 +-
 .../net/nfp/flower/nfp_flower_representor.c   |   1 +
 drivers/net/nfp/meson.build                   |   3 +
 drivers/net/nfp/nfd3/nfp_nfd3.h               | 161 +++
 drivers/net/nfp/nfd3/nfp_nfd3_dp.c            | 343 ++++++
 drivers/net/nfp/nfdk/nfp_nfdk.h               | 239 +++++
 drivers/net/nfp/nfdk/nfp_nfdk_dp.c            | 437 ++++++++
 drivers/net/nfp/nfp_common.c                  |   6 +-
 drivers/net/nfp/nfp_cpp_bridge.c              |   5 +-
 drivers/net/nfp/nfp_ctrl.h                    |   7 +-
 drivers/net/nfp/nfp_ethdev.c                  |   5 +-
 drivers/net/nfp/nfp_ethdev_vf.c               |   2 +
 drivers/net/nfp/nfp_rxtx.c                    | 844 +--------------
 drivers/net/nfp/nfp_rxtx.h                    | 208 +---
 .../net/nfp/nfpcore/nfp-common/nfp_cppat.h    | 725 -------------
 .../net/nfp/nfpcore/nfp-common/nfp_platform.h |  35 -
 .../net/nfp/nfpcore/nfp-common/nfp_resid.h    | 592 -----------
 drivers/net/nfp/nfpcore/nfp6000/nfp6000.h     |  20 +
 drivers/net/nfp/nfpcore/nfp_cpp.h             | 155 ++-
 drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c    |   3 +-
 drivers/net/nfp/nfpcore/nfp_cppcore.c         |  47 +-
 drivers/net/nfp/nfpcore/nfp_hwinfo.h          |   2 +-
 drivers/net/nfp/nfpcore/nfp_mutex.c           |  39 +-
 drivers/net/nfp/nfpcore/nfp_nffw.c            |   8 +-
 drivers/net/nfp/nfpcore/nfp_nffw.h            |  10 -
 drivers/net/nfp/nfpcore/nfp_nsp.c             |   2 +-
 drivers/net/nfp/nfpcore/nfp_nsp.h             |  12 +-
 drivers/net/nfp/nfpcore/nfp_nsp_cmds.c        |   2 +-
 drivers/net/nfp/nfpcore/nfp_nsp_eth.c         |  34 +-
 drivers/net/nfp/nfpcore/nfp_resource.c        |   2 +-
 drivers/net/nfp/nfpcore/nfp_target.c          | 994 ++++++++++++++++++
 drivers/net/nfp/nfpcore/nfp_target.h          |   3 -
 33 files changed, 2417 insertions(+), 2541 deletions(-)
 create mode 100644 drivers/net/nfp/nfd3/nfp_nfd3.h
 create mode 100644 drivers/net/nfp/nfd3/nfp_nfd3_dp.c
 create mode 100644 drivers/net/nfp/nfdk/nfp_nfdk.h
 create mode 100644 drivers/net/nfp/nfdk/nfp_nfdk_dp.c
 delete mode 100644 drivers/net/nfp/nfpcore/nfp-common/nfp_cppat.h
 delete mode 100644 drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h
 delete mode 100644 drivers/net/nfp/nfpcore/nfp-common/nfp_resid.h
 create mode 100644 drivers/net/nfp/nfpcore/nfp_target.c

Comments

Niklas Söderlund May 11, 2023, 2:47 p.m. UTC | #1 
Hi all,

A gentle ping on this series.

It touches a lot of files when syncing the PMD with the kernel driver, 
and to avoid conflicts with future work, it would be kind if this could 
be looked at early in the release cycle.

On 2023-04-10 19:00:02 +0800, Chaoyong He wrote:
> The DPDK NFP PMD share the same underlying data structure and API with
> the NFP kernel driver, because they use the same firmware.
> 
> The DPDK NFP PMD only has a very initial version and not changed for a
> long time, but the NFP kernel driver keeps evolve at the same time, so
> the differece between them are keeping expand.
> 
> This patch series try to sync the needed logics to narrow the gap.
> 
> Chaoyong He (13):
>   net/nfp: define correct size for configuration BAR
>   net/nfp: move shared target logic to own source file
>   net/nfp: remove the redundant macro about CPP target
>   net/nfp: drop usage of return error helpers
>   net/nfp: use generic macros for array size and to set bits
>   net/nfp: remove dead code related to CPP
>   net/nfp: remove duplicated nffw defines
>   net/nfp: move NFD3 logic to own source file
>   net/nfp: adjust the coding style for NFD3
>   net/nfp: rename macro name of NFD3 Tx descriptor
>   net/nfp: move NFDk logic to own source file
>   net/nfp: adjust the coding style for NFDk
>   net/nfp: modify the logic of some NFDk function
> 
>  drivers/net/nfp/flower/nfp_flower.c           |   9 +-
>  drivers/net/nfp/flower/nfp_flower_ctrl.c      |   3 +-
>  .../net/nfp/flower/nfp_flower_representor.c   |   1 +
>  drivers/net/nfp/meson.build                   |   3 +
>  drivers/net/nfp/nfd3/nfp_nfd3.h               | 161 +++
>  drivers/net/nfp/nfd3/nfp_nfd3_dp.c            | 343 ++++++
>  drivers/net/nfp/nfdk/nfp_nfdk.h               | 239 +++++
>  drivers/net/nfp/nfdk/nfp_nfdk_dp.c            | 437 ++++++++
>  drivers/net/nfp/nfp_common.c                  |   6 +-
>  drivers/net/nfp/nfp_cpp_bridge.c              |   5 +-
>  drivers/net/nfp/nfp_ctrl.h                    |   7 +-
>  drivers/net/nfp/nfp_ethdev.c                  |   5 +-
>  drivers/net/nfp/nfp_ethdev_vf.c               |   2 +
>  drivers/net/nfp/nfp_rxtx.c                    | 844 +--------------
>  drivers/net/nfp/nfp_rxtx.h                    | 208 +---
>  .../net/nfp/nfpcore/nfp-common/nfp_cppat.h    | 725 -------------
>  .../net/nfp/nfpcore/nfp-common/nfp_platform.h |  35 -
>  .../net/nfp/nfpcore/nfp-common/nfp_resid.h    | 592 -----------
>  drivers/net/nfp/nfpcore/nfp6000/nfp6000.h     |  20 +
>  drivers/net/nfp/nfpcore/nfp_cpp.h             | 155 ++-
>  drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c    |   3 +-
>  drivers/net/nfp/nfpcore/nfp_cppcore.c         |  47 +-
>  drivers/net/nfp/nfpcore/nfp_hwinfo.h          |   2 +-
>  drivers/net/nfp/nfpcore/nfp_mutex.c           |  39 +-
>  drivers/net/nfp/nfpcore/nfp_nffw.c            |   8 +-
>  drivers/net/nfp/nfpcore/nfp_nffw.h            |  10 -
>  drivers/net/nfp/nfpcore/nfp_nsp.c             |   2 +-
>  drivers/net/nfp/nfpcore/nfp_nsp.h             |  12 +-
>  drivers/net/nfp/nfpcore/nfp_nsp_cmds.c        |   2 +-
>  drivers/net/nfp/nfpcore/nfp_nsp_eth.c         |  34 +-
>  drivers/net/nfp/nfpcore/nfp_resource.c        |   2 +-
>  drivers/net/nfp/nfpcore/nfp_target.c          | 994 ++++++++++++++++++
>  drivers/net/nfp/nfpcore/nfp_target.h          |   3 -
>  33 files changed, 2417 insertions(+), 2541 deletions(-)
>  create mode 100644 drivers/net/nfp/nfd3/nfp_nfd3.h
>  create mode 100644 drivers/net/nfp/nfd3/nfp_nfd3_dp.c
>  create mode 100644 drivers/net/nfp/nfdk/nfp_nfdk.h
>  create mode 100644 drivers/net/nfp/nfdk/nfp_nfdk_dp.c
>  delete mode 100644 drivers/net/nfp/nfpcore/nfp-common/nfp_cppat.h
>  delete mode 100644 drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h
>  delete mode 100644 drivers/net/nfp/nfpcore/nfp-common/nfp_resid.h
>  create mode 100644 drivers/net/nfp/nfpcore/nfp_target.c
> 
> -- 
> 2.39.1
>
Ferruh Yigit May 12, 2023, 2:37 p.m. UTC | #2 
On 4/10/2023 12:00 PM, Chaoyong He wrote:
> The DPDK NFP PMD share the same underlying data structure and API with
> the NFP kernel driver, because they use the same firmware.
> 
> The DPDK NFP PMD only has a very initial version and not changed for a
> long time, but the NFP kernel driver keeps evolve at the same time, so
> the differece between them are keeping expand.
> 
> This patch series try to sync the needed logics to narrow the gap.
> 
> Chaoyong He (13):
>   net/nfp: define correct size for configuration BAR
>   net/nfp: move shared target logic to own source file
>   net/nfp: remove the redundant macro about CPP target
>   net/nfp: drop usage of return error helpers
>   net/nfp: use generic macros for array size and to set bits
>   net/nfp: remove dead code related to CPP
>   net/nfp: remove duplicated nffw defines
>   net/nfp: move NFD3 logic to own source file
>   net/nfp: adjust the coding style for NFD3
>   net/nfp: rename macro name of NFD3 Tx descriptor
>   net/nfp: move NFDk logic to own source file
>   net/nfp: adjust the coding style for NFDk
>   net/nfp: modify the logic of some NFDk function


Series applied to dpdk-next-net/main, thanks.