| Message ID | 20230614142651.1456116-1-thomas@monjalon.net (mailing list archive) |
|---|---|
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8469E42CB3; Wed, 14 Jun 2023 16:30:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7AB3A410EE; Wed, 14 Jun 2023 16:30:56 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 50FAC40DDB for <dev@dpdk.org>; Wed, 14 Jun 2023 16:30:55 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 70EA232007F1; Wed, 14 Jun 2023 10:30:52 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 14 Jun 2023 10:30:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm2; t=1686753051; x=1686839451; bh=U4DE8VDFml yEYXR/suZhf7V5sGWKrbaOcZFHC4Mt+fM=; b=UkU0MVdlNRrJz+mk6/HEMwi31/ aR7ECBCHFUFlIrLNsZERYC1OToZJRoVqMYDpy4DSfDCf5lxeKpzMNL8rfGOE4r2c WYXzdV6S+ImnEIt7TlFfvicJXSr6yUsdpbA3bNQRtI+nW4TpHtTmwagCSYcZzmkP 89j3Zgu/minNhtzpoEYxZHbbDDTNFVGd7zHjFgq6lfIW6J7ioLUuoEh5iD0e38++ leMX2pazcWQCOk8eeT76uTZCM/k494Iupcl1Po1u2ZXzGyMTSZuaVXVgD8P5FeDR 13msmVh+elyeqv5mj7Pf02bc62Y4FbYrw8n8cH9KgTeXNZscJ6dqbjXOU70w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1686753051; x=1686839451; bh=U4DE8VDFmlyEYXR/suZhf7V5sGWK rbaOcZFHC4Mt+fM=; b=OBz8nqe/lXb0LVVItwjY+ynZI8rZFIxFMHXuCTHaUf8Q tLrNxgz9jwk3caeQ9T4s22zZisMgS6BX8KlzuZU89k7nU5hNlSVEDuFjGSnGSswR wGL6hcyo6UphQMY8O3LNzYFlo9k6eEreWesP2Z04ifvocMmFKT238xhUNVwDuScv Mj4MMtbiG89jiLgy2gwYVkJGiD4FDm8R6dmBqmDRnSZlZ6h9WaOBCyr9pKfGuZ6V lABwLBg0KAKZOXVUcRa1rPwysx4NzK3o0KyXAODrRlGq9a04PEOQ8gzwzH9IGaYo vYqh2Rd6P7lIY1Ke5kGXnbNlbWhJyK/DEJGtYwTt5w== X-ME-Sender: <xms:G8-JZJkaC6dd5DYp09k9R1k_fIp8Xk__IR6_GnzW9X2O0qwbveCsig> <xme:G8-JZE3loZTOtVL4EPFc7bM0T2g_NwkQorTwMP66_-mUEPIRkITbv1Oc7qji9b1F3 T02DWKTQZDSG3AbAw> X-ME-Received: <xmr:G8-JZPonTt0PVeKGkOdMljyWj28Pb9TenPNTq4owanHJ1ykMPJj5v3uIJMJiM-yHJor4btm_rsOYQsgTOcVRXQ70NnqvHa4> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedvtddgjeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgggfestdekredtre dttdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhho nhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpedvledvudehvdduudevuedvve ehgeduleegiefgjeehudehtddtgeduffejiefhgfenucevlhhushhtvghrufhiiigvpedt necurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvg ht X-ME-Proxy: <xmx:G8-JZJkNjV1eT0v2vy43Udf8tzPr_lPsVM4gH6scO08fRtWfmfli3g> <xmx:G8-JZH0ElgIUFz4M3L_LEB2_gl6HeeNVpahPoNRm73fvjyaxfcmGCA> <xmx:G8-JZIvTCuyLgLBIoxkBLqz1APMGZHb50eIYi3u_fmpFo_MpglBONQ> <xmx:G8-JZMiULh0sNX0xb7o6v9jDlqoGZPPXiYJlTQGGnaptpK4FUHsOpA> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for <dev@dpdk.org>; Wed, 14 Jun 2023 10:30:51 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: dev@dpdk.org Subject: [PATCH 0/5] cleanup in library header files Date: Wed, 14 Jun 2023 16:26:46 +0200 Message-Id: <20230614142651.1456116-1-thomas@monjalon.net> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
| Series | cleanup in library header files | |
Message
Thomas Monjalon
June 14, 2023, 2:26 p.m. UTC
While pulling some trees for DPDK 23.07-rc1, I've seen that some wrong coding style for comments were copied over and over. In order to avoid copying wrong comment style, the three first patches are fixing a lot of comments. As it is not critical, they are not marked for backport. While looking the header files, I've fixed some misuses of "extern". Thomas Monjalon (5): lib: remove blank line ending comment blocks lib: remove extra asterisks ending comment blocks lib: align comment blocks lib: restrict use of keyword extern cryptodev: fix comments of modular operation parameters lib/acl/acl.h | 2 +- lib/acl/acl_gen.c | 10 +- lib/acl/acl_vect.h | 2 +- lib/bbdev/rte_bbdev.h | 2 - lib/bbdev/rte_bbdev_op.h | 1 - lib/bbdev/rte_bbdev_pmd.h | 1 - lib/bpf/bpf_impl.h | 8 +- lib/cfgfile/rte_cfgfile.h | 303 ++++++++++++------------ lib/cmdline/cmdline_parse.h | 1 - lib/cmdline/cmdline_parse_string.h | 14 +- lib/compressdev/rte_comp.h | 1 - lib/compressdev/rte_compressdev.h | 1 - lib/cryptodev/cryptodev_pmd.h | 3 +- lib/cryptodev/rte_crypto.h | 3 +- lib/cryptodev/rte_crypto_asym.h | 16 +- lib/cryptodev/rte_crypto_sym.h | 2 +- lib/cryptodev/rte_cryptodev.h | 42 ++-- lib/cryptodev/rte_cryptodev_core.h | 1 - lib/eal/arm/include/rte_cycles_32.h | 13 +- lib/eal/arm/include/rte_cycles_64.h | 1 - lib/eal/common/eal_common_proc.c | 1 - lib/eal/include/generic/rte_cycles.h | 2 +- lib/eal/include/generic/rte_pause.h | 1 - lib/eal/include/generic/rte_spinlock.h | 1 - lib/eal/include/rte_bitmap.h | 3 +- lib/eal/include/rte_branch_prediction.h | 2 - lib/eal/include/rte_eal.h | 2 - lib/eal/include/rte_hexdump.h | 53 ++--- lib/eal/include/rte_interrupts.h | 1 - lib/eal/include/rte_keepalive.h | 3 +- lib/eal/include/rte_lcore.h | 1 - lib/eal/include/rte_tailq.h | 1 - lib/eal/include/rte_thread.h | 1 - lib/eal/include/rte_ticketlock.h | 1 - lib/eal/include/rte_trace_point.h | 1 - lib/eal/linux/eal_vfio.h | 4 +- lib/eal/ppc/include/rte_byteorder.h | 2 +- lib/eal/windows/include/sys/queue.h | 1 - lib/eal/x86/include/rte_byteorder_32.h | 2 +- lib/eal/x86/include/rte_byteorder_64.h | 2 +- lib/efd/rte_efd.c | 1 - lib/ethdev/ethdev_driver.h | 1 - lib/ethdev/rte_ethdev.c | 1 - lib/ethdev/rte_ethdev.h | 66 +++--- lib/ethdev/rte_ethdev_core.h | 1 - lib/ethdev/rte_flow.h | 23 +- lib/ethdev/rte_mtr.h | 2 - lib/ethdev/rte_tm.h | 4 +- lib/ethdev/sff_8636.h | 2 - lib/ethdev/sff_common.h | 1 - lib/eventdev/event_timer_adapter_pmd.h | 1 - lib/eventdev/eventdev_pmd.h | 17 -- lib/eventdev/rte_event_timer_adapter.h | 2 - lib/eventdev/rte_eventdev.h | 11 - lib/graph/rte_graph.h | 2 - lib/hash/rte_hash.h | 1 - lib/hash/rte_hash_crc.h | 1 - lib/ip_frag/rte_ipv6_fragmentation.c | 1 - lib/ip_frag/rte_ipv6_reassembly.c | 1 - lib/ipsec/ipsec_telemetry.c | 1 - lib/member/rte_member.h | 1 - lib/mempool/rte_mempool.c | 1 - lib/mempool/rte_mempool.h | 1 - lib/meter/rte_meter.h | 10 +- lib/mldev/mldev_utils.h | 1 - lib/node/rte_node_eth_api.h | 1 - lib/node/rte_node_ip4_api.h | 1 - lib/node/rte_node_ip6_api.h | 1 - lib/pcapng/rte_pcapng.h | 1 - lib/pdcp/rte_pdcp_group.h | 1 - lib/pipeline/rte_pipeline.c | 4 - lib/pipeline/rte_pipeline.h | 9 +- lib/pipeline/rte_swx_ipsec.h | 2 - lib/pipeline/rte_swx_pipeline_spec.c | 11 - lib/pipeline/rte_table_action.c | 2 +- lib/port/rte_port.h | 5 +- lib/port/rte_port_ethdev.h | 3 +- lib/port/rte_port_eventdev.h | 3 +- lib/port/rte_port_fd.h | 3 +- lib/port/rte_port_frag.h | 3 +- lib/port/rte_port_kni.h | 4 +- lib/port/rte_port_ras.h | 4 +- lib/port/rte_port_ring.h | 4 +- lib/port/rte_port_sched.h | 3 +- lib/port/rte_port_source_sink.h | 3 +- lib/port/rte_port_sym_crypto.h | 3 +- lib/port/rte_swx_port_fd.h | 5 +- lib/port/rte_swx_port_ring.h | 3 +- lib/power/guest_channel.h | 1 - lib/rawdev/rte_rawdev.h | 2 - lib/rawdev/rte_rawdev_pmd.h | 3 - lib/rcu/rte_rcu_qsbr.h | 1 - lib/regexdev/rte_regexdev_core.h | 1 - lib/reorder/rte_reorder.h | 1 - lib/ring/rte_ring.h | 1 - lib/sched/rte_approx.h | 3 +- lib/sched/rte_pie.h | 4 +- lib/sched/rte_red.h | 6 +- lib/sched/rte_sched.c | 3 +- lib/sched/rte_sched.h | 8 +- lib/sched/rte_sched_common.h | 2 - lib/security/rte_security.h | 7 +- lib/security/rte_security_driver.h | 1 - lib/table/rte_swx_table_em.c | 1 - lib/table/rte_table.h | 3 +- lib/table/rte_table_acl.h | 3 +- lib/table/rte_table_array.h | 3 +- lib/table/rte_table_hash.h | 4 +- lib/table/rte_table_hash_cuckoo.h | 4 +- lib/table/rte_table_hash_ext.c | 37 ++- lib/table/rte_table_hash_lru.c | 109 +++++---- lib/table/rte_table_lpm.h | 3 +- lib/table/rte_table_lpm_ipv6.h | 3 +- lib/table/rte_table_stub.h | 4 +- lib/telemetry/rte_telemetry.h | 2 +- lib/telemetry/telemetry_internal.h | 3 +- lib/telemetry/telemetry_json.h | 3 +- 117 files changed, 386 insertions(+), 585 deletions(-)
Comments
On Wed, Jun 14, 2023 at 8:01 PM Thomas Monjalon <thomas@monjalon.net> wrote: > > While pulling some trees for DPDK 23.07-rc1, > I've seen that some wrong coding style for comments > were copied over and over. > > In order to avoid copying wrong comment style, > the three first patches are fixing a lot of comments. > As it is not critical, they are not marked for backport. > > While looking the header files, I've fixed some misuses of "extern". Thanks for the cleanup. IMO, it is better to update ./devtools/checkpatches.sh or so to flag these issue before getting to repo for new changes,
On Wed, Jun 14, 2023 at 04:26:46PM +0200, Thomas Monjalon wrote: > While pulling some trees for DPDK 23.07-rc1, > I've seen that some wrong coding style for comments > were copied over and over. > > In order to avoid copying wrong comment style, > the three first patches are fixing a lot of comments. > As it is not critical, they are not marked for backport. > > While looking the header files, I've fixed some misuses of "extern". > > > Thomas Monjalon (5): > lib: remove blank line ending comment blocks > lib: remove extra asterisks ending comment blocks > lib: align comment blocks > lib: restrict use of keyword extern > cryptodev: fix comments of modular operation parameters > Some really good cleanup here, thanks. Not sure we need to fix the use of extern for functions, but removing the extern is harmless so ok for it. Series-acked-by: Bruce Richardson <bruce.richardson@intel.com>
On Wed, Jun 14, 2023 at 4:42 PM Jerin Jacob <jerinjacobk@gmail.com> wrote: > > On Wed, Jun 14, 2023 at 8:01 PM Thomas Monjalon <thomas@monjalon.net> wrote: > > > > While pulling some trees for DPDK 23.07-rc1, > > I've seen that some wrong coding style for comments > > were copied over and over. > > > > In order to avoid copying wrong comment style, > > the three first patches are fixing a lot of comments. > > As it is not critical, they are not marked for backport. > > > > While looking the header files, I've fixed some misuses of "extern". > > Thanks for the cleanup. IMO, it is better to update > ./devtools/checkpatches.sh or so to flag these issue before getting to > repo for new changes, Those are not easy to spot. +1 to add a check if that won't raise false positives.
14/06/2023 17:08, David Marchand: > On Wed, Jun 14, 2023 at 4:42 PM Jerin Jacob <jerinjacobk@gmail.com> wrote: > > > > On Wed, Jun 14, 2023 at 8:01 PM Thomas Monjalon <thomas@monjalon.net> wrote: > > > > > > While pulling some trees for DPDK 23.07-rc1, > > > I've seen that some wrong coding style for comments > > > were copied over and over. > > > > > > In order to avoid copying wrong comment style, > > > the three first patches are fixing a lot of comments. > > > As it is not critical, they are not marked for backport. > > > > > > While looking the header files, I've fixed some misuses of "extern". > > > > Thanks for the cleanup. IMO, it is better to update > > ./devtools/checkpatches.sh or so to flag these issue before getting to > > repo for new changes, > > Those are not easy to spot. > +1 to add a check if that won't raise false positives. It will raise false positives. And these are minor issues. I think we can do a cleanup every 5 years, it is OK :)
14/06/2023 16:46, Bruce Richardson: > On Wed, Jun 14, 2023 at 04:26:46PM +0200, Thomas Monjalon wrote: > > While pulling some trees for DPDK 23.07-rc1, > > I've seen that some wrong coding style for comments > > were copied over and over. > > > > In order to avoid copying wrong comment style, > > the three first patches are fixing a lot of comments. > > As it is not critical, they are not marked for backport. > > > > While looking the header files, I've fixed some misuses of "extern". > > > > > > Thomas Monjalon (5): > > lib: remove blank line ending comment blocks > > lib: remove extra asterisks ending comment blocks > > lib: align comment blocks > > lib: restrict use of keyword extern > > cryptodev: fix comments of modular operation parameters > > > > Some really good cleanup here, thanks. > > Not sure we need to fix the use of extern for functions, but removing the > extern is harmless so ok for it. > > Series-acked-by: Bruce Richardson <bruce.richardson@intel.com> Applied