[dpdk-dev,4/5] doc: add missing algorithm in limitations for QAT
Checks
Commit Message
For KASUMI, SNOW3G and ZUC algorithms, offsets and lengths
of the data to cipher or authenticate is provided in bits,
but QAT does not support non-byte aligned values,
although only KASUMI and SNOW3G were mentioned.
Fixes: d9b7d5bbc845 ("crypto/qat: add ZUC EEA3/EIA3 capability")
Cc: stable@dpdk.org
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
doc/guides/cryptodevs/qat.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
Hi Pablo,
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Thursday, July 13, 2017 6:37 AM
> To: Doherty, Declan <declan.doherty@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>; Griffin, John
> <john.griffin@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; stable@dpdk.org
> Subject: [PATCH 4/5] doc: add missing algorithm in limitations for QAT
>
> For KASUMI, SNOW3G and ZUC algorithms, offsets and lengths
> of the data to cipher or authenticate is provided in bits,
> but QAT does not support non-byte aligned values,
> although only KASUMI and SNOW3G were mentioned.
>
> Fixes: d9b7d5bbc845 ("crypto/qat: add ZUC EEA3/EIA3 capability")
> Cc: stable@dpdk.org
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> doc/guides/cryptodevs/qat.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
> index 7a510c9..8e390ee 100644
> --- a/doc/guides/cryptodevs/qat.rst
> +++ b/doc/guides/cryptodevs/qat.rst
> @@ -85,8 +85,8 @@ Limitations
> -----------
>
> * Only supports the session-oriented API implementation (session-less APIs are not supported).
> -* SNOW 3G (UEA2) and KASUMI (F8) supported only if cipher length, cipher offset fields are byte-
> aligned.
> -* SNOW 3G (UIA2) and KASUMI (F9) supported only if hash length, hash offset fields are byte-aligned.
> +* SNOW 3G (UEA2), KASUMI (F8) and ZUC (EEA3) supported only if cipher length, cipher offset fields
> are byte-aligned.
> +* SNOW 3G (UIA2), KASUMI (F9) and ZUC (EIA3) supported only if hash length, hash offset fields are
> byte-aligned.
Just being pedantic, but now would be a good time to change these to "byte-multiple"
@@ -85,8 +85,8 @@ Limitations
-----------
* Only supports the session-oriented API implementation (session-less APIs are not supported).
-* SNOW 3G (UEA2) and KASUMI (F8) supported only if cipher length, cipher offset fields are byte-aligned.
-* SNOW 3G (UIA2) and KASUMI (F9) supported only if hash length, hash offset fields are byte-aligned.
+* SNOW 3G (UEA2), KASUMI (F8) and ZUC (EEA3) supported only if cipher length, cipher offset fields are byte-aligned.
+* SNOW 3G (UIA2), KASUMI (F9) and ZUC (EIA3) supported only if hash length, hash offset fields are byte-aligned.
* No BSD support as BSD QAT kernel driver not available.
* ZUC EEA3/EIA3 is not supported by dh895xcc devices
* Maximum additional authenticated data (AAD) for GCM is 240 bytes long.