diff mbox

[dpdk-dev] app/testpmd: fix bonding initialization due to unproper name

Message ID 20170713094832.16904-1-michalx.k.jastrzebski@intel.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Michal Jastrzebski July 13, 2017, 9:48 a.m. UTC 
  when creating a bond device in testpmd, a name for a device must meet
the correct convention described in the documentation:
The device name must start with the net_bonding prefix
followed by numbers or letters.
Change for ALB mempool allocation - mem_name was too long.

Fixes: 9bf4901d1a11 ("bus/vdev: remove probe with driver name option")

Signed-off-by: Michal Jastrzebski <michalx.k.jastrzebski@intel.com>
---
 app/test-pmd/cmdline.c                 |    2 +-
 drivers/net/bonding/rte_eth_bond_alb.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Jingjing Wu July 21, 2017, 2:29 a.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michal Jastrzebski
> Sent: Thursday, July 13, 2017 5:49 PM
> To: dev@dpdk.org
> Cc: Jain, Deepak K <deepak.k.jain@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>; Jastrzebski, MichalX K
> <michalx.k.jastrzebski@intel.com>
> Subject: [dpdk-dev] [PATCH] app/testpmd: fix bonding initialization due to
> unproper name
> 
> when creating a bond device in testpmd, a name for a device must meet the
> correct convention described in the documentation:
> The device name must start with the net_bonding prefix followed by numbers
> or letters.
> Change for ALB mempool allocation - mem_name was too long.
> 
> Fixes: 9bf4901d1a11 ("bus/vdev: remove probe with driver name option")
> 
> Signed-off-by: Michal Jastrzebski <michalx.k.jastrzebski@intel.com>

Reviewed-by: Jingjing Wu <jingjing.wu@intel.com>
Thomas Monjalon July 21, 2017, 6:37 a.m. UTC | #2 
21/07/2017 05:29, Wu, Jingjing:
> 
> > when creating a bond device in testpmd, a name for a device must meet the
> > correct convention described in the documentation:
> > The device name must start with the net_bonding prefix followed by numbers
> > or letters.
> > Change for ALB mempool allocation - mem_name was too long.
> > 
> > Fixes: 9bf4901d1a11 ("bus/vdev: remove probe with driver name option")

Cc: stable@dpdk.org

> > Signed-off-by: Michal Jastrzebski <michalx.k.jastrzebski@intel.com>
> 
> Reviewed-by: Jingjing Wu <jingjing.wu@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index d4ff608..23361bc 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -4900,7 +4900,7 @@  static void cmd_create_bonded_device_parsed(void *parsed_result,
 		return;
 	}
 
-	snprintf(ethdev_name, RTE_ETH_NAME_MAX_LEN, "net_bond_testpmd_%d",
+	snprintf(ethdev_name, RTE_ETH_NAME_MAX_LEN, "net_bonding_testpmd_%d",
 			bond_dev_num++);
 
 	/* Create a new bonded device. */
diff --git a/drivers/net/bonding/rte_eth_bond_alb.c b/drivers/net/bonding/rte_eth_bond_alb.c
index 7f6884d..d9d3749 100644
--- a/drivers/net/bonding/rte_eth_bond_alb.c
+++ b/drivers/net/bonding/rte_eth_bond_alb.c
@@ -80,7 +80,7 @@ 
 		 * The value is chosen to be cache aligned.
 		 */
 		data_size = 256 + RTE_PKTMBUF_HEADROOM;
-		snprintf(mem_name, sizeof(mem_name), "%s_MODE6",
+		snprintf(mem_name, sizeof(mem_name), "%s_ALB",
 				bond_dev->device->name);
 		internals->mode6.mempool = rte_pktmbuf_pool_create(mem_name,
 			512 * RTE_MAX_ETHPORTS,