diff mbox series

[v1,1/4] common/iavf: add QFI fields for GTPU UL and DL

Message ID 20210817071652.9939-1-haiyue.wang@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Qi Zhang
Headers
Series [v1,1/4] common/iavf: add QFI fields for GTPU UL and DL |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Wang, Haiyue Aug. 17, 2021, 7:16 a.m. UTC 
  From: Junfeng Guo <junfeng.guo@intel.com>

Add virtchnl fields QFI of GTPU UL/DL for AVF FDIR.

Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
 drivers/common/iavf/virtchnl.h | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Qi Zhang Aug. 29, 2021, 11:37 a.m. UTC | #1 
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Haiyue Wang
> Sent: Tuesday, August 17, 2021 3:17 PM
> To: dev@dpdk.org
> Cc: Guo, Junfeng <junfeng.guo@intel.com>; Wang, Haiyue
> <haiyue.wang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>
> Subject: [dpdk-dev] [PATCH v1 1/4] common/iavf: add QFI fields for GTPU UL
> and DL
> 
> From: Junfeng Guo <junfeng.guo@intel.com>
> 
> Add virtchnl fields QFI of GTPU UL/DL for AVF FDIR.
> 
> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi
Ferruh Yigit Sept. 3, 2021, 10:41 a.m. UTC | #2 
On 8/17/2021 8:16 AM, Haiyue Wang wrote:
> From: Junfeng Guo <junfeng.guo@intel.com>
> 
> Add virtchnl fields QFI of GTPU UL/DL for AVF FDIR.

Can you please put what 'QFI' stands for in the commit log, I assume it is "QoS
Flow Identifier"?

What does it mean to add new protocol fields to the virtchnl?
And commit log mentions from 'FDIR', is this change updates anything in the flow
director support of the driver?

> 
> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
>  drivers/common/iavf/virtchnl.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtchnl.h
> index 1cf0866124..9fa5e3e891 100644
> --- a/drivers/common/iavf/virtchnl.h
> +++ b/drivers/common/iavf/virtchnl.h
> @@ -1642,6 +1642,11 @@ enum virtchnl_proto_hdr_field {
>  	/* IPv6 Extension Fragment */
>  	VIRTCHNL_PROTO_HDR_IPV6_EH_FRAG_PKID =
>  		PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_IPV6_EH_FRAG),
> +	/* GTPU_DWN/UP */
> +	VIRTCHNL_PROTO_HDR_GTPU_DWN_QFI =
> +		PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_GTPU_EH_PDU_DWN),
> +	VIRTCHNL_PROTO_HDR_GTPU_UP_QFI =
> +		PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_GTPU_EH_PDU_UP),
>  };
>  
>  struct virtchnl_proto_hdr {
>
diff mbox series

Patch

diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtchnl.h
index 1cf0866124..9fa5e3e891 100644
--- a/drivers/common/iavf/virtchnl.h
+++ b/drivers/common/iavf/virtchnl.h
@@ -1642,6 +1642,11 @@  enum virtchnl_proto_hdr_field {
 	/* IPv6 Extension Fragment */
 	VIRTCHNL_PROTO_HDR_IPV6_EH_FRAG_PKID =
 		PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_IPV6_EH_FRAG),
+	/* GTPU_DWN/UP */
+	VIRTCHNL_PROTO_HDR_GTPU_DWN_QFI =
+		PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_GTPU_EH_PDU_DWN),
+	VIRTCHNL_PROTO_HDR_GTPU_UP_QFI =
+		PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_GTPU_EH_PDU_UP),
 };
 
 struct virtchnl_proto_hdr {