diff mbox series

[v1,2/4] common/iavf: add proto hdr field support for L4 checksum

Message ID 20210817071652.9939-2-haiyue.wang@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Qi Zhang
Headers
Series [v1,1/4] common/iavf: add QFI fields for GTPU UL and DL |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Wang, Haiyue Aug. 17, 2021, 7:16 a.m. UTC 
  From: Alvin Zhang <alvinx.zhang@intel.com>

Add TCP/UDP/SCTP header checksum field selectors.

Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
 drivers/common/iavf/virtchnl.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

Qi Zhang Aug. 29, 2021, 11:38 a.m. UTC | #1 
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Haiyue Wang
> Sent: Tuesday, August 17, 2021 3:17 PM
> To: dev@dpdk.org
> Cc: Zhang, AlvinX <alvinx.zhang@intel.com>; Wang, Haiyue
> <haiyue.wang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>
> Subject: [dpdk-dev] [PATCH v1 2/4] common/iavf: add proto hdr field support for
> L4 checksum
> 
> From: Alvin Zhang <alvinx.zhang@intel.com>
> 
> Add TCP/UDP/SCTP header checksum field selectors.
> 
> Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi
Ferruh Yigit Sept. 3, 2021, 10:43 a.m. UTC | #2 
On 8/17/2021 8:16 AM, Haiyue Wang wrote:
> From: Alvin Zhang <alvinx.zhang@intel.com>
> 
> Add TCP/UDP/SCTP header checksum field selectors.
> 

Hi Alvin, Haiyue,

Can you please describe a little more, what is the impact of adding proto hdr
checksum field selector?

Is this also something related to the flow director as other patches in this set?

Thanks,
ferruh

> Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
>  drivers/common/iavf/virtchnl.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtchnl.h
> index 9fa5e3e891..c56c668cff 100644
> --- a/drivers/common/iavf/virtchnl.h
> +++ b/drivers/common/iavf/virtchnl.h
> @@ -1598,14 +1598,17 @@ enum virtchnl_proto_hdr_field {
>  	VIRTCHNL_PROTO_HDR_TCP_SRC_PORT =
>  		PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_TCP),
>  	VIRTCHNL_PROTO_HDR_TCP_DST_PORT,
> +	VIRTCHNL_PROTO_HDR_TCP_CHKSUM,
>  	/* UDP */
>  	VIRTCHNL_PROTO_HDR_UDP_SRC_PORT =
>  		PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_UDP),
>  	VIRTCHNL_PROTO_HDR_UDP_DST_PORT,
> +	VIRTCHNL_PROTO_HDR_UDP_CHKSUM,
>  	/* SCTP */
>  	VIRTCHNL_PROTO_HDR_SCTP_SRC_PORT =
>  		PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_SCTP),
>  	VIRTCHNL_PROTO_HDR_SCTP_DST_PORT,
> +	VIRTCHNL_PROTO_HDR_SCTP_CHKSUM,
>  	/* GTPU_IP */
>  	VIRTCHNL_PROTO_HDR_GTPU_IP_TEID =
>  		PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_GTPU_IP),
>
diff mbox series

Patch

diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtchnl.h
index 9fa5e3e891..c56c668cff 100644
--- a/drivers/common/iavf/virtchnl.h
+++ b/drivers/common/iavf/virtchnl.h
@@ -1598,14 +1598,17 @@  enum virtchnl_proto_hdr_field {
 	VIRTCHNL_PROTO_HDR_TCP_SRC_PORT =
 		PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_TCP),
 	VIRTCHNL_PROTO_HDR_TCP_DST_PORT,
+	VIRTCHNL_PROTO_HDR_TCP_CHKSUM,
 	/* UDP */
 	VIRTCHNL_PROTO_HDR_UDP_SRC_PORT =
 		PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_UDP),
 	VIRTCHNL_PROTO_HDR_UDP_DST_PORT,
+	VIRTCHNL_PROTO_HDR_UDP_CHKSUM,
 	/* SCTP */
 	VIRTCHNL_PROTO_HDR_SCTP_SRC_PORT =
 		PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_SCTP),
 	VIRTCHNL_PROTO_HDR_SCTP_DST_PORT,
+	VIRTCHNL_PROTO_HDR_SCTP_CHKSUM,
 	/* GTPU_IP */
 	VIRTCHNL_PROTO_HDR_GTPU_IP_TEID =
 		PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_GTPU_IP),