Message ID | 1571832859-12659-1-git-send-email-rasland@mellanox.com (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Ferruh Yigit |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E5E9F1C128; Wed, 23 Oct 2019 14:14:28 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30070.outbound.protection.outlook.com [40.107.3.70]) by dpdk.org (Postfix) with ESMTP id 569441C125 for <dev@dpdk.org>; Wed, 23 Oct 2019 14:14:27 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JdRxn5X9DrMnA68FdhvJbQjps/A5ohjj3vBp52kYS0x19lPtwdBwszujOyKo6BW7JBRH2wYFI2RZditJFEYik7iwoXCZjMKDMWRaJzkO9o3jBDYTZ1enjjPwO4tZBoGsB4HAScMOSvjIPJwStBw6QsO8fZxjOrOvRjqlY1qvdzYWUoAQmQVhFZgQXvL0IOsFVhZiUasY7Z4V5REME8KW0NK5cdYNggcE/1UtB6ykKketk2kxcJqwtkNEmYrgeWVYfs0ESwsD9XDRTe9yBetw9hTykYM2KVXHcEz5HRiXFeWExaCN2pJ5iHpbC2SSxiG6Ze8ytbu1inR4jxNtQVCJhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vC4pwd4lpVSuaT/pOWAxjyQctszfxJjSS2L5R2C45Gg=; b=f/xbX5xPPbrUoYEkkRFR6mMCwwsclBEkGFmu1xT/jCaTSyx8kRbG58o47YOnuJc9RTsHRaX8F7F3nc4Tla6K39dpLQKCS1FovuVJbUOAz3xaDi2N7vjVhGtl9oCmO9fUwmrL0+MblPmzGXS5Lls1dJcY4tw0lW0sMiHlTyKYV62Mw+GrSsWNFdVV1oHxxz1ZztiTFrxHD0hxY/6HVn0eT/aKS8RxyGCTYCrJAE9yHR8LSON+x3yYpC/mnC21EnDq3K+ghv9HWETAxFvdHGSsZNQygxHOxvCEJgseikKOyIZ1IPW6ynCwnH15dKZ4wGIQH0JFRM9LdSj6MA42vYun4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vC4pwd4lpVSuaT/pOWAxjyQctszfxJjSS2L5R2C45Gg=; b=g5gtPgbvL+fhkB3AAKSj6P0Eu7C182d1O1hcHDGpCKWcoYy3lJKySV+j/SQzsTLs7NZGHeoeg4OlY0fABdhenP+LYh3bUjfstVWp4ThCglOMUMco66MO4/bjbHo3kBDvQmq6UB/I7P38pHhk6huc+L8XV4/e3xbf07yq4qoYjdg= Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com (52.134.65.161) by DB3PR0502MB4009.eurprd05.prod.outlook.com (52.134.72.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2367.20; Wed, 23 Oct 2019 12:14:26 +0000 Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::1528:69ed:ffec:764b]) by DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::1528:69ed:ffec:764b%5]) with mapi id 15.20.2387.021; Wed, 23 Oct 2019 12:14:26 +0000 From: Raslan Darawsheh <rasland@mellanox.com> To: "ferruh.yigit@intel.com" <ferruh.yigit@intel.com> CC: Slava Ovsiienko <viacheslavo@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>, "kirankumark@marvell.com" <kirankumark@marvell.com> Thread-Topic: [PATCH] ethdev: fix compilation with gcc 4.8 Thread-Index: AQHViZtpJaA+jlj090222JuaKiFbQA== Date: Wed, 23 Oct 2019 12:14:26 +0000 Message-ID: <1571832859-12659-1-git-send-email-rasland@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.7.4 x-clientproxiedby: GV0P278CA0003.CHEP278.PROD.OUTLOOK.COM (2603:10a6:710:26::13) To DB3PR0502MB3964.eurprd05.prod.outlook.com (2603:10a6:8:3::33) authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 5675f88e-3616-433f-4296-08d757b28be2 x-ms-traffictypediagnostic: DB3PR0502MB4009:|DB3PR0502MB4009: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: <DB3PR0502MB40090B416557992ECC2A927CC26B0@DB3PR0502MB4009.eurprd05.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:1417; x-forefront-prvs: 019919A9E4 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(136003)(366004)(39860400002)(396003)(376002)(199004)(189003)(71190400001)(25786009)(6916009)(478600001)(4326008)(71200400001)(14454004)(2501003)(476003)(2351001)(3846002)(66556008)(66476007)(64756008)(102836004)(66446008)(6116002)(486006)(4744005)(66946007)(2616005)(26005)(305945005)(36756003)(386003)(5640700003)(86362001)(6506007)(7736002)(99286004)(81166006)(5660300002)(2906002)(6486002)(186003)(8936002)(54906003)(50226002)(14444005)(256004)(66066001)(6512007)(316002)(8676002)(52116002)(6436002)(81156014); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4009; H:DB3PR0502MB3964.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: C5IDzeXnlLn6+TK57391JbNpTYU27A/lYifxHQqHI+6pwO+MVeqs+gMyfOqQiz/L23OTia7RA0229RcMz8zoA+UjENiYjTvxZQ3cl+cAUuo/2ejJpiK3mpD69QaFsAciOSOkitfDR9TSfQSwgptPuB4yobhlGA3XZWN7S32lRnMYfgRN4kOONQ4KsZvp3aMNDvm6maNgEdkDTnzAvFRs5cfwFpj1x5J9TcrIUczH3e6QXw5Rh8dt3U9WDQNukxV0cpQyo0woBCXVAliqki4dPwcd/V1jYZNHyISgqBeWu5a+sS6/RAHgmx2QOC64cVZVpCrqDtrvDSgcRhgGssgTCMSXwHwiTys/xF2pX1SemUlaDAu3j5G45kEDPyct1JX4OLjCRhXlIRwAVgxetrh66fXWQB5c9gDRDUzBEdtUQILfMncZw9GdrOqrDhWuOvJi Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5675f88e-3616-433f-4296-08d757b28be2 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2019 12:14:26.2269 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZtdhJuIaLTDSV9iRxJaXydmn5WjXfWoNsMA+AJ5IzAi1keZxa2OFVXhn6zd3OWEDgTzBW03NjDCpYy5tcXes2Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4009 Subject: [dpdk-dev] [PATCH] ethdev: fix compilation with gcc 4.8 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
ethdev: fix compilation with gcc 4.8
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | warning | coding style issues |
ci/Intel-compilation | fail | apply issues |
Commit Message
Raslan Darawsheh
Oct. 23, 2019, 12:14 p.m. UTC
gcc 4.8 is considering bit filed as extention rather than
c11 std with pedantic, which cause compilation failure.
This adds extention keyword exceplicitly to the struct
to avoid compilation issue on gcc 4.8
Fixes: a7658a86 ("ethdev: add HIGIG2 key field to flow API")
Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
---
lib/librte_net/rte_higig.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 10/23/2019 1:14 PM, Raslan Darawsheh wrote: > gcc 4.8 is considering bit filed as extention rather than > c11 std with pedantic, which cause compilation failure. > > This adds extention keyword exceplicitly to the struct > to avoid compilation issue on gcc 4.8 > > Fixes: a7658a86 ("ethdev: add HIGIG2 key field to flow API") > > Signed-off-by: Raslan Darawsheh <rasland@mellanox.com> > --- > lib/librte_net/rte_higig.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_net/rte_higig.h b/lib/librte_net/rte_higig.h > index 44df666..b9cdfef 100644 > --- a/lib/librte_net/rte_higig.h > +++ b/lib/librte_net/rte_higig.h > @@ -103,7 +103,7 @@ struct rte_higig2_ppt_type0 { > * > * higig2 ppt type1 header. > */ > -RTE_STD_C11 > +__extension__ > struct rte_higig2_ppt_type1 { > uint16_t classification; > uint16_t resv; > Why other structs in this file with bit-field doesn't cause problem with gcc4.8, is the problem only for "uint16_t" ?
On 10/23/2019 1:14 PM, Raslan Darawsheh wrote: > gcc 4.8 is considering bit filed as extention rather than > c11 std with pedantic, which cause compilation failure. > > This adds extention keyword exceplicitly to the struct > to avoid compilation issue on gcc 4.8 > > Fixes: a7658a86 ("ethdev: add HIGIG2 key field to flow API") > > Signed-off-by: Raslan Darawsheh <rasland@mellanox.com> Squashed into relevant commit in next-net, thanks. Unfortunately lost the context that why it has been marked with '__extension__' instead of 'RTE_STD_C11', hopefully someone won't try to "fix" it in the future.
diff --git a/lib/librte_net/rte_higig.h b/lib/librte_net/rte_higig.h index 44df666..b9cdfef 100644 --- a/lib/librte_net/rte_higig.h +++ b/lib/librte_net/rte_higig.h @@ -103,7 +103,7 @@ struct rte_higig2_ppt_type0 { * * higig2 ppt type1 header. */ -RTE_STD_C11 +__extension__ struct rte_higig2_ppt_type1 { uint16_t classification; uint16_t resv;