mbox series

[v2,0/8] Coverity fixes and other cleanups

Message ID 20191106190203.10750-1-ktraynor@redhat.com (mailing list archive)
Headers
Series Coverity fixes and other cleanups |

Message

Kevin Traynor Nov. 6, 2019, 7:01 p.m. UTC 
  Patches 1-4 are Coverity fixes.
Patches 5-8 are removing commented out code.

v2:
- 1/8: removed added NULL check for devargs_all
- 2/8: fixed headline to common/cpt
- v1 3/9 'net/bnxt: remove logically dead code'
  removed as duplicate patch already applied
 
Kevin Traynor (8):
  net/pcap: fix argument checks
  common/cpt: fix possible NULL deference
  net/ipn3ke: fix incorrect commit check logic
  net/ipn3ke: remove useless if statement
  net/ipn3ke: remove commented out code
  compress/octeontx: remove commented out code
  event/opdl: remove commented out code
  net/bnxt: remove commented out code

 drivers/common/cpt/cpt_ucode.h               | 3 ++-
 drivers/compress/octeontx/include/zip_regs.h | 8 --------
 drivers/event/opdl/opdl_test.c               | 3 ---
 drivers/net/bnxt/bnxt_ethdev.c               | 3 ---
 drivers/net/ipn3ke/ipn3ke_ethdev.c           | 3 +--
 drivers/net/ipn3ke/ipn3ke_ethdev.h           | 7 -------
 drivers/net/ipn3ke/ipn3ke_tm.c               | 7 -------
 drivers/net/pcap/rte_eth_pcap.c              | 6 ------
 8 files changed, 3 insertions(+), 37 deletions(-)

Comments

David Marchand Nov. 8, 2019, 2:07 p.m. UTC | #1 
On Wed, Nov 6, 2019 at 8:02 PM Kevin Traynor <ktraynor@redhat.com> wrote:
>
> Patches 1-4 are Coverity fixes.
> Patches 5-8 are removing commented out code.
>
> v2:
> - 1/8: removed added NULL check for devargs_all
> - 2/8: fixed headline to common/cpt
> - v1 3/9 'net/bnxt: remove logically dead code'
>   removed as duplicate patch already applied
>
> Kevin Traynor (8):
>   net/pcap: fix argument checks
>   common/cpt: fix possible NULL deference
>   net/ipn3ke: fix incorrect commit check logic
>   net/ipn3ke: remove useless if statement
>   net/ipn3ke: remove commented out code
>   compress/octeontx: remove commented out code
>   event/opdl: remove commented out code
>   net/bnxt: remove commented out code

Dropped patch 3 since I did not see a review on it, and I was not
feeling comfortable with it.

Applied, thanks.


--
David Marchand
Xu, Rosen Nov. 8, 2019, 2:41 p.m. UTC | #2 
Hi David,

Too busy today, sorry for late reply.

> -----Original Message-----
> From: David Marchand [mailto:david.marchand@redhat.com]
> Sent: Friday, November 08, 2019 22:08
> To: Kevin Traynor <ktraynor@redhat.com>
> Cc: dev <dev@dpdk.org>; Xu, Rosen <rosen.xu@intel.com>; Ye, Xiaolong
> <xiaolong.ye@intel.com>
> Subject: Re: [v2 PATCH 0/8] Coverity fixes and other cleanups
> 
> On Wed, Nov 6, 2019 at 8:02 PM Kevin Traynor <ktraynor@redhat.com>
> wrote:
> >
> > Patches 1-4 are Coverity fixes.
> > Patches 5-8 are removing commented out code.
> >
> > v2:
> > - 1/8: removed added NULL check for devargs_all
> > - 2/8: fixed headline to common/cpt
> > - v1 3/9 'net/bnxt: remove logically dead code'
> >   removed as duplicate patch already applied
> >
> > Kevin Traynor (8):
> >   net/pcap: fix argument checks
> >   common/cpt: fix possible NULL deference
> >   net/ipn3ke: fix incorrect commit check logic
> >   net/ipn3ke: remove useless if statement
> >   net/ipn3ke: remove commented out code
> >   compress/octeontx: remove commented out code
> >   event/opdl: remove commented out code
> >   net/bnxt: remove commented out code
> 
> Dropped patch 3 since I did not see a review on it, and I was not feeling
> comfortable with it.
> 
> Applied, thanks.
> 
> 
> --
> David Marchand
David Marchand Nov. 8, 2019, 3:15 p.m. UTC | #3 
On Fri, Nov 8, 2019 at 3:41 PM Xu, Rosen <rosen.xu@intel.com> wrote:
>
> Hi David,
>
> Too busy today, sorry for late reply.

Ok, no problem, I had not pushed yet.
So I put the patch 3 back in my tree with your Review tokens added
where applicable, and pushed the full series.


> > > Kevin Traynor (8):
> > >   net/pcap: fix argument checks
> > >   common/cpt: fix possible NULL deference
> > >   net/ipn3ke: fix incorrect commit check logic
> > >   net/ipn3ke: remove useless if statement
> > >   net/ipn3ke: remove commented out code
> > >   compress/octeontx: remove commented out code
> > >   event/opdl: remove commented out code
> > >   net/bnxt: remove commented out code
> >
> > Dropped patch 3 since I did not see a review on it, and I was not feeling
> > comfortable with it.
> >
> > Applied, thanks.


--
David Marchand