examples/fips_validation: fix parsing of cipher length for AES-GCM
Checks
Commit Message
From: Sucharitha Sarananaga <ssarananaga@marvell.com>
Cipher length need to be updated in case of AES-GCM decryption.
Fixes: 4aaad2995e13 ("examples/fips_validation: support GCM parsing")
Signed-off-by: Archana Muniganti <marchana@marvell.com>
Signed-off-by: Sucharitha Sarananaga <ssarananaga@marvell.com>
---
examples/fips_validation/fips_validation_gcm.c | 2 ++
1 file changed, 2 insertions(+)
Comments
Hi Akhil,
Please see inline.
Thanks,
Archana
> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: Monday, January 6, 2020 3:09 PM
> To: Archana Muniganti <marchana@marvell.com>;
> marko.kovacevic@intel.com; roy.fan.zhang@intel.com
> Cc: Sucharitha Sarananaga <ssarananaga@marvell.com>; Anoob Joseph
> <anoobj@marvell.com>; Abed Mohammad Kamaluddin
> <akamaluddin@marvell.com>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>; dev@dpdk.org; stable@dpdk.org
> Subject: [EXT] RE: [PATCH] examples/fips_validation: fix parsing of cipher
> length for AES-GCM
>
> External Email
>
> ----------------------------------------------------------------------
> > From: Sucharitha Sarananaga <ssarananaga@marvell.com>
> >
> > Cipher length need to be updated in case of AES-GCM decryption.
> >
> > Fixes: 4aaad2995e13 ("examples/fips_validation: support GCM parsing")
> >
> > Signed-off-by: Archana Muniganti <marchana@marvell.com>
> > Signed-off-by: Sucharitha Sarananaga <ssarananaga@marvell.com>
> > ---
> > examples/fips_validation/fips_validation_gcm.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/examples/fips_validation/fips_validation_gcm.c
> > b/examples/fips_validation/fips_validation_gcm.c
> > index ea48ddf..f295025 100644
> > --- a/examples/fips_validation/fips_validation_gcm.c
> > +++ b/examples/fips_validation/fips_validation_gcm.c
> > @@ -19,6 +19,7 @@
> > #define PTLEN_STR "PTlen = "
> > #define AADLEN_STR "AADlen = "
> > #define TAGLEN_STR "Taglen = "
> > +#define CTLEN_STR "PTlen = "
> Typo. Should be CTlen
[Archana] NIST request file for AES-GCM test vectors contains 'PTlen =' field.
This field holds plain text length when encrypt test vectors are used. And same
field holds cipher text length when decrypt test vectors are used.
Hence added a new macro that will be used in AES-GCM 'decryption'
> -----Original Message-----
> From: Archana Muniganti <marchana@marvell.com>
> Sent: Monday, January 6, 2020 3:03 PM
> To: marko.kovacevic@intel.com; roy.fan.zhang@intel.com;
> akhil.goyal@nxp.com
> Cc: Sucharitha Sarananaga <ssarananaga@marvell.com>; Anoob Joseph
> <anoobj@marvell.com>; Abed Mohammad Kamaluddin
> <akamaluddin@marvell.com>; Jerin Jacob Kollanukkaran <jerinj@marvell.com>;
> dev@dpdk.org; stable@dpdk.org; Archana Muniganti
> <marchana@marvell.com>
> Subject: [PATCH] examples/fips_validation: fix parsing of cipher length for AES-
> GCM
>
> From: Sucharitha Sarananaga <ssarananaga@marvell.com>
>
> Cipher length need to be updated in case of AES-GCM decryption.
>
> Fixes: 4aaad2995e13 ("examples/fips_validation: support GCM parsing")
>
> Signed-off-by: Archana Muniganti <marchana@marvell.com>
> Signed-off-by: Sucharitha Sarananaga <ssarananaga@marvell.com>
Acked-by: Anoob Joseph <anoobj@marvell.com>
> >
> > From: Sucharitha Sarananaga <ssarananaga@marvell.com>
> >
> > Cipher length need to be updated in case of AES-GCM decryption.
> >
> > Fixes: 4aaad2995e13 ("examples/fips_validation: support GCM parsing")
> >
> > Signed-off-by: Archana Muniganti <marchana@marvell.com>
> > Signed-off-by: Sucharitha Sarananaga <ssarananaga@marvell.com>
>
> Acked-by: Anoob Joseph <anoobj@marvell.com>
Applied to dpdk-next-crypto
Thanks.
@@ -19,6 +19,7 @@
#define PTLEN_STR "PTlen = "
#define AADLEN_STR "AADlen = "
#define TAGLEN_STR "Taglen = "
+#define CTLEN_STR "PTlen = "
#define COUNT_STR "Count = "
#define KEY_STR "Key = "
@@ -46,6 +47,7 @@ struct fips_test_callback gcm_interim_vectors[] = {
{KEYLEN_STR, parser_read_uint32_bit_val, &vec.aead.key},
{IVLEN_STR, parser_read_uint32_bit_val, &vec.iv},
{PTLEN_STR, parser_read_uint32_bit_val, &vec.pt},
+ {CTLEN_STR, parser_read_uint32_bit_val, &vec.ct},
{AADLEN_STR, parser_read_uint32_bit_val, &vec.aead.aad},
{TAGLEN_STR, parser_read_uint32_bit_val,
&vec.aead.digest},