diff mbox series

[v2] crypto/kasumi: fix gcc 10 fno-common error

Message ID 20200506094518.4620-1-ktraynor@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series [v2] crypto/kasumi: fix gcc 10 fno-common error |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/travis-robot success Travis build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-nxp-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS

Commit Message

Kevin Traynor May 6, 2020, 9:45 a.m. UTC 
  gcc 10 defaults to fno-common and it reports:

crypto_kasumi_rte_kasumi_pmd_ops.c.o:(.data.rel+0x0):
multiple definition of `rte_kasumi_pmd_ops';
crypto_kasumi_rte_kasumi_pmd.c.o:(.bss+0x8): first defined here

Fix by making rte_kasumi_pmd_ops extern in the header file.

Fixes: 2773c86d061a ("crypto/kasumi: add driver for KASUMI library")
Cc: stable@dpdk.org

Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

---
v2: add tags and ack
---
 drivers/crypto/kasumi/kasumi_pmd_private.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Akhil Goyal May 9, 2020, 10:01 p.m. UTC | #1 
> gcc 10 defaults to fno-common and it reports:
> 
> crypto_kasumi_rte_kasumi_pmd_ops.c.o:(.data.rel+0x0):
> multiple definition of `rte_kasumi_pmd_ops';
> crypto_kasumi_rte_kasumi_pmd.c.o:(.bss+0x8): first defined here
> 
> Fix by making rte_kasumi_pmd_ops extern in the header file.
> 
> Fixes: 2773c86d061a ("crypto/kasumi: add driver for KASUMI library")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> 
Applied to dpdk-next-crypto

Thanks.
diff mbox series

Patch

diff --git a/drivers/crypto/kasumi/kasumi_pmd_private.h b/drivers/crypto/kasumi/kasumi_pmd_private.h
index b7f1c428b..abedcd616 100644
--- a/drivers/crypto/kasumi/kasumi_pmd_private.h
+++ b/drivers/crypto/kasumi/kasumi_pmd_private.h
@@ -77,5 +77,5 @@  kasumi_set_session_parameters(MB_MGR *mgr, struct kasumi_session *sess,
 
 /** device specific operations function pointer structure */
-struct rte_cryptodev_ops *rte_kasumi_pmd_ops;
+extern struct rte_cryptodev_ops *rte_kasumi_pmd_ops;
 
 #endif /* _KASUMI_PMD_PRIVATE_H_ */