compress/qat: revert change in GEN3 marketing name
Checks
Commit Message
This reverts commit 9cd9d3e702fba4700539c1a2eddac13dd14ecf70.
Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
---
doc/guides/cryptodevs/qat.rst | 6 +++---
drivers/compress/qat/qat_comp_pmd.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
Comments
> -----Original Message-----
> From: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Sent: Monday, June 8, 2020 3:42 PM
> To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; akhil.goyal@nxp.com
> Cc: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Subject: [PATCH] compress/qat: revert change in GEN3 marketing name
>
> This reverts commit 9cd9d3e702fba4700539c1a2eddac13dd14ecf70.
>
> Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Hi Adam/Fiona,
Please mention a reason why this patch need to be reverted.
We cannot keep on changing a marketing name in every release.
If this patch is needed, then we should also queue it for stable backporting.
Regards,
Akhil
> > -----Original Message-----
> > From: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> > Sent: Monday, June 8, 2020 3:42 PM
> > To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>;
> akhil.goyal@nxp.com
> > Cc: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> > Subject: [PATCH] compress/qat: revert change in GEN3 marketing name
> >
> > This reverts commit 9cd9d3e702fba4700539c1a2eddac13dd14ecf70.
> >
> > Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Akhil,
This doesn't have to be backported as the original patch was withdrawn from the stable before the release, thanks to Fiona's prompt action. That's why this commit revert patch affects only the dev branch.
Adam
> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: Wednesday, 24 June, 2020 16:50
> To: Trahe, Fiona <fiona.trahe@intel.com>; Dybkowski, AdamX
> <adamx.dybkowski@intel.com>; dev@dpdk.org
> Subject: RE: [PATCH] compress/qat: revert change in GEN3 marketing name
>
> Hi Adam/Fiona,
>
> Please mention a reason why this patch need to be reverted.
> We cannot keep on changing a marketing name in every release.
> If this patch is needed, then we should also queue it for stable backporting.
>
> Regards,
> Akhil
> > > -----Original Message-----
> > > From: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> > > Sent: Monday, June 8, 2020 3:42 PM
> > > To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>;
> > akhil.goyal@nxp.com
> > > Cc: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> > > Subject: [PATCH] compress/qat: revert change in GEN3 marketing name
> > >
> > > This reverts commit 9cd9d3e702fba4700539c1a2eddac13dd14ecf70.
> > >
> > > Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> > Acked-by: Fiona Trahe <fiona.trahe@intel.com>
>
> Akhil,
>
> This doesn't have to be backported as the original patch was withdrawn from
> the stable before the release, thanks to Fiona's prompt action. That's why this
> commit revert patch affects only the dev branch.
>
Ok send a v2 with proper description why this need to be reverted.
Hi Akhil,
Sorry about the confusion.
This was a simple internal miscommunication - there was a decision made to change the name, so we did promptly.
The decision was reversed pretty soon after due to an impact on other projects, but I was out-of-the loop on it - I just discovered it recently.
Do you still need a v2? I'm not sure how much of that is worth putting in a commit message.
Fiona
> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: Wednesday, June 24, 2020 3:55 PM
> To: Dybkowski, AdamX <adamx.dybkowski@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>;
> dev@dpdk.org
> Subject: RE: [PATCH] compress/qat: revert change in GEN3 marketing name
>
>
> >
> > Akhil,
> >
> > This doesn't have to be backported as the original patch was withdrawn from
> > the stable before the release, thanks to Fiona's prompt action. That's why this
> > commit revert patch affects only the dev branch.
> >
>
> Ok send a v2 with proper description why this need to be reverted.
Hi Fiona,
>
> Hi Akhil,
>
> Sorry about the confusion.
> This was a simple internal miscommunication - there was a decision made to
> change the name, so we did promptly.
> The decision was reversed pretty soon after due to an impact on other projects,
> but I was out-of-the loop on it - I just discovered it recently.
>
> Do you still need a v2? I'm not sure how much of that is worth putting in a
> commit message.
>
We should not leave the description blank.
Probably it can be written that the marketing name was reverted back as it was
Impacting other projects.
Or something of that sort.
Regards,
Akhil
@@ -23,7 +23,7 @@ poll mode crypto driver support for the following hardware accelerator devices:
* ``Intel QuickAssist Technology C62x``
* ``Intel QuickAssist Technology C3xxx``
* ``Intel QuickAssist Technology D15xx``
-* ``Intel QuickAssist Technology P5xxx``
+* ``Intel QuickAssist Technology C4xxx``
Features
@@ -155,7 +155,7 @@ poll mode crypto driver support for the following hardware accelerator devices:
* ``Intel QuickAssist Technology C62x``
* ``Intel QuickAssist Technology C3xxx``
* ``Intel QuickAssist Technology D15xx``
-* ``Intel QuickAssist Technology P5xxx``
+* ``Intel QuickAssist Technology C4xxx``
The QAT ASYM PMD has support for:
@@ -385,7 +385,7 @@ to see the full table)
+-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
| Yes | No | No | 2 | D15xx | p | qat_d15xx | d15xx | 6f54 | 1 | 6f55 | 16 |
+-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
- | Yes | No | No | 3 | P5xxx | p | qat_p5xxx | p5xxx | 18a0 | 1 | 18a1 | 128 |
+ | Yes | No | No | 3 | C4xxx | p | qat_c4xxx | c4xxx | 18a0 | 1 | 18a1 | 128 |
+-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
* Note: Symmetric mixed crypto algorithms feature on Gen 2 works only with 01.org driver version 4.9.0+
@@ -656,7 +656,7 @@ qat_comp_dev_create(struct qat_pci_device *qat_pci_dev,
{
int i = 0;
if (qat_pci_dev->qat_dev_gen == QAT_GEN3) {
- QAT_LOG(ERR, "Compression PMD not supported on QAT P5xxx");
+ QAT_LOG(ERR, "Compression PMD not supported on QAT c4xxx");
return 0;
}