diff mbox series

[V1] fix enable verbose dts log duplicate info in file and console

Message ID 20200820071548.89512-1-qimaix.xiao@intel.com (mailing list archive)
State Accepted
Headers
Series [V1] fix enable verbose dts log duplicate info in file and console |

Commit Message

Xiao, QimaiX Aug. 20, 2020, 7:15 a.m. UTC 
  *. debug level is lower than info, when enable dts verbose, both info and debug
message will be print and logged twice

Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
---
 framework/ssh_connection.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Xiao, QimaiX Aug. 20, 2020, 7:41 a.m. UTC | #1 
Tested-by: Xiao Qimai <qimaix.xiao@intel.com>

Regards,
Xiao Qimai

> -----Original Message-----
> From: Xiao, QimaiX <qimaix.xiao@intel.com>
> Sent: Thursday, August 20, 2020 3:16 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [PATCH V1] fix enable verbose dts log duplicate info in file and
> console
> 
> *. debug level is lower than info, when enable dts verbose, both info and
> debug message will be print and logged twice
> 
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
>  framework/ssh_connection.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/framework/ssh_connection.py b/framework/ssh_connection.py
> index afeef1c..e096a9e 100644
> --- a/framework/ssh_connection.py
> +++ b/framework/ssh_connection.py
> @@ -62,7 +62,7 @@ class SSHConnection(object):
>      def send_expect(self, cmds, expected, timeout=15, verify=False):
>          self.logger.info(cmds)
>          out = self.session.send_expect(cmds, expected, timeout, verify)
> -        self.logger.debug(out)
> +        self.logger.debug(out.replace(cmds, ''))
>          if type(self.history) is list:
>              self.history.append({"command": cmds, "name": self.name, "output":
> out})
>          return out
> @@ -70,7 +70,7 @@ class SSHConnection(object):
>      def send_command(self, cmds, timeout=1):
>          self.logger.info(cmds)
>          out = self.session.send_command(cmds, timeout)
> -        self.logger.debug(out)
> +        self.logger.debug(out.replace(cmds, ''))
>          if type(self.history) is list:
>              self.history.append({"command": cmds, "name": self.name, "output":
> out})
>          return out
> --
> 2.25.1
Tu, Lijuan Aug. 21, 2020, 3:43 a.m. UTC | #2 
> *. debug level is lower than info, when enable dts verbose, both info and debug
> message will be print and logged twice
> 
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
>  framework/ssh_connection.py | 4 ++--

Applied
diff mbox series

Patch

diff --git a/framework/ssh_connection.py b/framework/ssh_connection.py
index afeef1c..e096a9e 100644
--- a/framework/ssh_connection.py
+++ b/framework/ssh_connection.py
@@ -62,7 +62,7 @@  class SSHConnection(object):
     def send_expect(self, cmds, expected, timeout=15, verify=False):
         self.logger.info(cmds)
         out = self.session.send_expect(cmds, expected, timeout, verify)
-        self.logger.debug(out)
+        self.logger.debug(out.replace(cmds, ''))
         if type(self.history) is list:
             self.history.append({"command": cmds, "name": self.name, "output": out})
         return out
@@ -70,7 +70,7 @@  class SSHConnection(object):
     def send_command(self, cmds, timeout=1):
         self.logger.info(cmds)
         out = self.session.send_command(cmds, timeout)
-        self.logger.debug(out)
+        self.logger.debug(out.replace(cmds, ''))
         if type(self.history) is list:
             self.history.append({"command": cmds, "name": self.name, "output": out})
         return out