Message ID | 1603359758-13297-1-git-send-email-arybchenko@solarflare.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2296AA04DD; Thu, 22 Oct 2020 11:43:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4AF26A901; Thu, 22 Oct 2020 11:43:05 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id A5922A900 for <dev@dpdk.org>; Thu, 22 Oct 2020 11:43:03 +0200 (CEST) Received: from mx1-us1.ppe-hosted.com (unknown [10.110.50.150]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 2ADD42006C; Thu, 22 Oct 2020 09:43:02 +0000 (UTC) Received: from us4-mdac16-56.at1.mdlocal (unknown [10.110.48.199]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 29A6A800A3; Thu, 22 Oct 2020 09:43:02 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.110.48.45]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id AE20E10004F; Thu, 22 Oct 2020 09:43:01 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 7513B94005E; Thu, 22 Oct 2020 09:43:01 +0000 (UTC) Received: from ukex01.SolarFlarecom.com (10.17.10.4) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 22 Oct 2020 10:42:58 +0100 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 22 Oct 2020 10:42:58 +0100 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 09M9gvCL022940; Thu, 22 Oct 2020 10:42:57 +0100 Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id D2FB21613A9; Thu, 22 Oct 2020 10:42:57 +0100 (BST) From: Andrew Rybchenko <arybchenko@solarflare.com> To: CC: <dev@dpdk.org>, Ferruh Yigit <ferruh.yigit@intel.com> Date: Thu, 22 Oct 2020 10:42:23 +0100 Message-ID: <1603359758-13297-1-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1603030152-13451-1-git-send-email-arybchenko@solarflare.com> References: <1603030152-13451-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.6.1012-25740.003 X-TM-AS-Result: No-2.509200-8.000000-10 X-TMASE-MatchedRID: bup1/1671+QPTHyhIpptdaiUivh0j2PveXZz1at5bOyB+6x3pZhLt9lQ tUFiiij6EWMioiewS9erODE35fCYme5y09ovkmT9zQWhka4AQNVDyJQKgOPwxMz/SxKo9mJ4eKa jvO6uWnALd2Yob3TwYTBIIGkJqBEXyVynYqyLE4n9xyC38S1f/bto11mU6Hl8ikvLPxTKpjgPw2 fgAhTJyL0diBly9dXAPJOIJdnx+ORkffinb4LGEsPRlYRmv+e2nKpQna4coUAd0WOKRkwsh1IAA 1ljhG5jdsHCDX3Hk44qq3YUbX8N0JDnULf2Bkv2FEUknJ/kEl7dB/CxWTRRu+rAZ8KTspSzs3Hd WVMUgMqHboyYbtJznaj/c+NN7YsjCv6jvtx+od9aUEck367N7nkqHFqNG52/avfiZ2JFTAeWXps W26cbdjNNfu6VrJ/pD1y8R38S3l1URzkirO0Q1F5h9KQWrq4BvuMTr7CQJJ5+3BndfXUhXQ== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--2.509200-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.6.1012-25740.003 X-MDID: 1603359782-ufjZizI0THcR X-PPE-DISP: 1603359782;ufjZizI0THcR Subject: [dpdk-dev] [PATCH v2 00/14] ethdev: remove legacy filter API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
ethdev: remove legacy filter API
|
|
Message
Andrew Rybchenko
Oct. 22, 2020, 9:42 a.m. UTC
Removal is aggressive and tries to cleanup all dead code from drivers. tep_termination example still uses TUNNEL filters. Functionality is broken when TUNNEL filter is removed and finally even build of the example is broken when API is removed. It is assumed that the example will be removed before the patch series applied. v2: - cleanup testpmd user guide - try to improve descriptions a bit - remove example/tep_termination mentions from patches description - fix broken build because of unused static function left - other chagnes are documented in specific patches Andrew Rybchenko (14): ethdev: remove legacy MACVLAN filter type support ethdev: move MAC filter type to i40e driver ethdev: remove legacy EtherType filter type support ethdev: remove legacy flexible filter type support ethdev: move flexible filter type to e1000 driver ethdev: remove legacy SYN filter type support ethdev: remove legacy N-tuple filter type support ethdev: remove legacy TUNNEL filter type support ethdev: remove legacy HASH filter type support ethdev: remove legacy L2_TUNNEL filter type support ethdev: remove legacy global filter configuration support ethdev: remove legacy FDIR filter type support app/testpmd: remove command to set FDIR flexible filter mask ethdev: remove legacy filter API functions app/test-pmd/cmdline.c | 2819 +------------------ app/test-pmd/config.c | 15 +- app/test-pmd/testpmd.h | 2 + doc/guides/nics/i40e.rst | 16 +- doc/guides/rel_notes/deprecation.rst | 8 - doc/guides/rel_notes/release_20_11.rst | 3 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 461 +-- drivers/net/bnxt/bnxt_ethdev.c | 802 ------ drivers/net/dpaa2/dpaa2_ethdev.c | 4 - drivers/net/e1000/e1000_ethdev.h | 22 +- drivers/net/e1000/igb_ethdev.c | 391 +-- drivers/net/e1000/igb_flow.c | 36 +- drivers/net/enic/enic.h | 7 - drivers/net/enic/enic_clsf.c | 168 -- drivers/net/enic/enic_ethdev.c | 48 - drivers/net/hinic/hinic_pmd_ethdev.h | 1 + drivers/net/hns3/hns3_ethdev.h | 1 + drivers/net/i40e/i40e_ethdev.c | 828 +----- drivers/net/i40e/i40e_ethdev.h | 26 +- drivers/net/i40e/i40e_fdir.c | 539 ---- drivers/net/i40e/i40e_pf.c | 2 +- drivers/net/i40e/rte_pmd_i40e.c | 30 +- drivers/net/igc/igc_filter.h | 1 + drivers/net/ixgbe/ixgbe_ethdev.c | 305 +- drivers/net/ixgbe/ixgbe_ethdev.h | 2 - drivers/net/ixgbe/ixgbe_fdir.c | 220 -- drivers/net/mlx5/mlx5.h | 1 - drivers/net/mlx5/mlx5_flow.c | 516 ---- drivers/net/mlx5/mlx5_flow.h | 8 - drivers/net/qede/qede_ethdev.h | 5 - drivers/net/qede/qede_filter.c | 498 ---- drivers/net/sfc/sfc_ethdev.c | 27 - lib/librte_ethdev/rte_eth_ctrl.h | 263 +- lib/librte_ethdev/rte_ethdev.c | 28 - lib/librte_ethdev/rte_ethdev.h | 41 - lib/librte_ethdev/rte_ethdev_driver.h | 108 + lib/librte_ethdev/version.map | 2 - 37 files changed, 351 insertions(+), 7903 deletions(-)
Comments
On 10/22/2020 10:42 AM, Andrew Rybchenko wrote: > Removal is aggressive and tries to cleanup all dead code from drivers. > > tep_termination example still uses TUNNEL filters. Functionality is > broken when TUNNEL filter is removed and finally even build of the > example is broken when API is removed. It is assumed that the example > will be removed before the patch series applied. > > v2: > - cleanup testpmd user guide > - try to improve descriptions a bit > - remove example/tep_termination mentions from patches > description > - fix broken build because of unused static function left > - other chagnes are documented in specific patches > > Andrew Rybchenko (14): > ethdev: remove legacy MACVLAN filter type support > ethdev: move MAC filter type to i40e driver > ethdev: remove legacy EtherType filter type support > ethdev: remove legacy flexible filter type support > ethdev: move flexible filter type to e1000 driver > ethdev: remove legacy SYN filter type support > ethdev: remove legacy N-tuple filter type support > ethdev: remove legacy TUNNEL filter type support > ethdev: remove legacy HASH filter type support > ethdev: remove legacy L2_TUNNEL filter type support > ethdev: remove legacy global filter configuration support > ethdev: remove legacy FDIR filter type support > app/testpmd: remove command to set FDIR flexible filter mask > ethdev: remove legacy filter API functions > For series, Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> There is a dependency to tep_termination sample removal [1], after it is merged into main repo, I will proceed with this set. [1] https://patches.dpdk.org/patch/81654/
On 10/23/2020 5:03 PM, Ferruh Yigit wrote: > On 10/22/2020 10:42 AM, Andrew Rybchenko wrote: >> Removal is aggressive and tries to cleanup all dead code from drivers. >> >> tep_termination example still uses TUNNEL filters. Functionality is >> broken when TUNNEL filter is removed and finally even build of the >> example is broken when API is removed. It is assumed that the example >> will be removed before the patch series applied. >> >> v2: >> - cleanup testpmd user guide >> - try to improve descriptions a bit >> - remove example/tep_termination mentions from patches >> description >> - fix broken build because of unused static function left >> - other chagnes are documented in specific patches >> >> Andrew Rybchenko (14): >> ethdev: remove legacy MACVLAN filter type support >> ethdev: move MAC filter type to i40e driver >> ethdev: remove legacy EtherType filter type support >> ethdev: remove legacy flexible filter type support >> ethdev: move flexible filter type to e1000 driver >> ethdev: remove legacy SYN filter type support >> ethdev: remove legacy N-tuple filter type support >> ethdev: remove legacy TUNNEL filter type support >> ethdev: remove legacy HASH filter type support >> ethdev: remove legacy L2_TUNNEL filter type support >> ethdev: remove legacy global filter configuration support >> ethdev: remove legacy FDIR filter type support >> app/testpmd: remove command to set FDIR flexible filter mask >> ethdev: remove legacy filter API functions >> > > For series, > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> > Series applied to dpdk-next-net/main, thanks.