Message ID | 20201214190255.16429-1-hkalra@marvell.com (mailing list archive) |
---|---|
State | Superseded, archived |
Delegated to: | David Marchand |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD2BCA09E9; Mon, 14 Dec 2020 20:03:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DEDBBC96E; Mon, 14 Dec 2020 20:03:35 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 094E729AC; Mon, 14 Dec 2020 20:03:33 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 0BEJ09pb021107; Mon, 14 Dec 2020 11:03:32 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : content-transfer-encoding : content-type : mime-version; s=pfpt0220; bh=p5OSHS2hrX6CWjGD2rn9Vat8X784jFyjSPZQ8LyE1dQ=; b=LFVl6MPNer3ymDshXdv2RXKrOEhbMkFBsZrgq7TYeqH3l+GRnl/JDZrVEQ9GjFMM8vYW 8MkQ8iFkYkKddlYLV3fbi/2JfqJld01wWc65ROnnVdVv56olndlxkJMyC5C5z9gPD6rY NW61nkA2raVX13cvCoSb+EeavaFWqAQsuFM6nHh0gAZ5FQCQs0hXs5x7qxkPZwK/hQgJ HnkKLv3ssS8dmIiAQbkC4Sz0fuxU9JdzcSFHZb+nnfhjDJ+VYM83NEamMBVs1hi178xX bUqy/dyao3pOHBPWCDe6/YSg6KZ5WUjvP5yEBxXWC8QaGJBfONKXJn+ML/bmgawdPuCa 5g== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 35cx8t55mq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 14 Dec 2020 11:03:32 -0800 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 14 Dec 2020 11:03:30 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.102) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Mon, 14 Dec 2020 11:03:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bnlcy9GNeG3CMPG0Hyb0uANnmEWFq0F/TenR29NsyzOlCJ8qEvi/qP0Zfkyg1yEIfblAjz53yx45NLZ/5tP4DJniUD8QZDGZrF7yxO95eOeuZbrYCLT9pXLX2i/PW5d+Pve0G0uO0nhuwtBmxhsr+wh4344zJkPtLo53Y+jB6OmxkYxA26EYSUnL6/CdOeqBKFZmsBwXAJ7UPm3tZoP5QbjgNkly2PuZCQE6rz0RwGw0spw4P8XlqXiGuxwETewzPJvtl2Q8m1Z9gUGTXealwGkeNqnVD2pe/wtkWlAyHptqMcJ59X5UweR8H340a1GA4/HGzPFX4ru9fD+weyyNkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p5OSHS2hrX6CWjGD2rn9Vat8X784jFyjSPZQ8LyE1dQ=; b=n9L0AJ/susD7nMpzIf8KYzRfP16TMGF3IWE63gtyYuNweDx6saP7d5p+wibHPbh1wgOz3gxb3m2Clkv6psVqE2MpgqlRQ3cEE3CfiK5X2KoRP9XZs9FDpZwEHsutWs7zDFa88qhT3aZHt+5Sfhh2bQuEVIsVhhfc3fyCIMFgz4yHWJxtDO7vkGePj4IjEPToYLSNGr6v+8Lb0MhZPIOQNyWEoCIvGs+7LCZz4oIXp/WGhZ209C9u3rGXTH354u2jnJ0MMr7x7tN8Wjq5SKMfmPLz3JONDUqzckBjmnT/N+nCjlTebBNDBFJkX+pxViU18KE7l09bRytDuh7sR8dlgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p5OSHS2hrX6CWjGD2rn9Vat8X784jFyjSPZQ8LyE1dQ=; b=t0US/v6QpLOXp6EUqRbfB9K5LwPwbtFtqTox4vXRYh1WjTUXbaiEm3hgIamdDjkrjSnuwaxDh381aORc5mAPd6Jj8CE0L+MsJya568eJ1L11lnVAXUnXp/A9lEiIU0k625T2Yn2flU5vgR6gH8E1e94V852jnycUrBeMJA3c1pY= Authentication-Results: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=marvell.com; Received: from CO6PR18MB3842.namprd18.prod.outlook.com (2603:10b6:5:341::16) by MW2PR18MB2235.namprd18.prod.outlook.com (2603:10b6:907:e::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.14; Mon, 14 Dec 2020 19:03:29 +0000 Received: from CO6PR18MB3842.namprd18.prod.outlook.com ([fe80::444a:e47f:bdc:370c]) by CO6PR18MB3842.namprd18.prod.outlook.com ([fe80::444a:e47f:bdc:370c%7]) with mapi id 15.20.3654.025; Mon, 14 Dec 2020 19:03:28 +0000 From: Harman Kalra <hkalra@marvell.com> To: <stephen@networkplumber.org>, <rkerur@gmail.com>, <david.marchand@redhat.com>, <thomas@monjalon.net> CC: <dev@dpdk.org>, Harman Kalra <hkalra@marvell.com>, <stable@dpdk.org> Date: Tue, 15 Dec 2020 00:32:55 +0530 Message-ID: <20201214190255.16429-1-hkalra@marvell.com> X-Mailer: git-send-email 2.18.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [1.6.215.26] X-ClientProxiedBy: MAXPR01CA0077.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:49::19) To CO6PR18MB3842.namprd18.prod.outlook.com (2603:10b6:5:341::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (1.6.215.26) by MAXPR01CA0077.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:49::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12 via Frontend Transport; Mon, 14 Dec 2020 19:03:26 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3183c2c4-bcad-4bec-305e-08d8a062f162 X-MS-TrafficTypeDiagnostic: MW2PR18MB2235: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: <MW2PR18MB223578194BD5AE0491C6A89EC5C70@MW2PR18MB2235.namprd18.prod.outlook.com> X-MS-Oob-TLC-OOBClassifiers: OLM:538; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 81GKZNYZHP8L6bxW4QdIipHWhHNp4/kFZ1p4x/gQ0ghQf31S6lqnPLJ5Sw/zWPVby9NdctMS0JGrexiIKnRqJT1oyf2n+l/ksCTHBlrO9q/jeG5RaLz11LLp7ar0wCEmQbt4RpaMs/MF26RKbhkRBxCfx8aZT2yHtWnlvALq04ZjSvk/vJ19UKak3vXsfnR/3gqMt+hWzBYCAw2wOa44Wjo7wHycNKNlGUZn9Zu5VTc1I0Uzwco1yKQFR82tUtxTq7xkto3LUbThVlGnWHhLSPibIZak53oWISTj+/LDBsKP1OK3wlbLM7Mj+PLMtQQAbLJf0GxAle5YWrQVaPECJ/sr8+VZgekD0NkWQ981ihAItRzbsTwm217q6iZ0WIlpC0iN57R3E4YRzUliLrTnvm2SNufv6j/9x0m/d9jicFvqg/+ZbH+gElAcO0OXwGxq X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB3842.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(346002)(376002)(1076003)(2616005)(6486002)(34490700003)(4326008)(83380400001)(66476007)(956004)(5660300002)(16526019)(8936002)(2906002)(66946007)(6512007)(36756003)(52116002)(8676002)(4744005)(26005)(1006002)(186003)(69590400008)(86362001)(6666004)(66556008)(6506007)(508600001)(36456004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: YFjiYKluCk/dpsmDDsuGVrsQWhOLSJ7LG0jfVrP1L4WCyEuzOlynbp49f+vYHJ57KkAazhLW6YtcWDP+7x6huZLRz0hjsVxi5s+Ehh89FS4BXZqu2rxyafziwYjdZztH7GaRNIINparewnOroNzLurIuzSUDGivslmJA2Q6GuoJOSaS3wGk1XzWPMVdgyn7wX7t9XnmJ1JEIiTQfireDfKuLfKn9qdHxccDyMMbrD9uFyA81wdNcbAJdeg5RmeQsDDTe+1u5WF7MUwHuv4/EFyW5vkjTDlFa7GFvFCSANuHbhRo89j9shBTrTYuA6SwHD9nypi7NdnTVyLNSz9UKerrDhdA8mvfgeFzMS+KyCz3Ce8lgRmG4/ZKkkWw175kDwY1BqW57WG4g/blVX0yJolmbL196ZhIy9trUtoSEv1jwV7xstNHYQJYW9EBlyBW8gsiIPYBL6B9UKf82Bw0L2Z5XnP2hlp83b3PcG9JKX3jGShebX7rVLx4RC886JSjFR2VIXgF6kz5MMaBnqiFb4VOEFNiiiwWwf6zmb7lB1vdyrt1TYRfKTzSuZ6irJWWrpRO3xypnHHT26TNOEULoQqqSTR68VjbLmTc7NUydo/u/qScPsSewdC3uuaHozqzm4xN4fTQR/ku2Ln/tMjEzHw2ROVc108mJukFMUDU9le7ic4K54X9vQPseMqq3SZ6L2E3g296St8RV8zo7hxaml/xK2K5zfTffHsuVz+MgU9Wia/RrdMEcnj1ZBqP7kOaTLMo06QH8m/JneSofIV24JNGdA7jkQ5GK0zMMx9tdXUgCjkbpyDHdxs1Gy+f+7luy9nmqPCSjr5vxILyoJiMPRl+E7ZIidTqVNA5787KMBymAA1EBdIS2h41LmUu1orPRmqng7PUR3C9jD+fGx1hqVDdvGS23AgCrsGU77w6jq7LAvqYQAsuOng+SdzZ8yBMKsCLTw1V6lY2CCB9G0ximWI7AAfm0XzIpAtbU4tlkKjg= X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB3842.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2020 19:03:28.8544 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-Network-Message-Id: 3183c2c4-bcad-4bec-305e-08d8a062f162 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OQ7ZCm4olKO6649Exic3bdE5JHvtpneJDsrwBzCVRylQp+7AwmUgZju/jyPXPGKibIepN4bsktB9UAF+/yHENw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR18MB2235 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2020-12-14_10:2020-12-11, 2020-12-14 signatures=0 Subject: [dpdk-dev] [PATCH] examples/l3fwd: fix max Tx queue count X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
examples/l3fwd: fix max Tx queue count
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/iol-broadcom-Functional | success | Functional Testing PASS |
ci/iol-broadcom-Performance | success | Performance Testing PASS |
ci/iol-testing | success | Testing PASS |
ci/iol-intel-Functional | success | Functional Testing PASS |
ci/iol-intel-Performance | success | Performance Testing PASS |
ci/Intel-compilation | success | Compilation OK |
ci/travis-robot | warning | Travis build: failed |
Commit Message
Harman Kalra
Dec. 14, 2020, 7:02 p.m. UTC
In l3fwd no of transmit queues is calculated based on no of
lcores with which it is launched. Hence maximum no of tx
queues possible per port should depend on RTE_MAX_LCORE value.
Fixes: 268888b5b020 ("examples/l3fwd: modularize")
Cc: stable@dpdk.org
Signed-off-by: Harman Kalra <hkalra@marvell.com>
---
examples/l3fwd/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Ping... On Tue, Dec 15, 2020 at 12:32:55AM +0530, Harman Kalra wrote: > In l3fwd no of transmit queues is calculated based on no of > lcores with which it is launched. Hence maximum no of tx > queues possible per port should depend on RTE_MAX_LCORE value. > > Fixes: 268888b5b020 ("examples/l3fwd: modularize") > Cc: stable@dpdk.org > > Signed-off-by: Harman Kalra <hkalra@marvell.com> > --- > examples/l3fwd/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c > index d62dec434..bb49e5faf 100644 > --- a/examples/l3fwd/main.c > +++ b/examples/l3fwd/main.c > @@ -48,7 +48,7 @@ > #include "l3fwd.h" > #include "l3fwd_event.h" > > -#define MAX_TX_QUEUE_PER_PORT RTE_MAX_ETHPORTS > +#define MAX_TX_QUEUE_PER_PORT RTE_MAX_LCORE > #define MAX_RX_QUEUE_PER_PORT 128 > > #define MAX_LCORE_PARAMS 1024 > -- > 2.18.0 >
On Mon, Dec 14, 2020 at 8:03 PM Harman Kalra <hkalra@marvell.com> wrote: > > In l3fwd no of transmit queues is calculated based on no of > lcores with which it is launched. Hence maximum no of tx > queues possible per port should depend on RTE_MAX_LCORE value. For the title, we are not "fixing" the Tx queue count. WDYT of: examples/l3fwd: remove limitation on Tx queue count > > Fixes: 268888b5b020 ("examples/l3fwd: modularize") This commit simply moves code around, so it is unlikely to be the origin. Afaiu, this behavior has been present since the start. I'd rather flag Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org > > Signed-off-by: Harman Kalra <hkalra@marvell.com> > --- > examples/l3fwd/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c > index d62dec434..bb49e5faf 100644 > --- a/examples/l3fwd/main.c > +++ b/examples/l3fwd/main.c > @@ -48,7 +48,7 @@ > #include "l3fwd.h" > #include "l3fwd_event.h" > > -#define MAX_TX_QUEUE_PER_PORT RTE_MAX_ETHPORTS > +#define MAX_TX_QUEUE_PER_PORT RTE_MAX_LCORE > #define MAX_RX_QUEUE_PER_PORT 128 > > #define MAX_LCORE_PARAMS 1024 Later in the code, the associated check on nb_lcores > RTE_MAX_LCORE does not make much sense. But keeping this MAX_TX_QUEUE_PER_PORT macro is a way to document how the txq are allocated. So this change lgtm. Reviewed-by: David Marchand <david.marchand@redhat.com> -- David Marchand
On Tue, Jan 12, 2021 at 09:58:06AM +0100, David Marchand wrote: > External Email > > ---------------------------------------------------------------------- > On Mon, Dec 14, 2020 at 8:03 PM Harman Kalra <hkalra@marvell.com> wrote: > > > > In l3fwd no of transmit queues is calculated based on no of > > lcores with which it is launched. Hence maximum no of tx > > queues possible per port should depend on RTE_MAX_LCORE value. > > For the title, we are not "fixing" the Tx queue count. > WDYT of: > examples/l3fwd: remove limitation on Tx queue count Hi David Thanks for reviewing, I will push V2 with the required changes. > > > > > Fixes: 268888b5b020 ("examples/l3fwd: modularize") > > This commit simply moves code around, so it is unlikely to be the origin. > Afaiu, this behavior has been present since the start. > I'd rather flag > > Fixes: af75078fece3 ("first public release") > > > Cc: stable@dpdk.org > > > > Signed-off-by: Harman Kalra <hkalra@marvell.com> > > --- > > examples/l3fwd/main.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c > > index d62dec434..bb49e5faf 100644 > > --- a/examples/l3fwd/main.c > > +++ b/examples/l3fwd/main.c > > @@ -48,7 +48,7 @@ > > #include "l3fwd.h" > > #include "l3fwd_event.h" > > > > -#define MAX_TX_QUEUE_PER_PORT RTE_MAX_ETHPORTS > > +#define MAX_TX_QUEUE_PER_PORT RTE_MAX_LCORE > > #define MAX_RX_QUEUE_PER_PORT 128 > > > > #define MAX_LCORE_PARAMS 1024 > > Later in the code, the associated check on nb_lcores > RTE_MAX_LCORE > does not make much sense. > But keeping this MAX_TX_QUEUE_PER_PORT macro is a way to document how > the txq are allocated. > So this change lgtm. > > Reviewed-by: David Marchand <david.marchand@redhat.com> > > > -- > David Marchand >
diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c index d62dec434..bb49e5faf 100644 --- a/examples/l3fwd/main.c +++ b/examples/l3fwd/main.c @@ -48,7 +48,7 @@ #include "l3fwd.h" #include "l3fwd_event.h" -#define MAX_TX_QUEUE_PER_PORT RTE_MAX_ETHPORTS +#define MAX_TX_QUEUE_PER_PORT RTE_MAX_LCORE #define MAX_RX_QUEUE_PER_PORT 128 #define MAX_LCORE_PARAMS 1024