[PATCH-V6] config/arm: restore support for Qualcomm servers
Checks
Commit Message
From the documentation:
"The SoC configuration is a combination of implementer and CPU part number
configuration and SoC-specific configuration."
Align Qualcomm SoC configuration with the configuration of other server
SoCs (eMAG, Kunpeng 9x0): add a soc configuration to the existing
implementer configuration.
Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
--
V6:
- rebase after merge of "doc: fix Arm SoCs list"
V5:
- rebase after http://patches.dpdk.org/project/dpdk/patch/20210429070751.6065-1-david.marchand@redhat.com/
V4:
- use a more specific SoC name
V3:
- include doc patch
- remove Fixes line
V2:
- use the right original commit in Fixes
---
config/arm/meson.build | 9 +++++++++
1 file changed, 9 insertions(+)
Comments
> -----Original Message-----
> From: Thierry Herbelot <thierry.herbelot@6wind.com>
> Sent: Thursday, May 6, 2021 5:26 PM
> To: dev@dpdk.org
> Cc: Thierry Herbelot <thierry.herbelot@6wind.com>; thomas@monjalon.net;
> Juraj Linkeš <juraj.linkes@pantheon.tech>; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>
> Subject: [PATCH-V6] config/arm: restore support for Qualcomm servers
>
> From the documentation:
> "The SoC configuration is a combination of implementer and CPU part
> number configuration and SoC-specific configuration."
>
> Align Qualcomm SoC configuration with the configuration of other server
> SoCs (eMAG, Kunpeng 9x0): add a soc configuration to the existing
> implementer configuration.
>
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> --
> V6:
> - rebase after merge of "doc: fix Arm SoCs list"
> V5:
> - rebase after
> http://patches.dpdk.org/project/dpdk/patch/20210429070751.6065-1-
> david.marchand@redhat.com/
> V4:
> - use a more specific SoC name
> V3:
> - include doc patch
> - remove Fixes line
> V2:
> - use the right original commit in Fixes
> ---
> config/arm/meson.build | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/config/arm/meson.build b/config/arm/meson.build index
> 65f7ac672def..c68ea24f312f 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -223,6 +223,13 @@ soc_bluefield = {
> 'numa': false
> }
>
> +soc_centriq2400 = {
> + 'description': 'Qualcomm Centriq 2400',
> + 'implementer': '0x51',
> + 'part_number': '0xc00',
> + 'numa': false
> +}
> +
> soc_cn10k = {
> 'description' : 'Marvell OCTEON 10',
> 'implementer' : '0x41',
> @@ -326,6 +333,7 @@ Start of socs list
> generic: Generic un-optimized build for all aarch64 machines.
> armada: Marvell ARMADA
> bluefield: NVIDIA BlueField
> +centriq2400: Qualcomm Centriq 2400
> cn10k: Marvell OCTEON 10
> dpaa: NXP DPAA
> emag: Ampere eMAG
> @@ -346,6 +354,7 @@ socs = {
> 'generic': soc_generic,
> 'armada': soc_armada,
> 'bluefield': soc_bluefield,
> + 'centriq2400': soc_centriq2400,
> 'cn10k' : soc_cn10k,
> 'dpaa': soc_dpaa,
> 'emag': soc_emag,
> --
> 2.29.2
I believe a meson cross file is also needed. The cross file consumes defined soc info.
Please check other cross files in config/arm for reference.
> -----Original Message-----
> From: Ruifeng Wang <Ruifeng.Wang@arm.com>
> Sent: Friday, May 7, 2021 9:23 AM
> To: Thierry Herbelot <thierry.herbelot@6wind.com>; dev@dpdk.org
> Cc: thomas@monjalon.net; Juraj Linkeš <juraj.linkes@pantheon.tech>;
> Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>; nd <nd@arm.com>
> Subject: RE: [PATCH-V6] config/arm: restore support for Qualcomm servers
>
In addition to Ruifeng's cross file addition, I'd also change the subject to something like "config/arm: add Qualcomm Centriq 2400 SoC config" which is more accurate (add instead of restore and the patch only adds support for one server, not multiple).
> I believe a meson cross file is also needed. The cross file consumes defined soc
> info.
> Please check other cross files in config/arm for reference.
@@ -223,6 +223,13 @@ soc_bluefield = {
'numa': false
}
+soc_centriq2400 = {
+ 'description': 'Qualcomm Centriq 2400',
+ 'implementer': '0x51',
+ 'part_number': '0xc00',
+ 'numa': false
+}
+
soc_cn10k = {
'description' : 'Marvell OCTEON 10',
'implementer' : '0x41',
@@ -326,6 +333,7 @@ Start of socs list
generic: Generic un-optimized build for all aarch64 machines.
armada: Marvell ARMADA
bluefield: NVIDIA BlueField
+centriq2400: Qualcomm Centriq 2400
cn10k: Marvell OCTEON 10
dpaa: NXP DPAA
emag: Ampere eMAG
@@ -346,6 +354,7 @@ socs = {
'generic': soc_generic,
'armada': soc_armada,
'bluefield': soc_bluefield,
+ 'centriq2400': soc_centriq2400,
'cn10k' : soc_cn10k,
'dpaa': soc_dpaa,
'emag': soc_emag,