Message ID | 20210607175943.31690-3-ndabilpuram@marvell.com (mailing list archive) |
---|---|
State | Changes Requested, archived |
Delegated to: | Jerin Jacob |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B1B2A034F; Mon, 7 Jun 2021 20:03:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4247A410EC; Mon, 7 Jun 2021 20:03:07 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 565D9410F4 for <dev@dpdk.org>; Mon, 7 Jun 2021 20:03:05 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 157I1av5017507 for <dev@dpdk.org>; Mon, 7 Jun 2021 11:03:04 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=pfpt0220; bh=EIVbhsaYmOjShd6STyXk6L/umIzheBB6vhgA2naTmYA=; b=bwEdXthLi+h7iHlXsaG/rs5Qqnj4Cyko7XXk9o5RkVlL95jNTrsQaAaxeGrgG36ijEUR QFIjf+nqgQxxZHEsg4gTSCp9LHmU7UX+uImVgsL8tF+6AfCdS54kNiq+fxVD4R2J2IEA pNuj7SrZM4rJkifaVYXKwAersVSwcNzVkB3SH1NJvImJQfqLXUw+hiDsbidnR0pnr7VV CTlLIVYd1AO7aspp5d+5vxxC+EZ/MAWoPkFg9fPtVP9WK/uX27es+IrNbyFoW3ZkMqVl Makl/W312+OoubXRSRdOLjB3gO/A2mafSCrr47V+17186EpKh5YphsNc1C3xMeAa7xez pg== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0b-0016f401.pphosted.com with ESMTP id 391ecv2e7s-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for <dev@dpdk.org>; Mon, 07 Jun 2021 11:03:04 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 7 Jun 2021 11:03:03 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 7 Jun 2021 11:03:02 -0700 Received: from hyd1588t430.marvell.com (unknown [10.29.52.204]) by maili.marvell.com (Postfix) with ESMTP id 217EF3F7043; Mon, 7 Jun 2021 11:02:59 -0700 (PDT) From: Nithin Dabilpuram <ndabilpuram@marvell.com> To: <dev@dpdk.org> CC: <jerinj@marvell.com>, <skori@marvell.com>, <skoteshwar@marvell.com>, <pbhagavatula@marvell.com>, <kirankumark@marvell.com>, <psatheesh@marvell.com>, <asekhar@marvell.com>, Srujana Challa <schalla@marvell.com> Date: Mon, 7 Jun 2021 23:28:43 +0530 Message-ID: <20210607175943.31690-3-ndabilpuram@marvell.com> X-Mailer: git-send-email 2.8.4 In-Reply-To: <20210607175943.31690-1-ndabilpuram@marvell.com> References: <20210306153404.10781-1-ndabilpuram@marvell.com> <20210607175943.31690-1-ndabilpuram@marvell.com> MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-GUID: xpSggOQqRo2coAFOpoKjwBJ_ftUjr-PB X-Proofpoint-ORIG-GUID: xpSggOQqRo2coAFOpoKjwBJ_ftUjr-PB X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-06-07_14:2021-06-04, 2021-06-07 signatures=0 Subject: [dpdk-dev] [PATCH v2 02/62] common/cnxk: update Rx inline IPsec mbox message format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
Marvell CNXK Ethdev Driver
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
Commit Message
Nithin Dabilpuram
June 7, 2021, 5:58 p.m. UTC
From: Srujana Challa <schalla@marvell.com> Updates Rx inline IPSEC mailbox message format to make it sync with latest CPT PF driver. Signed-off-by: Srujana Challa <schalla@marvell.com> --- drivers/common/cnxk/roc_mbox.h | 3 +++ 1 file changed, 3 insertions(+)
Comments
On 6/7/21 8:58 PM, Nithin Dabilpuram wrote: > From: Srujana Challa <schalla@marvell.com> > > Updates Rx inline IPSEC mailbox message format to make it > sync with latest CPT PF driver. > > Signed-off-by: Srujana Challa <schalla@marvell.com> > --- > drivers/common/cnxk/roc_mbox.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/common/cnxk/roc_mbox.h b/drivers/common/cnxk/roc_mbox.h > index f6b11b6..fe4df21 100644 > --- a/drivers/common/cnxk/roc_mbox.h > +++ b/drivers/common/cnxk/roc_mbox.h > @@ -1328,6 +1328,9 @@ struct cpt_rxc_time_cfg_req { > struct cpt_rx_inline_lf_cfg_msg { > struct mbox_msghdr hdr; > uint16_t __io sso_pf_func; > + uint16_t __io param1; > + uint16_t __io param2; > + uint16_t __io reserved; > }; > > enum cpt_eng_type { > Isn't is a dead code? May be it should be added when it is actually used?
On Tue, Jun 08, 2021 at 03:26:08PM +0300, Andrew Rybchenko wrote: > On 6/7/21 8:58 PM, Nithin Dabilpuram wrote: > > From: Srujana Challa <schalla@marvell.com> > > > > Updates Rx inline IPSEC mailbox message format to make it > > sync with latest CPT PF driver. > > > > Signed-off-by: Srujana Challa <schalla@marvell.com> > > --- > > drivers/common/cnxk/roc_mbox.h | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/common/cnxk/roc_mbox.h b/drivers/common/cnxk/roc_mbox.h > > index f6b11b6..fe4df21 100644 > > --- a/drivers/common/cnxk/roc_mbox.h > > +++ b/drivers/common/cnxk/roc_mbox.h > > @@ -1328,6 +1328,9 @@ struct cpt_rxc_time_cfg_req { > > struct cpt_rx_inline_lf_cfg_msg { > > struct mbox_msghdr hdr; > > uint16_t __io sso_pf_func; > > + uint16_t __io param1; > > + uint16_t __io param2; > > + uint16_t __io reserved; > > }; > > > > enum cpt_eng_type { > > > > Isn't is a dead code? > May be it should be added when it is actually used? This patch is just a sync of this data structure b/w Kernel and Userspace used for mbox communication. It is already used to generate mbox message request response API's via and drivers/common/cnxk/roc_mbox_priv.h:158 for all mbox messages. Since it is common code and just a datastructure update to be in sync with kernel, isn't it fine ?
On Mon, Jun 7, 2021 at 11:33 PM Nithin Dabilpuram <ndabilpuram@marvell.com> wrote: > > From: Srujana Challa <schalla@marvell.com> > > Updates Rx inline IPSEC mailbox message format to make it > sync with latest CPT PF driver. > > Signed-off-by: Srujana Challa <schalla@marvell.com> > --- > drivers/common/cnxk/roc_mbox.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/common/cnxk/roc_mbox.h b/drivers/common/cnxk/roc_mbox.h > index f6b11b6..fe4df21 100644 > --- a/drivers/common/cnxk/roc_mbox.h > +++ b/drivers/common/cnxk/roc_mbox.h > @@ -1328,6 +1328,9 @@ struct cpt_rxc_time_cfg_req { > struct cpt_rx_inline_lf_cfg_msg { > struct mbox_msghdr hdr; > uint16_t __io sso_pf_func; > + uint16_t __io param1; > + uint16_t __io param2; > + uint16_t __io reserved; Items like 3 lines changes, Please squash to some other patches in the series. > }; > > enum cpt_eng_type { > -- > 2.8.4 >
diff --git a/drivers/common/cnxk/roc_mbox.h b/drivers/common/cnxk/roc_mbox.h index f6b11b6..fe4df21 100644 --- a/drivers/common/cnxk/roc_mbox.h +++ b/drivers/common/cnxk/roc_mbox.h @@ -1328,6 +1328,9 @@ struct cpt_rxc_time_cfg_req { struct cpt_rx_inline_lf_cfg_msg { struct mbox_msghdr hdr; uint16_t __io sso_pf_func; + uint16_t __io param1; + uint16_t __io param2; + uint16_t __io reserved; }; enum cpt_eng_type {