diff mbox series

[v4,2/2] config/arm: make n2 'crypto' an optional feature

Message ID 1629197810-26453-2-git-send-email-juraj.linkes@pantheon.tech (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v4,1/2] config/arm: split march cfg into arch and features |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot: build success github build: passed
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-spell-check-testing success Testing PASS
ci/iol-aarch64-unit-testing fail Testing issues
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS

Commit Message

Juraj Linkeš Aug. 17, 2021, 10:56 a.m. UTC 
  Not all Neoverse-N2 cpus must support the crypto feature/extension which
makes it an optional feature. Only enable the feature for SoCs which
support it.

Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
---
v4: rebase
---
 config/arm/meson.build | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Ruifeng Wang Sept. 6, 2021, 8:38 a.m. UTC | #1 
> -----Original Message-----
> From: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Sent: Tuesday, August 17, 2021 6:57 PM
> To: thomas@monjalon.net; david.marchand@redhat.com;
> bruce.richardson@intel.com; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>; fengchengwen@huawei.com;
> ferruh.yigit@intel.com; jerinjacobk@gmail.com; jerinj@marvell.com;
> pbhagavatula@marvell.com
> Cc: dev@dpdk.org; Juraj Linkeš <juraj.linkes@pantheon.tech>
> Subject: [PATCH v4 2/2] config/arm: make n2 'crypto' an optional feature
> 
> Not all Neoverse-N2 cpus must support the crypto feature/extension which
> makes it an optional feature. Only enable the feature for SoCs which support
> it.
> 
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> ---
> v4: rebase
> ---
>  config/arm/meson.build | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/config/arm/meson.build b/config/arm/meson.build index
> c11efa1583..c9bcd089df 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -76,7 +76,7 @@ part_number_config_arm = {
>      },
>      '0xd49': {
>          'march': 'armv8.5-a',
> -        'march_features': ['crypto', 'sve2'],
> +        'march_features': ['sve2'],
>          'flags': [
>              ['RTE_MACHINE', '"neoverse-n2"'],
>              ['RTE_ARM_FEATURE_ATOMICS', true], @@ -278,6 +278,7 @@
> soc_cn10k = {
>          ['RTE_MAX_NUMA_NODES', 1]
>      ],
>      'part_number': '0xd49',
> +    'extra_march_features': ['crypto'],
>      'numa': false
>  }
> 
> --
> 2.20.1

Yes, 'crypto' is an optional extension. N2 has this extension enabled, and there could be variants without crypto extension.
Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>
diff mbox series

Patch

diff --git a/config/arm/meson.build b/config/arm/meson.build
index c11efa1583..c9bcd089df 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -76,7 +76,7 @@  part_number_config_arm = {
     },
     '0xd49': {
         'march': 'armv8.5-a',
-        'march_features': ['crypto', 'sve2'],
+        'march_features': ['sve2'],
         'flags': [
             ['RTE_MACHINE', '"neoverse-n2"'],
             ['RTE_ARM_FEATURE_ATOMICS', true],
@@ -278,6 +278,7 @@  soc_cn10k = {
         ['RTE_MAX_NUMA_NODES', 1]
     ],
     'part_number': '0xd49',
+    'extra_march_features': ['crypto'],
     'numa': false
 }