[3/4] security: hide internal API

Message ID 20210731181327.660296-4-gakhil@marvell.com (mailing list archive)
State Superseded, archived
Delegated to: akhil goyal
Headers
Series cryptodev and security ABI improvements |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Akhil Goyal July 31, 2021, 6:13 p.m. UTC
  rte_security_dynfield_register() is an internal
API to be used by the driver, hence moving it to internal.

Signed-off-by: Akhil Goyal <gakhil@marvell.com>
---
 lib/security/rte_security_driver.h | 2 +-
 lib/security/version.map           | 7 ++++++-
 2 files changed, 7 insertions(+), 2 deletions(-)
  

Comments

Ananyev, Konstantin Sept. 15, 2021, 3:54 p.m. UTC | #1
> rte_security_dynfield_register() is an internal
> API to be used by the driver, hence moving it to internal.
> 
> Signed-off-by: Akhil Goyal <gakhil@marvell.com>
> ---
>  lib/security/rte_security_driver.h | 2 +-
>  lib/security/version.map           | 7 ++++++-
>  2 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/security/rte_security_driver.h b/lib/security/rte_security_driver.h
> index 938373205c..b0253e962e 100644
> --- a/lib/security/rte_security_driver.h
> +++ b/lib/security/rte_security_driver.h
> @@ -89,7 +89,7 @@ typedef int (*security_session_stats_get_t)(void *device,
>  		struct rte_security_session *sess,
>  		struct rte_security_stats *stats);
> 
> -__rte_experimental
> +__rte_internal
>  int rte_security_dynfield_register(void);
> 
>  /**
> diff --git a/lib/security/version.map b/lib/security/version.map
> index 22775558c8..bd91d9a16c 100644
> --- a/lib/security/version.map
> +++ b/lib/security/version.map
> @@ -16,8 +16,13 @@ EXPERIMENTAL {
>  	global:
> 
>  	rte_security_dynfield_offset;
> -	rte_security_dynfield_register;
>  	rte_security_get_userdata;
>  	rte_security_session_stats_get;
>  	rte_security_session_update;
>  };
> +
> +INTERNAL {
> +	global:
> +
> +	rte_security_dynfield_register;
> +};
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

> 2.25.1
  

Patch

diff --git a/lib/security/rte_security_driver.h b/lib/security/rte_security_driver.h
index 938373205c..b0253e962e 100644
--- a/lib/security/rte_security_driver.h
+++ b/lib/security/rte_security_driver.h
@@ -89,7 +89,7 @@  typedef int (*security_session_stats_get_t)(void *device,
 		struct rte_security_session *sess,
 		struct rte_security_stats *stats);
 
-__rte_experimental
+__rte_internal
 int rte_security_dynfield_register(void);
 
 /**
diff --git a/lib/security/version.map b/lib/security/version.map
index 22775558c8..bd91d9a16c 100644
--- a/lib/security/version.map
+++ b/lib/security/version.map
@@ -16,8 +16,13 @@  EXPERIMENTAL {
 	global:
 
 	rte_security_dynfield_offset;
-	rte_security_dynfield_register;
 	rte_security_get_userdata;
 	rte_security_session_stats_get;
 	rte_security_session_update;
 };
+
+INTERNAL {
+	global:
+
+	rte_security_dynfield_register;
+};