[v4,11/11] devbind: move ioat device ID for ICX to dmadev category
Checks
Commit Message
Move Intel IOAT devices on Ice Lake systems from Misc to DMA devices.
Signed-off-by: Conor Walsh <conor.walsh@intel.com>
Reviewed-by: Kevin Laatz <kevin.laatz@intel.com>
---
usertools/dpdk-devbind.py | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
Comments
On Fri, Sep 17, 2021 at 03:42:27PM +0000, Conor Walsh wrote:
> Move Intel IOAT devices on Ice Lake systems from Misc to DMA devices.
>
> Signed-off-by: Conor Walsh <conor.walsh@intel.com>
> Reviewed-by: Kevin Laatz <kevin.laatz@intel.com>
> ---
> usertools/dpdk-devbind.py | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
> index 98b698ccc0..afebc8cb62 100755
> --- a/usertools/dpdk-devbind.py
> +++ b/usertools/dpdk-devbind.py
> @@ -69,14 +69,13 @@
> network_devices = [network_class, cavium_pkx, avp_vnic, ifpga_class]
> baseband_devices = [acceleration_class]
> crypto_devices = [encryption_class, intel_processor_class]
> -dma_devices = [intel_idxd_spr]
> +dma_devices = [intel_idxd_spr, intel_ioat_icx]
> eventdev_devices = [cavium_sso, cavium_tim, intel_dlb, octeontx2_sso]
> mempool_devices = [cavium_fpa, octeontx2_npa]
> compress_devices = [cavium_zip]
> regex_devices = [octeontx2_ree]
> misc_devices = [cnxk_bphy, cnxk_bphy_cgx, intel_ioat_bdw, intel_ioat_skx,
> - intel_ioat_icx, intel_ntb_skx, intel_ntb_icx,
> - octeontx2_dma]
> + intel_ntb_skx, intel_ntb_icx, octeontx2_dma]
>
I think the ioat_bdw and ioat_skx elements should also go down as DMA
devices.
With that change:
Reviewed-by: Bruce Richardson <bruce.richardson@intel.com>
> On Fri, Sep 17, 2021 at 03:42:27PM +0000, Conor Walsh wrote:
>> Move Intel IOAT devices on Ice Lake systems from Misc to DMA devices.
>>
>> Signed-off-by: Conor Walsh <conor.walsh@intel.com>
>> Reviewed-by: Kevin Laatz <kevin.laatz@intel.com>
>> ---
>> usertools/dpdk-devbind.py | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
>> index 98b698ccc0..afebc8cb62 100755
>> --- a/usertools/dpdk-devbind.py
>> +++ b/usertools/dpdk-devbind.py
>> @@ -69,14 +69,13 @@
>> network_devices = [network_class, cavium_pkx, avp_vnic, ifpga_class]
>> baseband_devices = [acceleration_class]
>> crypto_devices = [encryption_class, intel_processor_class]
>> -dma_devices = [intel_idxd_spr]
>> +dma_devices = [intel_idxd_spr, intel_ioat_icx]
>> eventdev_devices = [cavium_sso, cavium_tim, intel_dlb, octeontx2_sso]
>> mempool_devices = [cavium_fpa, octeontx2_npa]
>> compress_devices = [cavium_zip]
>> regex_devices = [octeontx2_ree]
>> misc_devices = [cnxk_bphy, cnxk_bphy_cgx, intel_ioat_bdw, intel_ioat_skx,
>> - intel_ioat_icx, intel_ntb_skx, intel_ntb_icx,
>> - octeontx2_dma]
>> + intel_ntb_skx, intel_ntb_icx, octeontx2_dma]
>>
> I think the ioat_bdw and ioat_skx elements should also go down as DMA
> devices.
>
> With that change:
>
> Reviewed-by: Bruce Richardson <bruce.richardson@intel.com>
I will change this in v5 and deprecate the rawdev IOAT driver.
Thanks for the review Bruce,
Conor.
@@ -69,14 +69,13 @@
network_devices = [network_class, cavium_pkx, avp_vnic, ifpga_class]
baseband_devices = [acceleration_class]
crypto_devices = [encryption_class, intel_processor_class]
-dma_devices = [intel_idxd_spr]
+dma_devices = [intel_idxd_spr, intel_ioat_icx]
eventdev_devices = [cavium_sso, cavium_tim, intel_dlb, octeontx2_sso]
mempool_devices = [cavium_fpa, octeontx2_npa]
compress_devices = [cavium_zip]
regex_devices = [octeontx2_ree]
misc_devices = [cnxk_bphy, cnxk_bphy_cgx, intel_ioat_bdw, intel_ioat_skx,
- intel_ioat_icx, intel_ntb_skx, intel_ntb_icx,
- octeontx2_dma]
+ intel_ntb_skx, intel_ntb_icx, octeontx2_dma]
# global dict ethernet devices present. Dictionary indexed by PCI address.
# Each device within this is itself a dictionary of device properties