net/cxgbe: remove useless address check
Checks
Commit Message
reported by "gcc (GCC) 12.0.0 20211003 (experimental)":
../drivers/net/cxgbe/cxgbe_ethdev.c:
In function ‘cxgbe_dev_rx_queue_setup’:
../drivers/net/cxgbe/cxgbe_ethdev.c:682:24:
error: the comparison will always evaluate as ‘true’ for the
address of ‘fl’ will never be NULL [-Werror=address]
682 | if ((&rxq->fl) != NULL)
| ^~
Fixing it by removing useless check.
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
drivers/net/cxgbe/cxgbe_ethdev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Comments
On Monday, October 10/04/21, 2021 at 18:27:54 +0100, Ferruh Yigit wrote:
> reported by "gcc (GCC) 12.0.0 20211003 (experimental)":
>
> ../drivers/net/cxgbe/cxgbe_ethdev.c:
> In function ‘cxgbe_dev_rx_queue_setup’:
> ../drivers/net/cxgbe/cxgbe_ethdev.c:682:24:
> error: the comparison will always evaluate as ‘true’ for the
> address of ‘fl’ will never be NULL [-Werror=address]
> 682 | if ((&rxq->fl) != NULL)
> | ^~
>
> Fixing it by removing useless check.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Looks good. Thanks for fixing it up.
Reviewed-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
On 10/4/2021 8:32 PM, Rahul Lakkireddy wrote:
> On Monday, October 10/04/21, 2021 at 18:27:54 +0100, Ferruh Yigit wrote:
>> reported by "gcc (GCC) 12.0.0 20211003 (experimental)":
>>
>> ../drivers/net/cxgbe/cxgbe_ethdev.c:
>> In function ‘cxgbe_dev_rx_queue_setup’:
>> ../drivers/net/cxgbe/cxgbe_ethdev.c:682:24:
>> error: the comparison will always evaluate as ‘true’ for the
>> address of ‘fl’ will never be NULL [-Werror=address]
>> 682 | if ((&rxq->fl) != NULL)
>> | ^~
>>
>> Fixing it by removing useless check.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Looks good. Thanks for fixing it up.
>
> Reviewed-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
>
Applied to dpdk-next-net/main, thanks.
@@ -679,8 +679,7 @@ int cxgbe_dev_rx_queue_setup(struct rte_eth_dev *eth_dev,
}
rxq->rspq.size = temp_nb_desc;
- if ((&rxq->fl) != NULL)
- rxq->fl.size = temp_nb_desc;
+ rxq->fl.size = temp_nb_desc;
/* Set to jumbo mode if necessary */
if (pkt_len > CXGBE_ETH_MAX_LEN)