[v2,5/5] doc: remove modify field action data deprecation notice

Message ID 20211010234547.1495-6-viacheslavo@nvidia.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers
Series ethdev: update modify field flow action |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-spell-check-testing warning Testing issues
ci/github-robot: build success github build: passed
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Performance fail Performance Testing issues
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS

Commit Message

Slava Ovsiienko Oct. 10, 2021, 11:45 p.m. UTC
  The generic modify field flow action introduced
is updated, deprecation notice should be removed.

Fixes: 2ba49b5f3721 ("doc: announce change to ethdev modify action data")

Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
 doc/guides/rel_notes/deprecation.rst | 4 ----
 1 file changed, 4 deletions(-)
  

Comments

Ori Kam Oct. 11, 2021, 9:14 a.m. UTC | #1
Hi Slava,

> -----Original Message-----
> From: Slava Ovsiienko <viacheslavo@nvidia.com>
> Sent: Monday, October 11, 2021 2:46 AM
> Subject: [PATCH v2 5/5] doc: remove modify field action data deprecation notice
> 
> The generic modify field flow action introduced is updated, deprecation notice should be removed.
> 
> Fixes: 2ba49b5f3721 ("doc: announce change to ethdev modify action data")
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index a2fe766d4b..dee14077a5 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -120,10 +120,6 @@ Deprecation Notices
>  * ethdev: Announce moving from dedicated modify function for each field,
>    to using the general ``rte_flow_modify_field`` action.
> 
> -* ethdev: The struct ``rte_flow_action_modify_data`` will be modified
> -  to support modifying fields larger than 64 bits.
> -  In addition, documentation will be updated to clarify byte order.
> -
>  * ethdev: Attribute ``shared`` of the ``struct rte_flow_action_count``
>    is deprecated and will be removed in DPDK 21.11. Shared counters should
>    be managed using shared actions API (``rte_flow_shared_action_create`` etc).
> --
> 2.18.1

Acked-by: Ori Kam <orika@nvidia.com>
Thanks,
Ori
  
Andrew Rybchenko Oct. 11, 2021, 9:31 a.m. UTC | #2
On 10/11/21 2:45 AM, Viacheslav Ovsiienko wrote:
> The generic modify field flow action introduced
> is updated, deprecation notice should be removed.
> 
> Fixes: 2ba49b5f3721 ("doc: announce change to ethdev modify action data")
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>

It should be done when deprecation notice is addressed.
I.e. in the first patch of the series.
  

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index a2fe766d4b..dee14077a5 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -120,10 +120,6 @@  Deprecation Notices
 * ethdev: Announce moving from dedicated modify function for each field,
   to using the general ``rte_flow_modify_field`` action.
 
-* ethdev: The struct ``rte_flow_action_modify_data`` will be modified
-  to support modifying fields larger than 64 bits.
-  In addition, documentation will be updated to clarify byte order.
-
 * ethdev: Attribute ``shared`` of the ``struct rte_flow_action_count``
   is deprecated and will be removed in DPDK 21.11. Shared counters should
   be managed using shared actions API (``rte_flow_shared_action_create`` etc).