[V3] tests/iavf_fdir_gtpogre: update negative case for dpdk code change

Message ID 1634717688-224305-1-git-send-email-songx.jiale@intel.com (mailing list archive)
State Accepted
Headers
Series [V3] tests/iavf_fdir_gtpogre: update negative case for dpdk code change |

Checks

Context Check Description
ci/Intel-dts-doc-test success Testing OK
ci/Intel-dts-suite-test warning SKIPPED

Commit Message

Jiale, SongX Oct. 20, 2021, 8:14 a.m. UTC
  when dpdk fixed a gtpogre bug, the code design changed, so some rules can be created successfully
now, these rules should be deleted from the negative case

Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
 test_plans/iavf_fdir_gtpogre_test_plan.rst | 2 --
 tests/TestSuite_iavf_fdir_gtpogre.py       | 1 -
 2 files changed, 3 deletions(-)
 mode change 100644 => 100755 tests/TestSuite_iavf_fdir_gtpogre.py
  

Comments

Huang, ZhiminX Oct. 20, 2021, 9:49 a.m. UTC | #1
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Jiale Song
> Sent: Wednesday, October 20, 2021 4:15 PM
> To: dts@dpdk.org
> Cc: Jiale, SongX <songx.jiale@intel.com>
> Subject: [dts] [PATCH V3] tests/iavf_fdir_gtpogre: update negative case for
> dpdk code change
> 
> when dpdk fixed a gtpogre bug, the code design changed, so some rules can be
> created successfully now, these rules should be deleted from the negative case
> 
> Signed-off-by: Jiale Song <songx.jiale@intel.com>
> ---
Add dpdk code changed commit: 16b8e92d49b87705fffbedd9c3241204d9a584a6
  
Tu, Lijuan Oct. 25, 2021, 7:52 a.m. UTC | #2
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Huang, ZhiminX
> Sent: 2021年10月20日 17:50
> To: dts@dpdk.org
> Cc: Jiale, SongX <songx.jiale@intel.com>
> Subject: Re: [dts] [PATCH V3] tests/iavf_fdir_gtpogre: update negative case for
> dpdk code change
> 
> > -----Original Message-----
> > From: dts <dts-bounces@dpdk.org> On Behalf Of Jiale Song
> > Sent: Wednesday, October 20, 2021 4:15 PM
> > To: dts@dpdk.org
> > Cc: Jiale, SongX <songx.jiale@intel.com>
> > Subject: [dts] [PATCH V3] tests/iavf_fdir_gtpogre: update negative
> > case for dpdk code change
> >
> > when dpdk fixed a gtpogre bug, the code design changed, so some rules
> > can be created successfully now, these rules should be deleted from
> > the negative case
> >
> > Signed-off-by: Jiale Song <songx.jiale@intel.com>
> > ---
> Add dpdk code changed commit:
> 16b8e92d49b87705fffbedd9c3241204d9a584a6

applied
  

Patch

diff --git a/test_plans/iavf_fdir_gtpogre_test_plan.rst b/test_plans/iavf_fdir_gtpogre_test_plan.rst
index 29a4b8b..8e9e187 100644
--- a/test_plans/iavf_fdir_gtpogre_test_plan.rst
+++ b/test_plans/iavf_fdir_gtpogre_test_plan.rst
@@ -635,8 +635,6 @@  negative test case
     iavf_flow_create(): Failed to create flow
     port_flow_complain(): Caught PMD error type 2 (flow rule (handle)): Failed to create parser engine.: Invalid argument
 
-    testpmd> flow create 0 ingress pattern eth / ipv4 src is 1.1.2.4 dst is 1.1.2.5 / gre / ipv6 / udp / gtpu teid is 0x12 / gtp_psc pdu_t is 1 qfi is 0x100 / end actions rss queues 4 5 end / mark id 23 / end
-    Bad arguments
 
     testpmd> flow create 0 ingress pattern eth / ipv4 src is 1.1.2.4 dst is 1.1.2.5 / gre / ipv4 / udp / gtpu teid is 0x100000000 / gtp_psc pdu_t is 1 qfi is 0x3 / end actions drop / end
     Bad arguments
diff --git a/tests/TestSuite_iavf_fdir_gtpogre.py b/tests/TestSuite_iavf_fdir_gtpogre.py
old mode 100644
new mode 100755
index 1e10d58..f9915a3
--- a/tests/TestSuite_iavf_fdir_gtpogre.py
+++ b/tests/TestSuite_iavf_fdir_gtpogre.py
@@ -2117,7 +2117,6 @@  class TestCvlIavfGTPoGREFDIR(TestCase):
             'flow create 0 ingress pattern eth / ipv4 / gre / ipv4 / udp dst is 13 / gtpu / ipv4 src is 1.1.2.4 dst is 1.1.2.5 / end actions queue index 33 / mark id 13 / end',
             'flow create 0 ingress pattern eth / ipv6 / gre / ipv4 / udp / gtpu / gtp_psc pdu_t is a/ ipv4 src is 1.1.2.4 dst is 1.1.2.5 / end actions mark / rss / end',
             'flow create 0 ingress pattern eth / ipv4 / gre / ipv6 / udp / gtpu / gtp_psc pdu_t is 2 / ipv4 src is 1.1.2.4 dst is 1.1.2.5 / tcp src is 13 dst is 23 / end actions queue index 3 / mark id 13 / end',
-            'flow create 0 ingress pattern eth / ipv4 src is 1.1.2.4 dst is 1.1.2.5 / gre / ipv6 / udp / gtpu teid is 0x12 / gtp_psc pdu_t is 1 qfi is 0x100 / end actions rss queues 4 5 end / mark id 23 / end',
             'flow create 0 ingress pattern eth / ipv4 src is 1.1.2.4 dst is 1.1.2.5 / gre / ipv4 / udp / gtpu teid is 0x100000000 / gtp_psc pdu_t is 1 qfi is 0x3 / end actions drop / end',
         ]
         self.launch_testpmd(param_fdir=True)