Message ID | 1635835398-70543-4-git-send-email-xiangx.an@intel.com (mailing list archive) |
---|---|
State | Superseded |
Headers |
Return-Path: <dts-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B71C6A0C57; Tue, 2 Nov 2021 07:43:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B0FA94111A; Tue, 2 Nov 2021 07:43:54 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id BAE05410E5 for <dts@dpdk.org>; Tue, 2 Nov 2021 07:43:52 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10155"; a="254803950" X-IronPort-AV: E=Sophos;i="5.87,202,1631602800"; d="scan'208";a="254803950" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2021 23:43:51 -0700 X-IronPort-AV: E=Sophos;i="5.87,202,1631602800"; d="scan'208";a="500377212" Received: from unknown (HELO dpdk-zhaohy-t.sh.intel.com) ([10.240.183.68]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2021 23:43:38 -0700 From: Xiang An <xiangx.an@intel.com> To: dts@dpdk.org Cc: xiangx.an@intel.com Date: Tue, 2 Nov 2021 14:43:18 +0800 Message-Id: <1635835398-70543-4-git-send-email-xiangx.an@intel.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1635835398-70543-1-git-send-email-xiangx.an@intel.com> References: <1635835398-70543-1-git-send-email-xiangx.an@intel.com> Subject: [dts] [PATCH V1 4/4] tests/unit_tests_eal: modify code to adapt avx512 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions <dts.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dts>, <mailto:dts-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dts/> List-Post: <mailto:dts@dpdk.org> List-Help: <mailto:dts-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dts>, <mailto:dts-request@dpdk.org?subject=subscribe> Errors-To: dts-bounces@dpdk.org Sender: "dts" <dts-bounces@dpdk.org> |
Series |
[V1,1/4] tests/kernelpf_iavf: modify code to adapt avx512
|
|
Commit Message
Xiang An
Nov. 2, 2021, 6:43 a.m. UTC
Modify code to adapt rxmod avx512.
Signed-off-by: Xiang An <xiangx.an@intel.com>
---
tests/TestSuite_unit_tests_eal.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Comments
Hi Xiang, > Modify code to adapt rxmod avx512. > > Signed-off-by: Xiang An <xiangx.an@intel.com> > --- > tests/TestSuite_unit_tests_eal.py | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/tests/TestSuite_unit_tests_eal.py b/tests/TestSuite_unit_tests_eal.py > index 8096183..b5cb7a2 100644 > --- a/tests/TestSuite_unit_tests_eal.py > +++ b/tests/TestSuite_unit_tests_eal.py > @@ -38,7 +38,7 @@ EAL autotest. > > import framework.utils as utils > from framework.test_case import TestCase > - > +from framework.settings import load_global_setting, DPDK_RXMODE_SETTING > # > # > # Test class. > @@ -462,7 +462,8 @@ class TestUnitTestsEal(TestCase): > self.test_app_cmdline += "--no-pci" > > if self.dut.dpdk_version >= '20.11.0': > - self.test_app_cmdline += " --force-max-simd-bitwidth=0" > + if load_global_setting(DPDK_RXMODE_SETTING) == 'default': > + self.test_app_cmdline += " --force-max-simd-bitwidth=0" Could you probably explain why it is needed here? > self.dut.send_expect(self.test_app_cmdline, "R.*T.*E.*>.*>", self.start_test_time) > out = self.dut.send_expect("acl_autotest", "RTE>>", self.run_cmd_time) > self.dut.send_expect("quit", "# ") > -- > 1.8.3.1
> -----Original Message----- > From: dts <dts-bounces@dpdk.org> On Behalf Of Ananyev, Konstantin > Sent: Tuesday, November 2, 2021 6:43 PM > To: An, XiangX <xiangx.an@intel.com>; dts@dpdk.org > Cc: An, XiangX <xiangx.an@intel.com> > Subject: Re: [dts] [PATCH V1 4/4] tests/unit_tests_eal: modify code to adapt > avx512 > > > Hi Xiang, > > > Modify code to adapt rxmod avx512. > > > > Signed-off-by: Xiang An <xiangx.an@intel.com> > > --- > > tests/TestSuite_unit_tests_eal.py | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/tests/TestSuite_unit_tests_eal.py > b/tests/TestSuite_unit_tests_eal.py > > index 8096183..b5cb7a2 100644 > > --- a/tests/TestSuite_unit_tests_eal.py > > +++ b/tests/TestSuite_unit_tests_eal.py > > @@ -38,7 +38,7 @@ EAL autotest. > > > > import framework.utils as utils > > from framework.test_case import TestCase > > - > > +from framework.settings import load_global_setting, > DPDK_RXMODE_SETTING > > # > > # > > # Test class. > > @@ -462,7 +462,8 @@ class TestUnitTestsEal(TestCase): > > self.test_app_cmdline += "--no-pci" > > > > if self.dut.dpdk_version >= '20.11.0': > > - self.test_app_cmdline += " --force-max-simd-bitwidth=0" > > + if load_global_setting(DPDK_RXMODE_SETTING) == 'default': > > + self.test_app_cmdline += " > --force-max-simd-bitwidth=0" > > Could you probably explain why it is needed here? > > > self.dut.send_expect(self.test_app_cmdline, "R.*T.*E.*>.*>", > self.start_test_time) > > out = self.dut.send_expect("acl_autotest", "RTE>>", > self.run_cmd_time) > > self.dut.send_expect("quit", "# ") > > -- > > 1.8.3.1 Hi Konstantin, We have add this case to test avx512 mode, if this judgment is not added, the cmdline will invalid. Take a example: x86_64-native-linuxapp-gcc/app/test/dpdk-test -l 1,2,3,4 -n 4 --file-prefix=dpdk_237965_20211103034106 --force-max-simd-bitwidth=512 --no-pci --force-max-simd-bitwidth=0 Regards, HuangZhiMin
> > Hi Xiang, > > > > > Modify code to adapt rxmod avx512. > > > > > > Signed-off-by: Xiang An <xiangx.an@intel.com> > > > --- > > > tests/TestSuite_unit_tests_eal.py | 5 +++-- > > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > > > diff --git a/tests/TestSuite_unit_tests_eal.py > > b/tests/TestSuite_unit_tests_eal.py > > > index 8096183..b5cb7a2 100644 > > > --- a/tests/TestSuite_unit_tests_eal.py > > > +++ b/tests/TestSuite_unit_tests_eal.py > > > @@ -38,7 +38,7 @@ EAL autotest. > > > > > > import framework.utils as utils > > > from framework.test_case import TestCase > > > - > > > +from framework.settings import load_global_setting, > > DPDK_RXMODE_SETTING > > > # > > > # > > > # Test class. > > > @@ -462,7 +462,8 @@ class TestUnitTestsEal(TestCase): > > > self.test_app_cmdline += "--no-pci" > > > > > > if self.dut.dpdk_version >= '20.11.0': > > > - self.test_app_cmdline += " --force-max-simd-bitwidth=0" > > > + if load_global_setting(DPDK_RXMODE_SETTING) == 'default': > > > + self.test_app_cmdline += " > > --force-max-simd-bitwidth=0" > > > > Could you probably explain why it is needed here? > > > > > self.dut.send_expect(self.test_app_cmdline, "R.*T.*E.*>.*>", > > self.start_test_time) > > > out = self.dut.send_expect("acl_autotest", "RTE>>", > > self.run_cmd_time) > > > self.dut.send_expect("quit", "# ") > > > -- > > > 1.8.3.1 > > Hi Konstantin, > We have add this case to test avx512 mode, if this judgment is not added, the cmdline will invalid. > > Take a example: > x86_64-native-linuxapp-gcc/app/test/dpdk-test -l 1,2,3,4 -n 4 --file-prefix=dpdk_237965_20211103034106 --force-max-simd-bitwidth=512 > --no-pci --force-max-simd-bitwidth=0 > So DPDK_RXMODE_SETTING controls whether '--force-max-simd-bitwidth' is set or not? If so, can we then just override it here for this test-case? I'd like this test-case to always run with '--force-max-simd-bitwidth=0'. That way it provides best possible coverage.
> -----Original Message----- > From: Ananyev, Konstantin <konstantin.ananyev@intel.com> > Sent: Tuesday, November 2, 2021 7:27 PM > To: Huang, ZhiminX <zhiminx.huang@intel.com>; dts@dpdk.org > Cc: An, XiangX <xiangx.an@intel.com> > Subject: RE: [dts] [PATCH V1 4/4] tests/unit_tests_eal: modify code to adapt > avx512 > > > > > > Hi Xiang, > > > > > > > Modify code to adapt rxmod avx512. > > > > > > > > Signed-off-by: Xiang An <xiangx.an@intel.com> > > > > --- > > > > tests/TestSuite_unit_tests_eal.py | 5 +++-- > > > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/tests/TestSuite_unit_tests_eal.py > > > b/tests/TestSuite_unit_tests_eal.py > > > > index 8096183..b5cb7a2 100644 > > > > --- a/tests/TestSuite_unit_tests_eal.py > > > > +++ b/tests/TestSuite_unit_tests_eal.py > > > > @@ -38,7 +38,7 @@ EAL autotest. > > > > > > > > import framework.utils as utils > > > > from framework.test_case import TestCase > > > > - > > > > +from framework.settings import load_global_setting, > > > DPDK_RXMODE_SETTING > > > > # > > > > # > > > > # Test class. > > > > @@ -462,7 +462,8 @@ class TestUnitTestsEal(TestCase): > > > > self.test_app_cmdline += "--no-pci" > > > > > > > > if self.dut.dpdk_version >= '20.11.0': > > > > - self.test_app_cmdline += " --force-max-simd-bitwidth=0" > > > > + if load_global_setting(DPDK_RXMODE_SETTING) == > 'default': > > > > + self.test_app_cmdline += " > > > --force-max-simd-bitwidth=0" > > > > > > Could you probably explain why it is needed here? > > > > > > > self.dut.send_expect(self.test_app_cmdline, > > > > "R.*T.*E.*>.*>", > > > self.start_test_time) > > > > out = self.dut.send_expect("acl_autotest", "RTE>>", > > > self.run_cmd_time) > > > > self.dut.send_expect("quit", "# ") > > > > -- > > > > 1.8.3.1 > > > > Hi Konstantin, > > We have add this case to test avx512 mode, if this judgment is not added, the > cmdline will invalid. > > > > Take a example: > > x86_64-native-linuxapp-gcc/app/test/dpdk-test -l 1,2,3,4 -n 4 > > --file-prefix=dpdk_237965_20211103034106 --force-max-simd-bitwidth=512 > > --no-pci --force-max-simd-bitwidth=0 > > > > So DPDK_RXMODE_SETTING controls whether '--force-max-simd-bitwidth' is > set or not? > If so, can we then just override it here for this test-case? > I'd like this test-case to always run with '--force-max-simd-bitwidth=0'. > That way it provides best possible coverage. > > So according your decription, in any avx mode should be excuted '--force-max-simd-bitwidth=0'? If so, I will re-submit dst patch to cover about acl test.
> > > > > > Hi Xiang, > > > > > > > > > Modify code to adapt rxmod avx512. > > > > > > > > > > Signed-off-by: Xiang An <xiangx.an@intel.com> > > > > > --- > > > > > tests/TestSuite_unit_tests_eal.py | 5 +++-- > > > > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > > > > > > > diff --git a/tests/TestSuite_unit_tests_eal.py > > > > b/tests/TestSuite_unit_tests_eal.py > > > > > index 8096183..b5cb7a2 100644 > > > > > --- a/tests/TestSuite_unit_tests_eal.py > > > > > +++ b/tests/TestSuite_unit_tests_eal.py > > > > > @@ -38,7 +38,7 @@ EAL autotest. > > > > > > > > > > import framework.utils as utils > > > > > from framework.test_case import TestCase > > > > > - > > > > > +from framework.settings import load_global_setting, > > > > DPDK_RXMODE_SETTING > > > > > # > > > > > # > > > > > # Test class. > > > > > @@ -462,7 +462,8 @@ class TestUnitTestsEal(TestCase): > > > > > self.test_app_cmdline += "--no-pci" > > > > > > > > > > if self.dut.dpdk_version >= '20.11.0': > > > > > - self.test_app_cmdline += " --force-max-simd-bitwidth=0" > > > > > + if load_global_setting(DPDK_RXMODE_SETTING) == > > 'default': > > > > > + self.test_app_cmdline += " > > > > --force-max-simd-bitwidth=0" > > > > > > > > Could you probably explain why it is needed here? > > > > > > > > > self.dut.send_expect(self.test_app_cmdline, > > > > > "R.*T.*E.*>.*>", > > > > self.start_test_time) > > > > > out = self.dut.send_expect("acl_autotest", "RTE>>", > > > > self.run_cmd_time) > > > > > self.dut.send_expect("quit", "# ") > > > > > -- > > > > > 1.8.3.1 > > > > > > Hi Konstantin, > > > We have add this case to test avx512 mode, if this judgment is not added, the > > cmdline will invalid. > > > > > > Take a example: > > > x86_64-native-linuxapp-gcc/app/test/dpdk-test -l 1,2,3,4 -n 4 > > > --file-prefix=dpdk_237965_20211103034106 --force-max-simd-bitwidth=512 > > > --no-pci --force-max-simd-bitwidth=0 > > > > > > > So DPDK_RXMODE_SETTING controls whether '--force-max-simd-bitwidth' is > > set or not? > > If so, can we then just override it here for this test-case? > > I'd like this test-case to always run with '--force-max-simd-bitwidth=0'. > > That way it provides best possible coverage. > > > > > So according your decription, in any avx mode should be excuted '--force-max-simd-bitwidth=0'? Yes, basically '--force-max-simd-bitwidth=0' says use max available SIMD on that box. So on machine with avx512 it will test: avx512, avx2, sse, scalar. On machine with avx2 only it will test: avx2, sse, scalar. ... > If so, I will re-submit dst patch to cover about acl test. Good, thanks.
diff --git a/tests/TestSuite_unit_tests_eal.py b/tests/TestSuite_unit_tests_eal.py index 8096183..b5cb7a2 100644 --- a/tests/TestSuite_unit_tests_eal.py +++ b/tests/TestSuite_unit_tests_eal.py @@ -38,7 +38,7 @@ EAL autotest. import framework.utils as utils from framework.test_case import TestCase - +from framework.settings import load_global_setting, DPDK_RXMODE_SETTING # # # Test class. @@ -462,7 +462,8 @@ class TestUnitTestsEal(TestCase): self.test_app_cmdline += "--no-pci" if self.dut.dpdk_version >= '20.11.0': - self.test_app_cmdline += " --force-max-simd-bitwidth=0" + if load_global_setting(DPDK_RXMODE_SETTING) == 'default': + self.test_app_cmdline += " --force-max-simd-bitwidth=0" self.dut.send_expect(self.test_app_cmdline, "R.*T.*E.*>.*>", self.start_test_time) out = self.dut.send_expect("acl_autotest", "RTE>>", self.run_cmd_time) self.dut.send_expect("quit", "# ")