[v2] framework: Advise against using root passwords
Checks
Commit Message
From: Owen Hilyard <ohilyard@iol.unh.edu>
Added messages to notify the user that a blank password field will use
ssh keys, and that using root passwords is insecure.
Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
---
conf/crbs.cfg | 4 ++--
tools/setup.py | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
Comments
> Subject: [PATCH v2] framework: Advise against using root passwords
>
> From: Owen Hilyard <ohilyard@iol.unh.edu>
>
> Added messages to notify the user that a blank password field will use ssh keys,
> and that using root passwords is insecure.
>
> Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
Acked-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> -----Original Message-----
> From: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Sent: 2021年11月18日 18:17
> To: ohilyard@iol.unh.edu; dts@dpdk.org
> Cc: Tu, Lijuan <lijuan.tu@intel.com>
> Subject: RE: [PATCH v2] framework: Advise against using root passwords
>
> > Subject: [PATCH v2] framework: Advise against using root passwords
> >
> > From: Owen Hilyard <ohilyard@iol.unh.edu>
> >
> > Added messages to notify the user that a blank password field will use
> > ssh keys, and that using root passwords is insecure.
> >
> > Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
>
> Acked-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
Applied, thanks
@@ -2,10 +2,10 @@
#[DUT IP]
# dut_ip: DUT ip address
# dut_user: Login DUT username
-# dut_passwd: Login DUT password
+# dut_passwd: [INSECURE] Login DUT password, leaving this blank will force using SSH keys
# os: operation system type linux or freebsd
# tester_ip: Tester ip address
-# tester_passwd: Tester password
+# tester_passwd: [INSECURE] Tester password, leaving this blank will force using SSH keys
# pktgen_group: packet generator group name: ixia/trex/ixia_network
# channels: Board channel number
# bypass_core0: Whether by pass core0
@@ -105,7 +105,7 @@ def config_crbs():
passwd_option = {'prompt': 'DUT root password',
'type': 'string',
- 'help': 'Please input password of DUT crb',
+ 'help': '[INSECURE] Please input password of DUT crb (leave blank to use preconfigured SSH keys)',
'default': ''}
opt = Option(**passwd_option)
dut_pass = opt.parse_input()
@@ -120,7 +120,7 @@ def config_crbs():
passwd_option = {'prompt': 'Tester root password',
'type': 'string',
- 'help': 'Please input password of Tester crb',
+ 'help': '[INSECURE] Please input password of Tester crb (leave blank to use preconfigured SSH keys)',
'default': ''}
opt = Option(**passwd_option)
tester_pass = opt.parse_input()