diff mbox series

[V1] tests/mtu_update:igc can receive packets 8 larger than MTU

Message ID 20211124172343.132742-1-leweix.yang@intel.com (mailing list archive)
State Accepted
Headers
Series [V1] tests/mtu_update:igc can receive packets 8 larger than MTU |

Checks

Context Check Description
ci/Intel-dts-suite-test success Testing OK

Commit Message

Lewei Yang Nov. 24, 2021, 5:23 p.m. UTC 
  According to dpdk commit 1bb4a528c41f("ethdev: fix max Rx packet length"),
there is a miss accuracy in the MTU configuration in DPDK, packets bigger (up to 8 bytes) than requested MTU can be received.

Signed-off-by: Lewei Yang <leweix.yang@intel.com>
---
 tests/TestSuite_mtu_update.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Tu, Lijuan Nov. 30, 2021, 2:53 a.m. UTC | #1 
> -----Original Message-----
> From: Lewei Yang <leweix.yang@intel.com>
> Sent: 2021年11月25日 1:24
> To: dts@dpdk.org
> Cc: Yang, LeweiX <leweix.yang@intel.com>
> Subject: [dts][PATCH V1] tests/mtu_update:igc can receive packets 8 larger than
> MTU
> 
> According to dpdk commit 1bb4a528c41f("ethdev: fix max Rx packet length"),
> there is a miss accuracy in the MTU configuration in DPDK, packets bigger (up to
> 8 bytes) than requested MTU can be received.
> 
> Signed-off-by: Lewei Yang <leweix.yang@intel.com>

Could you please go through all MTU and jumbo frame related cases?
Tu, Lijuan Dec. 1, 2021, 6:03 a.m. UTC | #2 
> -----Original Message-----
> From: Lewei Yang <leweix.yang@intel.com>
> Sent: 2021年11月25日 1:24
> To: dts@dpdk.org
> Cc: Yang, LeweiX <leweix.yang@intel.com>
> Subject: [dts][PATCH V1] tests/mtu_update:igc can receive packets 8 larger than
> MTU
> 
> According to dpdk commit 1bb4a528c41f("ethdev: fix max Rx packet length"),
> there is a miss accuracy in the MTU configuration in DPDK, packets bigger (up to
> 8 bytes) than requested MTU can be received.
> 
> Signed-off-by: Lewei Yang <leweix.yang@intel.com>

Applied, thanks
diff mbox series

Patch

diff --git a/tests/TestSuite_mtu_update.py b/tests/TestSuite_mtu_update.py
index ad13a8ab..be114759 100644
--- a/tests/TestSuite_mtu_update.py
+++ b/tests/TestSuite_mtu_update.py
@@ -239,9 +239,9 @@  class TestMtuUpdate(TestCase):
         On 1G NICs, when the jubmo frame MTU set > 1500, the software adjust it to MTU+4.
         """
         if self.nic in ["powerville", "springville", "foxville"] and packet_size > 1500:
-            self.send_packet_of_size_to_tx_port(packet_size + 4 - 1, received=True)
-            self.send_packet_of_size_to_tx_port(packet_size + 4, received=True)
-            self.send_packet_of_size_to_tx_port(packet_size + 4 + 1, received=False)
+            self.send_packet_of_size_to_tx_port(packet_size + 8 - 1, received=True)
+            self.send_packet_of_size_to_tx_port(packet_size + 8, received=True)
+            self.send_packet_of_size_to_tx_port(packet_size + 8 + 1, received=False)
         else:
             self.send_packet_of_size_to_tx_port(packet_size - 1, received=True)
             self.send_packet_of_size_to_tx_port(packet_size, received=True)