diff mbox series

[53/82] net/igc: remove unnecessary NULL checks

Message ID	20220124000518.319850-54-stephen@networkplumber.org (mailing list archive)
State	Superseded, archived
Delegated to:	Thomas Monjalon
Headers	From: Stephen Hemminger <stephen@networkplumber.org> To: dev@dpdk.org Cc: Stephen Hemminger <stephen@networkplumber.org>, Haiyue Wang <haiyue.wang@intel.com> Subject: [PATCH 53/82] net/igc: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:49 -0800 Message-Id: <20220124000518.319850-54-stephen@networkplumber.org> In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	remove unnecessary null checks \| [00/82] remove unnecessary null checks [01/82] devtools/cocci: add script to fix unnecessary null checks [02/82] eal: remove unnecessary NULL checks [03/82] eal/windows: remove unnecessary NULL checks before free [04/82] examples/fips_validation: remove unnecessary NULL checks [05/82] examples/ip_pipeline: remove unnecessary NULL checks [06/82] examples/pipeline/thread: remove unnecessary NULL checks [07/82] examples/l2fwd-cat: remove unnecessary NULL checks [08/82] lib/vhost: remove unnecessary NULL checks [09/82] examples/vhost_blk: remove unnecessary NULL checks [10/82] app/pdump: remove unnecessary NULL checks [11/82] app/test-crypto-perf: remove unnecessary NULL checks [12/82] app/test-pmd: remove unnecessary NULL checks [13/82] app/test-regex: remove unnecessary NULL checks [14/82] app/test: remove unnecessary NULL checks [15/82] baseband/acc100 remove unnecessary NULL checks [16/82] baseband/la12xx remove unnecessary NULL checks [17/82] baseband/null remove unnecessary NULL checks [18/82] baseband/turbo_sw remove unnecessary NULL checks [19/82] bus/fslmc: remove unnecessary NULL checks [20/82] bus/ifpga: remove unnecessary NULL checks [21/82] bus/pci: remove unnecessary NULL checks [22/82] common/cpt: remove unnecessary NULL checks [23/82] common/dpaax: simplify kernel compat macros [24/82] common/mlx5: remove unnecessary NULL checks [25/82] common/qat: remove unnecessary NULL checks [26/82] compress/mlx5: remove unnecessary NULL checks [27/82] compress/octeontx: remove unnecessary NULL checks [28/82] crypto/armv8: remove unnecessary NULL checks [29/82] crypto/ccp: remove unnecessary NULL checks [30/82] crypto/cnxk: remove unnecessary NULL checks [31/82] crypto/ipsec_mb: remove unnecessary NULL checks [32/82] crypto/mvsam: remove unnecessary NULL checks [33/82] crypto/null: remove unnecessary NULL checks [34/82] crypto/octeontx: remove unnecessary NULL checks [35/82] crypto/openssl: remove unnecessary NULL checks [36/82] crypto/scheduler: remove unnecessary NULL checks [37/82] crypto/virtio: remove unnecessary NULL checks [38/82] event/sw: remove unnecessary NULL checks [39/82] net/axgbe: remove unnecessary NULL checks [40/82] net/bnx2x: remove unnecessary NULL checks [41/82] net/bnxt: remove unnecessary NULL checks [42/82] net/bonding: remove unnecessary NULL checks [43/82] net/cnxk: remove unnecessary NULL checks [44/82] net/cxgbe: remove unnecessary NULL checks [45/82] net/dpaa: remove unnecessary NULL checks [46/82] net/dpaa2: remove unnecessary NULL checks [47/82] net/ena: remove unnecessary NULL checks [48/82] net/hinic: remove unnecessary NULL checks [49/82] net/hns3: remove unnecessary NULL checks [50/82] net/i40e: remove unnecessary NULL checks [51/82] net/iavf: remove unnecessary NULL checks [52/82] net/ice: remove unnecessary NULL checks [53/82] net/igc: remove unnecessary NULL checks [54/82] net/ixgbe: remove unnecessary NULL checks [55/82] net/memif: remove unnecessary NULL checks [56/82] net/mlx4: remove unnecessary NULL checks [57/82] net/mlx5: remove unnecessary NULL checks [58/82] net/mvpp2: remove unnecessary NULL checks [59/82] net/netvsc: remove unnecessary NULL checks [60/82] net/null: remove unnecessary NULL checks [61/82] net/octeontx: remove unnecessary NULL checks [62/82] net/qede: remove unnecessary NULL checks [63/82] net/softnic: remove unnecessary NULL checks [64/82] net/tap: remove unnecessary NULL checks [65/82] net/txgbe: remove unnecessary NULL checks [66/82] net/vdev_netvsc: remove unnecessary NULL checks [67/82] net/virtio: remove unnecessary NULL checks [68/82] raw/cnxk_bphy: remove unnecessary NULL checks [69/82] raw/dpaa2_qdma: remove unnecessary NULL checks [70/82] raw/ifpga: remove unnecessary NULL checks [71/82] raw/skeleton: remove unnecessary NULL checks [72/82] regex/cn9k: remove unnecessary NULL checks [73/82] regex/mlx5: remove unnecessary NULL checks [74/82] vdpa/ifc: remove unnecessary NULL checks [75/82] vdpa/mlx5: remove unnecessary NULL checks [76/82] compressdev: remove unnecessary NULL checks [77/82] ethdev: remove unnecessary NULL checks [78/82] graph: remove unnecessary NULL checks [79/82] ipsec: remove unnecessary NULL checks [80/82] port: remove unnecessary NULL checks [81/82] power: remove unnecessary NULL checks [82/82] reorder: remove unnecessary NULL checks

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Stephen Hemminger Jan. 24, 2022, 12:04 a.m. UTC

  Remove redundant NULL pointer checks before free functions
found by nullfree.cocci

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/igc/igc_flow.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Wang, Haiyue Jan. 24, 2022, 12:49 a.m. UTC | #1

> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Monday, January 24, 2022 08:05
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; Wang, Haiyue <haiyue.wang@intel.com>
> Subject: [PATCH 53/82] net/igc: remove unnecessary NULL checks
> 
> Remove redundant NULL pointer checks before free functions
> found by nullfree.cocci
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  drivers/net/igc/igc_flow.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/igc/igc_flow.c b/drivers/net/igc/igc_flow.c
> index 66053060af5a..88978ee0e849 100644
> --- a/drivers/net/igc/igc_flow.c
> +++ b/drivers/net/igc/igc_flow.c
> @@ -776,8 +776,7 @@ igc_flow_create(struct rte_eth_dev *dev,
> 
>  	if (ret) {
>  		/* check and free the memory */

This comment line can be removed either, since 'check' is done by 'rte_free'
internally.

> -		if (flow)
> -			rte_free(flow);
> +		rte_free(flow);
> 
>  		rte_flow_error_set(error, -ret,
>  				RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
> --
> 2.30.2

diff mbox series

Patch

diff --git a/drivers/net/igc/igc_flow.c b/drivers/net/igc/igc_flow.c
index 66053060af5a..88978ee0e849 100644
--- a/drivers/net/igc/igc_flow.c
+++ b/drivers/net/igc/igc_flow.c
@@ -776,8 +776,7 @@  igc_flow_create(struct rte_eth_dev *dev,
 
 	if (ret) {
 		/* check and free the memory */
-		if (flow)
-			rte_free(flow);
+		rte_free(flow);
 
 		rte_flow_error_set(error, -ret,
 				RTE_FLOW_ERROR_TYPE_HANDLE, NULL,