[v1,1/2] framework/crb: fix pylama errors
Commit Message
Pylama found the following errors:
framework/crb.py:68: [E] E1101 Instance of 'Crb' has no 'get_ip_address' member [pylint]
framework/crb.py:69: [E] E1101 Instance of 'Crb' has no 'get_username' member [pylint]
framework/crb.py:70: [E] E1101 Instance of 'Crb' has no 'get_password' member [pylint]
framework/crb.py:74: [E] E1101 Instance of 'Crb' has no 'get_ip_address' member [pylint]
framework/crb.py:76: [E] E1101 Instance of 'Crb' has no 'get_username' member [pylint]
framework/crb.py:77: [E] E1101 Instance of 'Crb' has no 'get_password' member [pylint]
framework/crb.py:109: [E] E1101 Instance of 'Crb' has no 'get_ip_address' member [pylint]
framework/crb.py:111: [E] E1101 Instance of 'Crb' has no 'get_username' member [pylint]
framework/crb.py:112: [E] E1101 Instance of 'Crb' has no 'get_password' member [pylint]
framework/crb.py:140: [E] E1101 Instance of 'Crb' has no 'loggger' member; maybe 'logger'? [pylint]
framework/crb.py:144: [E] E1101 Instance of 'Crb' has no 'get_ip_address' member [pylint]
framework/crb.py:146: [E] E1101 Instance of 'Crb' has no 'get_username' member [pylint]
framework/crb.py:147: [E] E1101 Instance of 'Crb' has no 'get_password' member [pylint]
framework/crb.py:150: [E] E1101 Instance of 'Crb' has no 'get_ip_address' member [pylint]
framework/crb.py:151: [E] E1101 Instance of 'Crb' has no 'get_username' member [pylint]
framework/crb.py:151: [E] E1101 Instance of 'Crb' has no 'get_password' member [pylint]
framework/crb.py:254: [E] E1136 Value 'self.ports_info' is unsubscriptable [pylint]
framework/crb.py:270: [E] E1101 Instance of 'Crb' has no 'PCI_DEV_CACHE_KEY' member [pylint]
framework/crb.py:274: [E] E1101 Instance of 'Crb' has no 'PCI_DEV_CACHE_KEY' member [pylint]
framework/crb.py:391: [E] E1120 No value for argument 'string' in function call [pylint]
framework/crb.py:478: [E] E1101 Instance of 'Crb' has no 'get_password' member [pylint]
framework/crb.py:560: [E] E0203 Access to member 'prefix_list' before its definition line 564 [pylint]
framework/crb.py:562: [E] E0203 Access to member 'prefix_list' before its definition line 564 [pylint]
framework/crb.py:606: [E] E1101 Instance of 'Crb' has no 'NUMBER_CORES_CACHE_KEY' member [pylint]
framework/crb.py:607: [E] E1101 Instance of 'Crb' has no 'CORE_LIST_CACHE_KEY' member [pylint]
framework/crb.py:611: [E] E1101 Instance of 'Crb' has no 'NUMBER_CORES_CACHE_KEY' member [pylint]
framework/crb.py:612: [E] E1101 Instance of 'Crb' has no 'CORE_LIST_CACHE_KEY' member [pylint]
framework/crb.py:880: [E] E1133 Non-iterable value self.ports_info is used in an iterating context [pylint]
framework/crb.py:888: [E] E1136 Value 'self.ports_info' is unsubscriptable [pylint]
Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
---
framework/crb.py | 29 ++++++++++++++++++++++++++---
framework/dut.py | 2 --
framework/virt_dut.py | 2 --
3 files changed, 26 insertions(+), 7 deletions(-)
Comments
> -----Original Message-----
> From: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Sent: Wednesday, January 19, 2022 9:41 PM
> To: Dong, JunX <junx.dong@intel.com>; Tu, Lijuan <lijuan.tu@intel.com>;
> ohilyard@iol.unh.edu
> Cc: dts@dpdk.org; Juraj Linkeš <juraj.linkes@pantheon.tech>
> Subject: [PATCH v1 1/2] framework/crb: fix pylama errors
>
> Pylama found the following errors:
> framework/crb.py:68: [E] E1101 Instance of 'Crb' has no 'get_ip_address'
> member [pylint]
> framework/crb.py:69: [E] E1101 Instance of 'Crb' has no 'get_username'
> member [pylint]
> framework/crb.py:70: [E] E1101 Instance of 'Crb' has no 'get_password'
> member [pylint]
>
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
Reviewed-by: Jun Dong <junx.dong@intel.com>
@@ -51,18 +51,23 @@ class Crb(object):
CPU/PCI/NIC on the board and setup running environment for DPDK.
"""
+ PCI_DEV_CACHE_KEY = None
+ NUMBER_CORES_CACHE_KEY = None
+ CORE_LIST_CACHE_KEY = None
+
def __init__(self, crb, serializer, name, alt_session=True, dut_id=0):
self.dut_id = dut_id
self.crb = crb
self.read_cache = False
self.skip_setup = False
self.serializer = serializer
- self.ports_info = None
+ self.ports_info = []
self.sessions = []
self.stage = 'pre-init'
self.name = name
self.trex_prefix = None
self.default_hugepages_cleared = False
+ self.prefix_list = []
self.logger = getLogger(name)
self.session = SSHConnection(self.get_ip_address(), name,
@@ -80,6 +85,24 @@ class Crb(object):
else:
self.alt_session = None
+ def get_ip_address(self):
+ """
+ Get CRB's ip address.
+ """
+ raise NotImplementedError
+
+ def get_password(self):
+ """
+ Get CRB's login password.
+ """
+ raise NotImplementedError
+
+ def get_username(self):
+ """
+ Get CRB's login username.
+ """
+ raise NotImplementedError
+
def send_expect(self, cmds, expected, timeout=TIMEOUT,
alt_session=False, verify=False, trim_whitespace=True):
"""
@@ -137,7 +160,7 @@ class Crb(object):
else:
self.session.close(force=True)
except Exception as e:
- self.loggger.error("Session close failed for [%s]" % e)
+ self.logger.error("Session close failed for [%s]" % e)
if alt_session:
session = SSHConnection(
@@ -388,7 +411,7 @@ class Crb(object):
(domain_id, bus_id, devfun_id), "# ", alt_session=True)
rexp = r"PCI_ID=(.+)"
pattern = re.compile(rexp)
- match = re.search(out)
+ match = re.search(pattern, out)
if not match:
return None
return match.group(1)
@@ -71,14 +71,12 @@ class Dut(Crb):
self.tester = None
self.cores = []
self.architecture = None
- self.ports_info = []
self.conf = PortConf()
self.ports_map = []
self.virt_pool = None
# hypervisor pid list, used for cleanup
self.virt_pids = []
self.prefix_subfix = str(os.getpid()) + '_' + time.strftime("%Y%m%d%H%M%S", time.localtime())
- self.prefix_list = []
self.hugepage_path = None
self.apps_name_conf = {}
self.apps_name = {}
@@ -78,11 +78,9 @@ class VirtDut(DPDKdut):
self.tester = None
self.cores = []
self.architecture = None
- self.ports_info = None
self.ports_map = []
self.virttype = virttype
self.prefix_subfix = str(os.getpid()) + '_' + time.strftime("%Y%m%d%H%M%S", time.localtime())
- self.prefix_list = []
self.apps_name_conf = {}
self.apps_name = {}