[v2,15/15] vhost: make sure each queue callfd is configured
Checks
Commit Message
During the vhost data path building process, qemu will create
a call fd at first, and create another call fd in the end.
The final call fd will be used to relay notify.
In the original code, after kick fd is set, dev_conf will
set the first call fd. Even though the actual call fd will set,
the data path will not work correctly.
Signed-off-by: Andy Pei <andy.pei@intel.com>
---
lib/vhost/vhost_user.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
Comments
Hi Andy,
> -----Original Message-----
> From: Pei, Andy <andy.pei@intel.com>
> Sent: Tuesday, January 25, 2022 5:37 PM
> To: dev@dpdk.org
> Cc: Xia, Chenbo <chenbo.xia@intel.com>; maxime.coquelin@redhat.com; Cao, Gang
> <gang.cao@intel.com>; Liu, Changpeng <changpeng.liu@intel.com>
> Subject: [PATCH v2 15/15] vhost: make sure each queue callfd is configured
>
> During the vhost data path building process, qemu will create
> a call fd at first, and create another call fd in the end.
> The final call fd will be used to relay notify.
> In the original code, after kick fd is set, dev_conf will
> set the first call fd. Even though the actual call fd will set,
> the data path will not work correctly.
>
> Signed-off-by: Andy Pei <andy.pei@intel.com>
> ---
> lib/vhost/vhost_user.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
> 1.8.3.1
Please fix all reported error on patchwork first.
http://patchwork.dpdk.org/project/dpdk/patch/1643103437-118618-16-git-send-email-andy.pei@intel.com/
Thanks,
Chenbo
Hi Chenbo,
Thanks for your reply.
I will send out a V3 patch set to address that.
-----Original Message-----
From: Xia, Chenbo <chenbo.xia@intel.com>
Sent: Thursday, January 27, 2022 3:13 PM
To: Pei, Andy <andy.pei@intel.com>; dev@dpdk.org
Cc: maxime.coquelin@redhat.com; Cao, Gang <gang.cao@intel.com>; Liu, Changpeng <changpeng.liu@intel.com>
Subject: RE: [PATCH v2 15/15] vhost: make sure each queue callfd is configured
Hi Andy,
> -----Original Message-----
> From: Pei, Andy <andy.pei@intel.com>
> Sent: Tuesday, January 25, 2022 5:37 PM
> To: dev@dpdk.org
> Cc: Xia, Chenbo <chenbo.xia@intel.com>; maxime.coquelin@redhat.com;
> Cao, Gang <gang.cao@intel.com>; Liu, Changpeng
> <changpeng.liu@intel.com>
> Subject: [PATCH v2 15/15] vhost: make sure each queue callfd is
> configured
>
> During the vhost data path building process, qemu will create a call
> fd at first, and create another call fd in the end.
> The final call fd will be used to relay notify.
> In the original code, after kick fd is set, dev_conf will set the
> first call fd. Even though the actual call fd will set, the data path
> will not work correctly.
>
> Signed-off-by: Andy Pei <andy.pei@intel.com>
> ---
> lib/vhost/vhost_user.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
> 1.8.3.1
Please fix all reported error on patchwork first.
http://patchwork.dpdk.org/project/dpdk/patch/1643103437-118618-16-git-send-email-andy.pei@intel.com/
Thanks,
Chenbo
@@ -3137,12 +3137,26 @@ typedef int (*vhost_message_handler_t)(struct virtio_net **pdev,
if (!vdpa_dev)
goto out;
+ if (request != VHOST_USER_SET_VRING_CALL)
+ goto out;
+
if (!(dev->flags & VIRTIO_DEV_VDPA_CONFIGURED)) {
if (vdpa_dev->ops->dev_conf(dev->vid))
VHOST_LOG_CONFIG(ERR,
"Failed to configure vDPA device\n");
else
dev->flags |= VIRTIO_DEV_VDPA_CONFIGURED;
+ } else {
+ /* when VIRTIO_DEV_VDPA_CONFIGURED already configured
+ * close the device and config the device again,
+ * make sure the call fd of each queue is configured correctly.
+ */
+ if (vdpa_dev->ops->dev_close(dev->vid))
+ VHOST_LOG_CONFIG(ERR,
+ "Failed to close vDPA device\n");
+ if (vdpa_dev->ops->dev_conf(dev->vid))
+ VHOST_LOG_CONFIG(ERR,
+ "Failed to re-config vDPA device\n");
}
out: