diff mbox series

[v2,77/83] compressdev: remove unnecessary NULL checks

Message ID	20220124174719.14417-78-stephen@networkplumber.org (mailing list archive)
State	Superseded, archived
Delegated to:	Thomas Monjalon
Headers	From: Stephen Hemminger <stephen@networkplumber.org> To: dev@dpdk.org Cc: Stephen Hemminger <stephen@networkplumber.org>, Fan Zhang <roy.fan.zhang@intel.com>, Ashish Gupta <ashish.gupta@marvell.com> Subject: [PATCH v2 77/83] compressdev: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:47:13 -0800 Message-Id: <20220124174719.14417-78-stephen@networkplumber.org> In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	remove unnecessary null checks \| [v2,00/83] remove unnecessary null checks [v2,01/83] lib: update documentation of XXX_free() functions [v2,02/83] devtools/cocci: add script to fix unnecessary null checks [v2,03/83] eal: remove unnecessary NULL checks [v2,04/83] eal/windows: remove unnecessary NULL checks before free [v2,05/83] examples/fips_validation: remove unnecessary NULL checks [v2,06/83] examples/ip_pipeline: remove unnecessary NULL checks [v2,07/83] examples/pipeline/thread: remove unnecessary NULL checks [v2,08/83] examples/l2fwd-cat: remove unnecessary NULL checks [v2,09/83] lib/vhost: remove unnecessary NULL checks [v2,10/83] examples/vhost_blk: remove unnecessary NULL checks [v2,11/83] app/pdump: remove unnecessary NULL checks [v2,12/83] app/test-crypto-perf: remove unnecessary NULL checks [v2,13/83] app/test-pmd: remove unnecessary NULL checks [v2,14/83] app/test-regex: remove unnecessary NULL checks [v2,15/83] app/test: remove unnecessary NULL checks [v2,16/83] baseband/acc100 remove unnecessary NULL checks [v2,17/83] baseband/la12xx remove unnecessary NULL checks [v2,18/83] baseband/null remove unnecessary NULL checks [v2,19/83] baseband/turbo_sw remove unnecessary NULL checks [v2,20/83] bus/fslmc: remove unnecessary NULL checks [v2,21/83] bus/ifpga: remove unnecessary NULL checks [v2,22/83] bus/pci: remove unnecessary NULL checks [v2,23/83] common/cpt: remove unnecessary NULL checks [v2,24/83] common/dpaax: simplify kernel compat macros [v2,25/83] common/mlx5: remove unnecessary NULL checks [v2,26/83] common/qat: remove unnecessary NULL checks [v2,27/83] compress/mlx5: remove unnecessary NULL checks [v2,28/83] compress/octeontx: remove unnecessary NULL checks [v2,29/83] crypto/armv8: remove unnecessary NULL checks [v2,30/83] crypto/ccp: remove unnecessary NULL checks [v2,31/83] crypto/cnxk: remove unnecessary NULL checks [v2,32/83] crypto/ipsec_mb: remove unnecessary NULL checks [v2,33/83] crypto/mvsam: remove unnecessary NULL checks [v2,34/83] crypto/null: remove unnecessary NULL checks [v2,35/83] crypto/octeontx: remove unnecessary NULL checks [v2,36/83] crypto/openssl: remove unnecessary NULL checks [v2,37/83] crypto/scheduler: remove unnecessary NULL checks [v2,38/83] crypto/virtio: remove unnecessary NULL checks [v2,39/83] event/sw: remove unnecessary NULL checks [v2,40/83] net/axgbe: remove unnecessary NULL checks [v2,41/83] net/bnx2x: remove unnecessary NULL checks [v2,42/83] net/bnxt: remove unnecessary NULL checks [v2,43/83] net/bonding: remove unnecessary NULL checks [v2,44/83] net/cnxk: remove unnecessary NULL checks [v2,45/83] net/cxgbe: remove unnecessary NULL checks [v2,46/83] net/dpaa: remove unnecessary NULL checks [v2,47/83] net/dpaa2: remove unnecessary NULL checks [v2,48/83] net/ena: remove unnecessary NULL checks [v2,49/83] net/hinic: remove unnecessary NULL checks [v2,50/83] net/hns3: remove unnecessary NULL checks [v2,51/83] net/i40e: remove unnecessary NULL checks [v2,52/83] net/iavf: remove unnecessary NULL checks [v2,53/83] net/ice: remove unnecessary NULL checks [v2,54/83] net/igc: remove unnecessary NULL checks [v2,55/83] net/ixgbe: remove unnecessary NULL checks [v2,56/83] net/memif: remove unnecessary NULL checks [v2,57/83] net/mlx4: remove unnecessary NULL checks [v2,58/83] net/mlx5: remove unnecessary NULL checks [v2,59/83] net/mvpp2: remove unnecessary NULL checks [v2,60/83] net/netvsc: remove unnecessary NULL checks [v2,61/83] net/null: remove unnecessary NULL checks [v2,62/83] net/octeontx: remove unnecessary NULL checks [v2,63/83] net/qede: remove unnecessary NULL checks [v2,64/83] net/softnic: remove unnecessary NULL checks [v2,65/83] net/tap: remove unnecessary NULL checks [v2,66/83] net/txgbe: remove unnecessary NULL checks [v2,67/83] net/vdev_netvsc: remove unnecessary NULL checks [v2,68/83] net/virtio: remove unnecessary NULL checks [v2,69/83] raw/cnxk_bphy: remove unnecessary NULL checks [v2,70/83] raw/dpaa2_qdma: remove unnecessary NULL checks [v2,71/83] raw/ifpga: remove unnecessary NULL checks [v2,72/83] raw/skeleton: remove unnecessary NULL checks [v2,73/83] regex/cn9k: remove unnecessary NULL checks [v2,74/83] regex/mlx5: remove unnecessary NULL checks [v2,75/83] vdpa/ifc: remove unnecessary NULL checks [v2,76/83] vdpa/mlx5: remove unnecessary NULL checks [v2,77/83] compressdev: remove unnecessary NULL checks [v2,78/83] ethdev: remove unnecessary NULL checks [v2,79/83] graph: remove unnecessary NULL checks [v2,80/83] ipsec: remove unnecessary NULL checks [v2,81/83] port: remove unnecessary NULL checks [v2,82/83] power: remove unnecessary NULL checks [v2,83/83] reorder: remove unnecessary NULL checks

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Stephen Hemminger Jan. 24, 2022, 5:47 p.m. UTC

  Remove redundant NULL pointer checks before free functions
found by nullfree.cocci

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/compressdev/rte_compressdev.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Fan Zhang Jan. 27, 2022, 11:07 a.m. UTC | #1

> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Monday, January 24, 2022 5:47 PM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; Zhang, Roy Fan
> <roy.fan.zhang@intel.com>; Ashish Gupta <ashish.gupta@marvell.com>
> Subject: [PATCH v2 77/83] compressdev: remove unnecessary NULL checks
> 
> Remove redundant NULL pointer checks before free functions
> found by nullfree.cocci
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  lib/compressdev/rte_compressdev.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/lib/compressdev/rte_compressdev.c
> b/lib/compressdev/rte_compressdev.c
> index 2e9218af68f6..d4f7d4d3daf2 100644
> --- a/lib/compressdev/rte_compressdev.c
> +++ b/lib/compressdev/rte_compressdev.c
> @@ -405,8 +405,7 @@ rte_compressdev_queue_pairs_release(struct
> rte_compressdev *dev)
>  			return ret;
>  	}
> 
> -	if (dev->data->queue_pairs != NULL)
> -		rte_free(dev->data->queue_pairs);
> +	rte_free(dev->data->queue_pairs);
>  	dev->data->queue_pairs = NULL;
>  	dev->data->nb_queue_pairs = 0;
> 
> --
> 2.30.2
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>

diff mbox series

Patch

diff --git a/lib/compressdev/rte_compressdev.c b/lib/compressdev/rte_compressdev.c
index 2e9218af68f6..d4f7d4d3daf2 100644
--- a/lib/compressdev/rte_compressdev.c
+++ b/lib/compressdev/rte_compressdev.c
@@ -405,8 +405,7 @@  rte_compressdev_queue_pairs_release(struct rte_compressdev *dev)
 			return ret;
 	}
 
-	if (dev->data->queue_pairs != NULL)
-		rte_free(dev->data->queue_pairs);
+	rte_free(dev->data->queue_pairs);
 	dev->data->queue_pairs = NULL;
 	dev->data->nb_queue_pairs = 0;