[v1] doc: update FIPS docs

Message ID 20220128110801.2573397-1-jakub.poczatek@intel.com (mailing list archive)
State Superseded, archived
Delegated to: akhil goyal
Headers
Series [v1] doc: update FIPS docs |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot: build success github build: passed
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing fail Testing issues
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS

Commit Message

Poczatek, Jakub Jan. 28, 2022, 11:08 a.m. UTC
  Added missing step for converting SHA request files to correct
format. Replaced AES_GCM with GCM to follow the correct
naming format.

Signed-off-by: Jakub Poczatek <jakub.poczatek@intel.com>
---
 doc/guides/sample_app_ug/fips_validation.rst | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
  

Comments

Fan Zhang Jan. 28, 2022, 11:15 a.m. UTC | #1
> -----Original Message-----
> From: Jakub Poczatek <jakub.poczatek@intel.com>
> Sent: Friday, January 28, 2022 11:08 AM
> To: Kovacevic, Marko <marko.kovacevic@intel.com>
> Cc: dev@dpdk.org; Poczatek, Jakub <jakub.poczatek@intel.com>
> Subject: [PATCH v1] doc: update FIPS docs
> 
> Added missing step for converting SHA request files to correct
> format. Replaced AES_GCM with GCM to follow the correct
> naming format.
> 
> Signed-off-by: Jakub Poczatek <jakub.poczatek@intel.com>
> ---
>  doc/guides/sample_app_ug/fips_validation.rst | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/guides/sample_app_ug/fips_validation.rst
> b/doc/guides/sample_app_ug/fips_validation.rst
> index 56df434215..39baea3346 100644
> --- a/doc/guides/sample_app_ug/fips_validation.rst
> +++ b/doc/guides/sample_app_ug/fips_validation.rst
> @@ -77,11 +77,12 @@ Compiling the Application
>      .. code-block:: console
> 
>           dos2unix AES/req/*
> -         dos2unix AES_GCM/req/*
> +         dos2unix GCM/req/*
>           dos2unix CCM/req/*
>           dos2unix CMAC/req/*
>           dos2unix HMAC/req/*
>           dos2unix TDES/req/*
> +         dos2unix SHA/req/*
> 
>  Running the Application
>  -----------------------
> --
> 2.25.1

Hi Jakub, thanks and welcome to the team!
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
  
Akhil Goyal Feb. 8, 2022, 9:41 p.m. UTC | #2
> Added missing step for converting SHA request files to correct
> format. Replaced AES_GCM with GCM to follow the correct
> naming format.
> 
> Signed-off-by: Jakub Poczatek <jakub.poczatek@intel.com>
> ---
Please add Fixes tag where SHA and AES were supported.
Also cc stable@dpdk.org
  

Patch

diff --git a/doc/guides/sample_app_ug/fips_validation.rst b/doc/guides/sample_app_ug/fips_validation.rst
index 56df434215..39baea3346 100644
--- a/doc/guides/sample_app_ug/fips_validation.rst
+++ b/doc/guides/sample_app_ug/fips_validation.rst
@@ -77,11 +77,12 @@  Compiling the Application
     .. code-block:: console
 
          dos2unix AES/req/*
-         dos2unix AES_GCM/req/*
+         dos2unix GCM/req/*
          dos2unix CCM/req/*
          dos2unix CMAC/req/*
          dos2unix HMAC/req/*
          dos2unix TDES/req/*
+         dos2unix SHA/req/*
 
 Running the Application
 -----------------------