diff mbox series

[v2] test: avoid hang if queues are full and Tx fails

Message ID 20210720165052.606038-1-rkudurumalla@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v2] test: avoid hang if queues are full and Tx fails |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot success github build: passed
ci/iol-abi-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS

Commit Message

Rakesh Kudurumalla July 20, 2021, 4:50 p.m. UTC 
  Current pmd_perf_autotest() in continuous mode tries
to enqueue MAX_TRAFFIC_BURST completely before starting
the test. Some drivers cannot accept complete
MAX_TRAFFIC_BURST even though rx+tx desc count can fit it.
This patch changes behaviour to stop enqueuing after few
retries.

Fixes: 002ade70e933 ("app/test: measure cycles per packet in Rx/Tx")
Cc: stable@dpdk.org

Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>
---
v2:
- Fixed commit message errors

 app/test/test_pmd_perf.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Comments

Rakesh Kudurumalla Oct. 19, 2021, 10:19 a.m. UTC | #1 
ping

> -----Original Message-----
> From: Rakesh Kudurumalla <rkudurumalla@marvell.com>
> Sent: Tuesday, July 20, 2021 10:21 PM
> Cc: dev@dpdk.org; Rakesh Kudurumalla <rkudurumalla@marvell.com>;
> stable@dpdk.org
> Subject: [PATCH v2] test: avoid hang if queues are full and Tx fails
> 
> Current pmd_perf_autotest() in continuous mode tries to enqueue
> MAX_TRAFFIC_BURST completely before starting the test. Some drivers
> cannot accept complete MAX_TRAFFIC_BURST even though rx+tx desc count
> can fit it.
> This patch changes behaviour to stop enqueuing after few retries.
> 
> Fixes: 002ade70e933 ("app/test: measure cycles per packet in Rx/Tx")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>
> ---
> v2:
> - Fixed commit message errors
> 
>  app/test/test_pmd_perf.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/app/test/test_pmd_perf.c b/app/test/test_pmd_perf.c index
> 3a248d512c..0a95b408e8 100644
> --- a/app/test/test_pmd_perf.c
> +++ b/app/test/test_pmd_perf.c
> @@ -456,6 +456,7 @@ main_loop(__rte_unused void *args)  #define
> PACKET_SIZE 64  #define FRAME_GAP 12  #define MAC_PREAMBLE 8
> +#define MAX_RETRY_COUNT 5
>  	struct rte_mbuf *pkts_burst[MAX_PKT_BURST];
>  	unsigned lcore_id;
>  	unsigned i, portid, nb_rx = 0, nb_tx = 0; @@ -463,6 +464,8 @@
> main_loop(__rte_unused void *args)
>  	int pkt_per_port;
>  	uint64_t diff_tsc;
>  	uint64_t packets_per_second, total_packets;
> +	int retry_cnt = 0;
> +	int free_pkt = 0;
> 
>  	lcore_id = rte_lcore_id();
>  	conf = &lcore_conf[lcore_id];
> @@ -480,10 +483,19 @@ main_loop(__rte_unused void *args)
>  			nb_tx = RTE_MIN(MAX_PKT_BURST, num);
>  			nb_tx = rte_eth_tx_burst(portid, 0,
>  						&tx_burst[idx], nb_tx);
> +			if (nb_tx == 0)
> +				retry_cnt++;
>  			num -= nb_tx;
>  			idx += nb_tx;
> +			if (retry_cnt == MAX_RETRY_COUNT) {
> +				retry_cnt = 0;
> +				break;
> +			}
>  		}
>  	}
> +	for (free_pkt = idx; free_pkt < (MAX_TRAFFIC_BURST*conf-
> >nb_ports)
> +			; free_pkt++)
> +		rte_pktmbuf_free(tx_burst[free_pkt]);
>  	printf("Total packets inject to prime ports = %u\n", idx);
> 
>  	packets_per_second = (link_mbps * 1000 * 1000) /
> --
> 2.25.1
Rakesh Kudurumalla Oct. 29, 2021, 7:18 a.m. UTC | #2 
ping

> -----Original Message-----
> From: Rakesh Kudurumalla
> Sent: Tuesday, October 19, 2021 3:50 PM
> To: david.marchand@redhat.com
> Cc: dev@dpdk.org; stable@dpdk.org; Rakesh Kudurumalla
> <rkudurumalla@marvell.com>
> Subject: RE: [PATCH v2] test: avoid hang if queues are full and Tx fails
> 
> ping
> 
> > -----Original Message-----
> > From: Rakesh Kudurumalla <rkudurumalla@marvell.com>
> > Sent: Tuesday, July 20, 2021 10:21 PM
> > Cc: dev@dpdk.org; Rakesh Kudurumalla <rkudurumalla@marvell.com>;
> > stable@dpdk.org
> > Subject: [PATCH v2] test: avoid hang if queues are full and Tx fails
> >
> > Current pmd_perf_autotest() in continuous mode tries to enqueue
> > MAX_TRAFFIC_BURST completely before starting the test. Some drivers
> > cannot accept complete MAX_TRAFFIC_BURST even though rx+tx desc
> count
> > can fit it.
> > This patch changes behaviour to stop enqueuing after few retries.
> >
> > Fixes: 002ade70e933 ("app/test: measure cycles per packet in Rx/Tx")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>
> > ---
> > v2:
> > - Fixed commit message errors
> >
> >  app/test/test_pmd_perf.c | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> >
> > diff --git a/app/test/test_pmd_perf.c b/app/test/test_pmd_perf.c index
> > 3a248d512c..0a95b408e8 100644
> > --- a/app/test/test_pmd_perf.c
> > +++ b/app/test/test_pmd_perf.c
> > @@ -456,6 +456,7 @@ main_loop(__rte_unused void *args)  #define
> > PACKET_SIZE 64  #define FRAME_GAP 12  #define MAC_PREAMBLE 8
> > +#define MAX_RETRY_COUNT 5
> >  	struct rte_mbuf *pkts_burst[MAX_PKT_BURST];
> >  	unsigned lcore_id;
> >  	unsigned i, portid, nb_rx = 0, nb_tx = 0; @@ -463,6 +464,8 @@
> > main_loop(__rte_unused void *args)
> >  	int pkt_per_port;
> >  	uint64_t diff_tsc;
> >  	uint64_t packets_per_second, total_packets;
> > +	int retry_cnt = 0;
> > +	int free_pkt = 0;
> >
> >  	lcore_id = rte_lcore_id();
> >  	conf = &lcore_conf[lcore_id];
> > @@ -480,10 +483,19 @@ main_loop(__rte_unused void *args)
> >  			nb_tx = RTE_MIN(MAX_PKT_BURST, num);
> >  			nb_tx = rte_eth_tx_burst(portid, 0,
> >  						&tx_burst[idx], nb_tx);
> > +			if (nb_tx == 0)
> > +				retry_cnt++;
> >  			num -= nb_tx;
> >  			idx += nb_tx;
> > +			if (retry_cnt == MAX_RETRY_COUNT) {
> > +				retry_cnt = 0;
> > +				break;
> > +			}
> >  		}
> >  	}
> > +	for (free_pkt = idx; free_pkt < (MAX_TRAFFIC_BURST*conf-
> > >nb_ports)
> > +			; free_pkt++)
> > +		rte_pktmbuf_free(tx_burst[free_pkt]);
> >  	printf("Total packets inject to prime ports = %u\n", idx);
> >
> >  	packets_per_second = (link_mbps * 1000 * 1000) /
> > --
> > 2.25.1
Thomas Monjalon Nov. 12, 2021, 11:32 a.m. UTC | #3 
20/07/2021 18:50, Rakesh Kudurumalla:
> Current pmd_perf_autotest() in continuous mode tries
> to enqueue MAX_TRAFFIC_BURST completely before starting
> the test. Some drivers cannot accept complete
> MAX_TRAFFIC_BURST even though rx+tx desc count can fit it.

Which driver is failing to do so?
Why it cannot enqueue 32 packets?

> This patch changes behaviour to stop enqueuing after few
> retries.

If there is a real limitation, there will be issues in more places
than this test program.
I feel it should be addressed either in the driver or at ethdev level.

[...]
> @@ -480,10 +483,19 @@ main_loop(__rte_unused void *args)
>  			nb_tx = RTE_MIN(MAX_PKT_BURST, num);
>  			nb_tx = rte_eth_tx_burst(portid, 0,
>  						&tx_burst[idx], nb_tx);
> +			if (nb_tx == 0)
> +				retry_cnt++;
>  			num -= nb_tx;
>  			idx += nb_tx;
> +			if (retry_cnt == MAX_RETRY_COUNT) {
> +				retry_cnt = 0;
> +				break;
> +			}
Rakesh Kudurumalla Nov. 22, 2021, 7:59 a.m. UTC | #4 
Octeontx2 driver is failing to enqueue because hardware buffers are full before test.
pmd_perf_autotest() in continuous mode tries to enqueue MAX_TRAFFIC_BURST (2048)
before starting the test.

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Friday, November 12, 2021 5:02 PM
> To: Rakesh Kudurumalla <rkudurumalla@marvell.com>
> Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com;
> ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> ajit.khaparde@broadcom.com; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>
> Subject: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are full
> and Tx fails
> 
> External Email
> 
> ----------------------------------------------------------------------
> 20/07/2021 18:50, Rakesh Kudurumalla:
> > Current pmd_perf_autotest() in continuous mode tries to enqueue
> > MAX_TRAFFIC_BURST completely before starting the test. Some drivers
> > cannot accept complete MAX_TRAFFIC_BURST even though rx+tx desc
> count
> > can fit it.
> 
> Which driver is failing to do so?
> Why it cannot enqueue 32 packets?
> 
> > This patch changes behaviour to stop enqueuing after few retries.
> 
> If there is a real limitation, there will be issues in more places than this test
> program.
> I feel it should be addressed either in the driver or at ethdev level.
> 
> [...]
> > @@ -480,10 +483,19 @@ main_loop(__rte_unused void *args)
> >  			nb_tx = RTE_MIN(MAX_PKT_BURST, num);
> >  			nb_tx = rte_eth_tx_burst(portid, 0,
> >  						&tx_burst[idx], nb_tx);
> > +			if (nb_tx == 0)
> > +				retry_cnt++;
> >  			num -= nb_tx;
> >  			idx += nb_tx;
> > +			if (retry_cnt == MAX_RETRY_COUNT) {
> > +				retry_cnt = 0;
> > +				break;
> > +			}
> 
>
Thomas Monjalon Nov. 22, 2021, 8:58 a.m. UTC | #5 
22/11/2021 08:59, Rakesh Kudurumalla:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 20/07/2021 18:50, Rakesh Kudurumalla:
> > > Current pmd_perf_autotest() in continuous mode tries to enqueue
> > > MAX_TRAFFIC_BURST completely before starting the test. Some drivers
> > > cannot accept complete MAX_TRAFFIC_BURST even though rx+tx desc
> > count
> > > can fit it.
> > 
> > Which driver is failing to do so?
> > Why it cannot enqueue 32 packets?
> 
> Octeontx2 driver is failing to enqueue because hardware buffers are full before test.

Why hardware buffers are full?

> pmd_perf_autotest() in continuous mode tries to enqueue MAX_TRAFFIC_BURST (2048)
> before starting the test.
> 
> > > This patch changes behaviour to stop enqueuing after few retries.
> > 
> > If there is a real limitation, there will be issues in more places than this test
> > program.
> > I feel it should be addressed either in the driver or at ethdev level.
> > 
> > [...]
> > > @@ -480,10 +483,19 @@ main_loop(__rte_unused void *args)
> > >  			nb_tx = RTE_MIN(MAX_PKT_BURST, num);
> > >  			nb_tx = rte_eth_tx_burst(portid, 0,
> > >  						&tx_burst[idx], nb_tx);
> > > +			if (nb_tx == 0)
> > > +				retry_cnt++;
> > >  			num -= nb_tx;
> > >  			idx += nb_tx;
> > > +			if (retry_cnt == MAX_RETRY_COUNT) {
> > > +				retry_cnt = 0;
> > > +				break;
> > > +			}
Rakesh Kudurumalla Nov. 29, 2021, 8:52 a.m. UTC | #6 
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Monday, November 22, 2021 2:28 PM
> To: Rakesh Kudurumalla <rkudurumalla@marvell.com>
> Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com;
> ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> ajit.khaparde@broadcom.com; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>
> Subject: Re: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are
> full and Tx fails
> 
> 22/11/2021 08:59, Rakesh Kudurumalla:
> > From: Thomas Monjalon <thomas@monjalon.net>
> > > 20/07/2021 18:50, Rakesh Kudurumalla:
> > > > Current pmd_perf_autotest() in continuous mode tries to enqueue
> > > > MAX_TRAFFIC_BURST completely before starting the test. Some
> > > > drivers cannot accept complete MAX_TRAFFIC_BURST even though
> rx+tx
> > > > desc
> > > count
> > > > can fit it.
> > >
> > > Which driver is failing to do so?
> > > Why it cannot enqueue 32 packets?
> >
> > Octeontx2 driver is failing to enqueue because hardware buffers are full
> before test.
> 
> Why hardware buffers are full?
Hardware buffers are full because number of number of descriptors in continuous mode 
Is less than MAX_TRAFFIC_BURST, so if enque fails , there is no way hardware can drop the
Packets . pmd_per_autotest application evaluates performance after enqueueing packets
Initially.
> 
> > pmd_perf_autotest() in continuous mode tries to enqueue
> > MAX_TRAFFIC_BURST (2048) before starting the test.
> >
> > > > This patch changes behaviour to stop enqueuing after few retries.
> > >
> > > If there is a real limitation, there will be issues in more places
> > > than this test program.
> > > I feel it should be addressed either in the driver or at ethdev level.
> > >
> > > [...]
> > > > @@ -480,10 +483,19 @@ main_loop(__rte_unused void *args)
> > > >  			nb_tx = RTE_MIN(MAX_PKT_BURST, num);
> > > >  			nb_tx = rte_eth_tx_burst(portid, 0,
> > > >  						&tx_burst[idx], nb_tx);
> > > > +			if (nb_tx == 0)
> > > > +				retry_cnt++;
> > > >  			num -= nb_tx;
> > > >  			idx += nb_tx;
> > > > +			if (retry_cnt == MAX_RETRY_COUNT) {
> > > > +				retry_cnt = 0;
> > > > +				break;
> > > > +			}
> 
>
Thomas Monjalon Nov. 29, 2021, 9:13 a.m. UTC | #7 
29/11/2021 09:52, Rakesh Kudurumalla:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 22/11/2021 08:59, Rakesh Kudurumalla:
> > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > 20/07/2021 18:50, Rakesh Kudurumalla:
> > > > > Current pmd_perf_autotest() in continuous mode tries to enqueue
> > > > > MAX_TRAFFIC_BURST completely before starting the test. Some
> > > > > drivers cannot accept complete MAX_TRAFFIC_BURST even though
> > rx+tx
> > > > > desc
> > > > count
> > > > > can fit it.
> > > >
> > > > Which driver is failing to do so?
> > > > Why it cannot enqueue 32 packets?
> > >
> > > Octeontx2 driver is failing to enqueue because hardware buffers are full
> > before test.

Aren't you stopping the support of octeontx2?
Why do you care now?

> > 
> > Why hardware buffers are full?
> Hardware buffers are full because number of number of descriptors in continuous mode 
> Is less than MAX_TRAFFIC_BURST, so if enque fails , there is no way hardware can drop the
> Packets . pmd_per_autotest application evaluates performance after enqueueing packets
> Initially.
> > 
> > > pmd_perf_autotest() in continuous mode tries to enqueue
> > > MAX_TRAFFIC_BURST (2048) before starting the test.
> > >
> > > > > This patch changes behaviour to stop enqueuing after few retries.
> > > >
> > > > If there is a real limitation, there will be issues in more places
> > > > than this test program.
> > > > I feel it should be addressed either in the driver or at ethdev level.
> > > >
> > > > [...]
> > > > > @@ -480,10 +483,19 @@ main_loop(__rte_unused void *args)
> > > > >  			nb_tx = RTE_MIN(MAX_PKT_BURST, num);
> > > > >  			nb_tx = rte_eth_tx_burst(portid, 0,
> > > > >  						&tx_burst[idx], nb_tx);
> > > > > +			if (nb_tx == 0)
> > > > > +				retry_cnt++;
> > > > >  			num -= nb_tx;
> > > > >  			idx += nb_tx;
> > > > > +			if (retry_cnt == MAX_RETRY_COUNT) {
> > > > > +				retry_cnt = 0;
> > > > > +				break;
> > > > > +			}
Rakesh Kudurumalla Dec. 13, 2021, 6:40 a.m. UTC | #8 
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Monday, November 29, 2021 2:44 PM
> To: Rakesh Kudurumalla <rkudurumalla@marvell.com>; Jerin Jacob
> Kollanukkaran <jerinj@marvell.com>
> Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com;
> ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> ajit.khaparde@broadcom.com
> Subject: Re: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are
> full and Tx fails
> 
> 29/11/2021 09:52, Rakesh Kudurumalla:
> > From: Thomas Monjalon <thomas@monjalon.net>
> > > 22/11/2021 08:59, Rakesh Kudurumalla:
> > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > 20/07/2021 18:50, Rakesh Kudurumalla:
> > > > > > Current pmd_perf_autotest() in continuous mode tries to
> > > > > > enqueue MAX_TRAFFIC_BURST completely before starting the test.
> > > > > > Some drivers cannot accept complete MAX_TRAFFIC_BURST even
> > > > > > though
> > > rx+tx
> > > > > > desc
> > > > > count
> > > > > > can fit it.
> > > > >
> > > > > Which driver is failing to do so?
> > > > > Why it cannot enqueue 32 packets?
> > > >
> > > > Octeontx2 driver is failing to enqueue because hardware buffers
> > > > are full
> > > before test.
> 
> Aren't you stopping the support of octeontx2?
> Why do you care now?
>  yes we are not supporting octeontx2,but this  issue is observed in cnxk driver ,current patch fixes the same
> > >
> > > Why hardware buffers are full?
> > Hardware buffers are full because number of number of descriptors in
> > continuous mode Is less than MAX_TRAFFIC_BURST, so if enque fails ,
> > there is no way hardware can drop the Packets . pmd_per_autotest
> > application evaluates performance after enqueueing packets Initially.
> > >
> > > > pmd_perf_autotest() in continuous mode tries to enqueue
> > > > MAX_TRAFFIC_BURST (2048) before starting the test.
> > > >
> > > > > > This patch changes behaviour to stop enqueuing after few retries.
> > > > >
> > > > > If there is a real limitation, there will be issues in more
> > > > > places than this test program.
> > > > > I feel it should be addressed either in the driver or at ethdev level.
> > > > >
> > > > > [...]
> > > > > > @@ -480,10 +483,19 @@ main_loop(__rte_unused void *args)
> > > > > >  			nb_tx = RTE_MIN(MAX_PKT_BURST, num);
> > > > > >  			nb_tx = rte_eth_tx_burst(portid, 0,
> > > > > >  						&tx_burst[idx],
> nb_tx);
> > > > > > +			if (nb_tx == 0)
> > > > > > +				retry_cnt++;
> > > > > >  			num -= nb_tx;
> > > > > >  			idx += nb_tx;
> > > > > > +			if (retry_cnt == MAX_RETRY_COUNT) {
> > > > > > +				retry_cnt = 0;
> > > > > > +				break;
> > > > > > +			}
> 
>
Rakesh Kudurumalla Jan. 10, 2022, 9:04 a.m. UTC | #9 
ping

> -----Original Message-----
> From: Rakesh Kudurumalla
> Sent: Monday, December 13, 2021 12:10 PM
> To: Thomas Monjalon <thomas@monjalon.net>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>
> Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com;
> ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> ajit.khaparde@broadcom.com
> Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are
> full and Tx fails
> 
> 
> 
> > -----Original Message-----
> > From: Thomas Monjalon <thomas@monjalon.net>
> > Sent: Monday, November 29, 2021 2:44 PM
> > To: Rakesh Kudurumalla <rkudurumalla@marvell.com>; Jerin Jacob
> > Kollanukkaran <jerinj@marvell.com>
> > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com;
> > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> > ajit.khaparde@broadcom.com
> > Subject: Re: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if
> > queues are full and Tx fails
> >
> > 29/11/2021 09:52, Rakesh Kudurumalla:
> > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > 22/11/2021 08:59, Rakesh Kudurumalla:
> > > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > > 20/07/2021 18:50, Rakesh Kudurumalla:
> > > > > > > Current pmd_perf_autotest() in continuous mode tries to
> > > > > > > enqueue MAX_TRAFFIC_BURST completely before starting the test.
> > > > > > > Some drivers cannot accept complete MAX_TRAFFIC_BURST even
> > > > > > > though
> > > > rx+tx
> > > > > > > desc
> > > > > > count
> > > > > > > can fit it.
> > > > > >
> > > > > > Which driver is failing to do so?
> > > > > > Why it cannot enqueue 32 packets?
> > > > >
> > > > > Octeontx2 driver is failing to enqueue because hardware buffers
> > > > > are full
> > > > before test.
> >
> > Aren't you stopping the support of octeontx2?
> > Why do you care now?
> >  yes we are not supporting octeontx2,but this  issue is observed in
> > cnxk driver ,current patch fixes the same
> > > >
> > > > Why hardware buffers are full?
> > > Hardware buffers are full because number of number of descriptors in
> > > continuous mode Is less than MAX_TRAFFIC_BURST, so if enque fails ,
> > > there is no way hardware can drop the Packets . pmd_per_autotest
> > > application evaluates performance after enqueueing packets Initially.
> > > >
> > > > > pmd_perf_autotest() in continuous mode tries to enqueue
> > > > > MAX_TRAFFIC_BURST (2048) before starting the test.
> > > > >
> > > > > > > This patch changes behaviour to stop enqueuing after few retries.
> > > > > >
> > > > > > If there is a real limitation, there will be issues in more
> > > > > > places than this test program.
> > > > > > I feel it should be addressed either in the driver or at ethdev level.
> > > > > >
> > > > > > [...]
> > > > > > > @@ -480,10 +483,19 @@ main_loop(__rte_unused void *args)
> > > > > > >  			nb_tx = RTE_MIN(MAX_PKT_BURST, num);
> > > > > > >  			nb_tx = rte_eth_tx_burst(portid, 0,
> > > > > > >  						&tx_burst[idx],
> > nb_tx);
> > > > > > > +			if (nb_tx == 0)
> > > > > > > +				retry_cnt++;
> > > > > > >  			num -= nb_tx;
> > > > > > >  			idx += nb_tx;
> > > > > > > +			if (retry_cnt == MAX_RETRY_COUNT) {
> > > > > > > +				retry_cnt = 0;
> > > > > > > +				break;
> > > > > > > +			}
> >
> >
Rakesh Kudurumalla Feb. 1, 2022, 6:30 a.m. UTC | #10 
ping

> -----Original Message-----
> From: Rakesh Kudurumalla
> Sent: Monday, January 10, 2022 2:35 PM
> To: Thomas Monjalon <thomas@monjalon.net>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>
> Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com;
> ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> ajit.khaparde@broadcom.com
> Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are
> full and Tx fails
> 
> ping
> 
> > -----Original Message-----
> > From: Rakesh Kudurumalla
> > Sent: Monday, December 13, 2021 12:10 PM
> > To: Thomas Monjalon <thomas@monjalon.net>; Jerin Jacob Kollanukkaran
> > <jerinj@marvell.com>
> > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com;
> > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> > ajit.khaparde@broadcom.com
> > Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if
> > queues are full and Tx fails
> >
> >
> >
> > > -----Original Message-----
> > > From: Thomas Monjalon <thomas@monjalon.net>
> > > Sent: Monday, November 29, 2021 2:44 PM
> > > To: Rakesh Kudurumalla <rkudurumalla@marvell.com>; Jerin Jacob
> > > Kollanukkaran <jerinj@marvell.com>
> > > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com;
> > > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> > > ajit.khaparde@broadcom.com
> > > Subject: Re: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if
> > > queues are full and Tx fails
> > >
> > > 29/11/2021 09:52, Rakesh Kudurumalla:
> > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > 22/11/2021 08:59, Rakesh Kudurumalla:
> > > > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > > > 20/07/2021 18:50, Rakesh Kudurumalla:
> > > > > > > > Current pmd_perf_autotest() in continuous mode tries to
> > > > > > > > enqueue MAX_TRAFFIC_BURST completely before starting the
> test.
> > > > > > > > Some drivers cannot accept complete MAX_TRAFFIC_BURST even
> > > > > > > > though
> > > > > rx+tx
> > > > > > > > desc
> > > > > > > count
> > > > > > > > can fit it.
> > > > > > >
> > > > > > > Which driver is failing to do so?
> > > > > > > Why it cannot enqueue 32 packets?
> > > > > >
> > > > > > Octeontx2 driver is failing to enqueue because hardware
> > > > > > buffers are full
> > > > > before test.
> > >
> > > Aren't you stopping the support of octeontx2?
> > > Why do you care now?
> > >  yes we are not supporting octeontx2,but this  issue is observed in
> > > cnxk driver ,current patch fixes the same
> > > > >
> > > > > Why hardware buffers are full?
> > > > Hardware buffers are full because number of number of descriptors
> > > > in continuous mode Is less than MAX_TRAFFIC_BURST, so if enque
> > > > fails , there is no way hardware can drop the Packets .
> > > > pmd_per_autotest application evaluates performance after enqueueing
> packets Initially.
> > > > >
> > > > > > pmd_perf_autotest() in continuous mode tries to enqueue
> > > > > > MAX_TRAFFIC_BURST (2048) before starting the test.
> > > > > >
> > > > > > > > This patch changes behaviour to stop enqueuing after few
> retries.
> > > > > > >
> > > > > > > If there is a real limitation, there will be issues in more
> > > > > > > places than this test program.
> > > > > > > I feel it should be addressed either in the driver or at ethdev level.
> > > > > > >
> > > > > > > [...]
> > > > > > > > @@ -480,10 +483,19 @@ main_loop(__rte_unused void *args)
> > > > > > > >  			nb_tx = RTE_MIN(MAX_PKT_BURST, num);
> > > > > > > >  			nb_tx = rte_eth_tx_burst(portid, 0,
> > > > > > > >  						&tx_burst[idx],
> > > nb_tx);
> > > > > > > > +			if (nb_tx == 0)
> > > > > > > > +				retry_cnt++;
> > > > > > > >  			num -= nb_tx;
> > > > > > > >  			idx += nb_tx;
> > > > > > > > +			if (retry_cnt == MAX_RETRY_COUNT) {
> > > > > > > > +				retry_cnt = 0;
> > > > > > > > +				break;
> > > > > > > > +			}
> > >
> > >
Thomas Monjalon Feb. 1, 2022, 7:44 a.m. UTC | #11 
octeontx2 driver is removed
Can we close this patch?


01/02/2022 07:30, Rakesh Kudurumalla:
> ping
> 
> > -----Original Message-----
> > From: Rakesh Kudurumalla
> > Sent: Monday, January 10, 2022 2:35 PM
> > To: Thomas Monjalon <thomas@monjalon.net>; Jerin Jacob Kollanukkaran
> > <jerinj@marvell.com>
> > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com;
> > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> > ajit.khaparde@broadcom.com
> > Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are
> > full and Tx fails
> > 
> > ping
> > 
> > > -----Original Message-----
> > > From: Rakesh Kudurumalla
> > > Sent: Monday, December 13, 2021 12:10 PM
> > > To: Thomas Monjalon <thomas@monjalon.net>; Jerin Jacob Kollanukkaran
> > > <jerinj@marvell.com>
> > > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com;
> > > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> > > ajit.khaparde@broadcom.com
> > > Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if
> > > queues are full and Tx fails
> > >
> > >
> > >
> > > > -----Original Message-----
> > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > Sent: Monday, November 29, 2021 2:44 PM
> > > > To: Rakesh Kudurumalla <rkudurumalla@marvell.com>; Jerin Jacob
> > > > Kollanukkaran <jerinj@marvell.com>
> > > > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com;
> > > > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> > > > ajit.khaparde@broadcom.com
> > > > Subject: Re: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if
> > > > queues are full and Tx fails
> > > >
> > > > 29/11/2021 09:52, Rakesh Kudurumalla:
> > > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > > 22/11/2021 08:59, Rakesh Kudurumalla:
> > > > > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > > > > 20/07/2021 18:50, Rakesh Kudurumalla:
> > > > > > > > > Current pmd_perf_autotest() in continuous mode tries to
> > > > > > > > > enqueue MAX_TRAFFIC_BURST completely before starting the
> > test.
> > > > > > > > > Some drivers cannot accept complete MAX_TRAFFIC_BURST even
> > > > > > > > > though
> > > > > > rx+tx
> > > > > > > > > desc
> > > > > > > > count
> > > > > > > > > can fit it.
> > > > > > > >
> > > > > > > > Which driver is failing to do so?
> > > > > > > > Why it cannot enqueue 32 packets?
> > > > > > >
> > > > > > > Octeontx2 driver is failing to enqueue because hardware
> > > > > > > buffers are full
> > > > > > before test.
> > > >
> > > > Aren't you stopping the support of octeontx2?
> > > > Why do you care now?
> > > >  yes we are not supporting octeontx2,but this  issue is observed in
> > > > cnxk driver ,current patch fixes the same
> > > > > >
> > > > > > Why hardware buffers are full?
> > > > > Hardware buffers are full because number of number of descriptors
> > > > > in continuous mode Is less than MAX_TRAFFIC_BURST, so if enque
> > > > > fails , there is no way hardware can drop the Packets .
> > > > > pmd_per_autotest application evaluates performance after enqueueing
> > packets Initially.
> > > > > >
> > > > > > > pmd_perf_autotest() in continuous mode tries to enqueue
> > > > > > > MAX_TRAFFIC_BURST (2048) before starting the test.
> > > > > > >
> > > > > > > > > This patch changes behaviour to stop enqueuing after few
> > retries.
> > > > > > > >
> > > > > > > > If there is a real limitation, there will be issues in more
> > > > > > > > places than this test program.
> > > > > > > > I feel it should be addressed either in the driver or at ethdev level.
> > > > > > > >
> > > > > > > > [...]
> > > > > > > > > @@ -480,10 +483,19 @@ main_loop(__rte_unused void *args)
> > > > > > > > >  			nb_tx = RTE_MIN(MAX_PKT_BURST, num);
> > > > > > > > >  			nb_tx = rte_eth_tx_burst(portid, 0,
> > > > > > > > >  						&tx_burst[idx],
> > > > nb_tx);
> > > > > > > > > +			if (nb_tx == 0)
> > > > > > > > > +				retry_cnt++;
> > > > > > > > >  			num -= nb_tx;
> > > > > > > > >  			idx += nb_tx;
> > > > > > > > > +			if (retry_cnt == MAX_RETRY_COUNT) {
> > > > > > > > > +				retry_cnt = 0;
> > > > > > > > > +				break;
> > > > > > > > > +			}
> > > >
> > > >
> 
>
Rakesh Kudurumalla Feb. 14, 2022, 4:56 a.m. UTC | #12 
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Tuesday, February 1, 2022 1:15 PM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Rakesh Kudurumalla
> <rkudurumalla@marvell.com>
> Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com;
> ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> ajit.khaparde@broadcom.com
> Subject: Re: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are
> full and Tx fails
> 
> octeontx2 driver is removed
> Can we close this patch?
Same behavior is observed with cnxk driver, so we need  this patch 
> 
> 
> 01/02/2022 07:30, Rakesh Kudurumalla:
> > ping
> >
> > > -----Original Message-----
> > > From: Rakesh Kudurumalla
> > > Sent: Monday, January 10, 2022 2:35 PM
> > > To: Thomas Monjalon <thomas@monjalon.net>; Jerin Jacob
> Kollanukkaran
> > > <jerinj@marvell.com>
> > > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com;
> > > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> > > ajit.khaparde@broadcom.com
> > > Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if
> > > queues are full and Tx fails
> > >
> > > ping
> > >
> > > > -----Original Message-----
> > > > From: Rakesh Kudurumalla
> > > > Sent: Monday, December 13, 2021 12:10 PM
> > > > To: Thomas Monjalon <thomas@monjalon.net>; Jerin Jacob
> > > > Kollanukkaran <jerinj@marvell.com>
> > > > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com;
> > > > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> > > > ajit.khaparde@broadcom.com
> > > > Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang
> > > > if queues are full and Tx fails
> > > >
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > Sent: Monday, November 29, 2021 2:44 PM
> > > > > To: Rakesh Kudurumalla <rkudurumalla@marvell.com>; Jerin Jacob
> > > > > Kollanukkaran <jerinj@marvell.com>
> > > > > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com;
> > > > > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> > > > > ajit.khaparde@broadcom.com
> > > > > Subject: Re: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang
> > > > > if queues are full and Tx fails
> > > > >
> > > > > 29/11/2021 09:52, Rakesh Kudurumalla:
> > > > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > > > 22/11/2021 08:59, Rakesh Kudurumalla:
> > > > > > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > > > > > 20/07/2021 18:50, Rakesh Kudurumalla:
> > > > > > > > > > Current pmd_perf_autotest() in continuous mode tries
> > > > > > > > > > to enqueue MAX_TRAFFIC_BURST completely before
> > > > > > > > > > starting the
> > > test.
> > > > > > > > > > Some drivers cannot accept complete MAX_TRAFFIC_BURST
> > > > > > > > > > even though
> > > > > > > rx+tx
> > > > > > > > > > desc
> > > > > > > > > count
> > > > > > > > > > can fit it.
> > > > > > > > >
> > > > > > > > > Which driver is failing to do so?
> > > > > > > > > Why it cannot enqueue 32 packets?
> > > > > > > >
> > > > > > > > Octeontx2 driver is failing to enqueue because hardware
> > > > > > > > buffers are full
> > > > > > > before test.
> > > > >
> > > > > Aren't you stopping the support of octeontx2?
> > > > > Why do you care now?
> > > > >  yes we are not supporting octeontx2,but this  issue is observed
> > > > > in cnxk driver ,current patch fixes the same
> > > > > > >
> > > > > > > Why hardware buffers are full?
> > > > > > Hardware buffers are full because number of number of
> > > > > > descriptors in continuous mode Is less than MAX_TRAFFIC_BURST,
> > > > > > so if enque fails , there is no way hardware can drop the Packets .
> > > > > > pmd_per_autotest application evaluates performance after
> > > > > > enqueueing
> > > packets Initially.
> > > > > > >
> > > > > > > > pmd_perf_autotest() in continuous mode tries to enqueue
> > > > > > > > MAX_TRAFFIC_BURST (2048) before starting the test.
> > > > > > > >
> > > > > > > > > > This patch changes behaviour to stop enqueuing after
> > > > > > > > > > few
> > > retries.
> > > > > > > > >
> > > > > > > > > If there is a real limitation, there will be issues in
> > > > > > > > > more places than this test program.
> > > > > > > > > I feel it should be addressed either in the driver or at ethdev
> level.
> > > > > > > > >
> > > > > > > > > [...]
> > > > > > > > > > @@ -480,10 +483,19 @@ main_loop(__rte_unused void
> *args)
> > > > > > > > > >  			nb_tx = RTE_MIN(MAX_PKT_BURST,
> num);
> > > > > > > > > >  			nb_tx = rte_eth_tx_burst(portid, 0,
> > > > > > > > > >
> 	&tx_burst[idx],
> > > > > nb_tx);
> > > > > > > > > > +			if (nb_tx == 0)
> > > > > > > > > > +				retry_cnt++;
> > > > > > > > > >  			num -= nb_tx;
> > > > > > > > > >  			idx += nb_tx;
> > > > > > > > > > +			if (retry_cnt == MAX_RETRY_COUNT)
> {
> > > > > > > > > > +				retry_cnt = 0;
> > > > > > > > > > +				break;
> > > > > > > > > > +			}
> > > > >
> > > > >
> >
> >
> 
> 
> 
>
Rakesh Kudurumalla May 9, 2022, 10:01 a.m. UTC | #13 
Hi Thomas Monjalon,

Same behavior is observed in cnxk driver as well.
Can we please get this patch merged ?

Regards,
Rakesh 
> -----Original Message-----
> From: Rakesh Kudurumalla
> Sent: Monday, February 14, 2022 10:27 AM
> To: Thomas Monjalon <thomas@monjalon.net>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>
> Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com;
> ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> ajit.khaparde@broadcom.com
> Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are
> full and Tx fails
> 
> 
> 
> > -----Original Message-----
> > From: Thomas Monjalon <thomas@monjalon.net>
> > Sent: Tuesday, February 1, 2022 1:15 PM
> > To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Rakesh Kudurumalla
> > <rkudurumalla@marvell.com>
> > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com;
> > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> > ajit.khaparde@broadcom.com
> > Subject: Re: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if
> > queues are full and Tx fails
> >
> > octeontx2 driver is removed
> > Can we close this patch?
> Same behavior is observed with cnxk driver, so we need  this patch
> >
> >
> > 01/02/2022 07:30, Rakesh Kudurumalla:
> > > ping
> > >
> > > > -----Original Message-----
> > > > From: Rakesh Kudurumalla
> > > > Sent: Monday, January 10, 2022 2:35 PM
> > > > To: Thomas Monjalon <thomas@monjalon.net>; Jerin Jacob
> > Kollanukkaran
> > > > <jerinj@marvell.com>
> > > > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com;
> > > > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> > > > ajit.khaparde@broadcom.com
> > > > Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang
> > > > if queues are full and Tx fails
> > > >
> > > > ping
> > > >
> > > > > -----Original Message-----
> > > > > From: Rakesh Kudurumalla
> > > > > Sent: Monday, December 13, 2021 12:10 PM
> > > > > To: Thomas Monjalon <thomas@monjalon.net>; Jerin Jacob
> > > > > Kollanukkaran <jerinj@marvell.com>
> > > > > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com;
> > > > > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> > > > > ajit.khaparde@broadcom.com
> > > > > Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang
> > > > > if queues are full and Tx fails
> > > > >
> > > > >
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > > Sent: Monday, November 29, 2021 2:44 PM
> > > > > > To: Rakesh Kudurumalla <rkudurumalla@marvell.com>; Jerin Jacob
> > > > > > Kollanukkaran <jerinj@marvell.com>
> > > > > > Cc: stable@dpdk.org; dev@dpdk.org;
> david.marchand@redhat.com;
> > > > > > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> > > > > > ajit.khaparde@broadcom.com
> > > > > > Subject: Re: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid
> > > > > > hang if queues are full and Tx fails
> > > > > >
> > > > > > 29/11/2021 09:52, Rakesh Kudurumalla:
> > > > > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > > > > 22/11/2021 08:59, Rakesh Kudurumalla:
> > > > > > > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > > > > > > 20/07/2021 18:50, Rakesh Kudurumalla:
> > > > > > > > > > > Current pmd_perf_autotest() in continuous mode tries
> > > > > > > > > > > to enqueue MAX_TRAFFIC_BURST completely before
> > > > > > > > > > > starting the
> > > > test.
> > > > > > > > > > > Some drivers cannot accept complete
> > > > > > > > > > > MAX_TRAFFIC_BURST even though
> > > > > > > > rx+tx
> > > > > > > > > > > desc
> > > > > > > > > > count
> > > > > > > > > > > can fit it.
> > > > > > > > > >
> > > > > > > > > > Which driver is failing to do so?
> > > > > > > > > > Why it cannot enqueue 32 packets?
> > > > > > > > >
> > > > > > > > > Octeontx2 driver is failing to enqueue because hardware
> > > > > > > > > buffers are full
> > > > > > > > before test.
> > > > > >
> > > > > > Aren't you stopping the support of octeontx2?
> > > > > > Why do you care now?
> > > > > >  yes we are not supporting octeontx2,but this  issue is
> > > > > > observed in cnxk driver ,current patch fixes the same
> > > > > > > >
> > > > > > > > Why hardware buffers are full?
> > > > > > > Hardware buffers are full because number of number of
> > > > > > > descriptors in continuous mode Is less than
> > > > > > > MAX_TRAFFIC_BURST, so if enque fails , there is no way hardware
> can drop the Packets .
> > > > > > > pmd_per_autotest application evaluates performance after
> > > > > > > enqueueing
> > > > packets Initially.
> > > > > > > >
> > > > > > > > > pmd_perf_autotest() in continuous mode tries to enqueue
> > > > > > > > > MAX_TRAFFIC_BURST (2048) before starting the test.
> > > > > > > > >
> > > > > > > > > > > This patch changes behaviour to stop enqueuing after
> > > > > > > > > > > few
> > > > retries.
> > > > > > > > > >
> > > > > > > > > > If there is a real limitation, there will be issues in
> > > > > > > > > > more places than this test program.
> > > > > > > > > > I feel it should be addressed either in the driver or
> > > > > > > > > > at ethdev
> > level.
> > > > > > > > > >
> > > > > > > > > > [...]
> > > > > > > > > > > @@ -480,10 +483,19 @@ main_loop(__rte_unused void
> > *args)
> > > > > > > > > > >  			nb_tx = RTE_MIN(MAX_PKT_BURST,
> > num);
> > > > > > > > > > >  			nb_tx = rte_eth_tx_burst(portid, 0,
> > > > > > > > > > >
> > 	&tx_burst[idx],
> > > > > > nb_tx);
> > > > > > > > > > > +			if (nb_tx == 0)
> > > > > > > > > > > +				retry_cnt++;
> > > > > > > > > > >  			num -= nb_tx;
> > > > > > > > > > >  			idx += nb_tx;
> > > > > > > > > > > +			if (retry_cnt == MAX_RETRY_COUNT)
> > {
> > > > > > > > > > > +				retry_cnt = 0;
> > > > > > > > > > > +				break;
> > > > > > > > > > > +			}
> > > > > >
> > > > > >
> > >
> > >
> >
> >
> >
> >
Rakesh Kudurumalla May 24, 2022, 5:39 a.m. UTC | #14 
ping

> -----Original Message-----
> From: Rakesh Kudurumalla
> Sent: Monday, May 9, 2022 3:32 PM
> To: 'Thomas Monjalon' <thomas@monjalon.net>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>
> Cc: 'stable@dpdk.org' <stable@dpdk.org>; 'dev@dpdk.org'
> <dev@dpdk.org>; 'david.marchand@redhat.com'
> <david.marchand@redhat.com>; 'ferruh.yigit@intel.com'
> <ferruh.yigit@intel.com>; 'andrew.rybchenko@oktetlabs.ru'
> <andrew.rybchenko@oktetlabs.ru>; 'ajit.khaparde@broadcom.com'
> <ajit.khaparde@broadcom.com>
> Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are
> full and Tx fails
> 
> Hi Thomas Monjalon,
> 
> Same behavior is observed in cnxk driver as well.
> Can we please get this patch merged ?
> 
> Regards,
> Rakesh
> > -----Original Message-----
> > From: Rakesh Kudurumalla
> > Sent: Monday, February 14, 2022 10:27 AM
> > To: Thomas Monjalon <thomas@monjalon.net>; Jerin Jacob Kollanukkaran
> > <jerinj@marvell.com>
> > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com;
> > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> > ajit.khaparde@broadcom.com
> > Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if
> > queues are full and Tx fails
> >
> >
> >
> > > -----Original Message-----
> > > From: Thomas Monjalon <thomas@monjalon.net>
> > > Sent: Tuesday, February 1, 2022 1:15 PM
> > > To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Rakesh
> > > Kudurumalla <rkudurumalla@marvell.com>
> > > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com;
> > > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> > > ajit.khaparde@broadcom.com
> > > Subject: Re: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if
> > > queues are full and Tx fails
> > >
> > > octeontx2 driver is removed
> > > Can we close this patch?
> > Same behavior is observed with cnxk driver, so we need  this patch
> > >
> > >
> > > 01/02/2022 07:30, Rakesh Kudurumalla:
> > > > ping
> > > >
> > > > > -----Original Message-----
> > > > > From: Rakesh Kudurumalla
> > > > > Sent: Monday, January 10, 2022 2:35 PM
> > > > > To: Thomas Monjalon <thomas@monjalon.net>; Jerin Jacob
> > > Kollanukkaran
> > > > > <jerinj@marvell.com>
> > > > > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com;
> > > > > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> > > > > ajit.khaparde@broadcom.com
> > > > > Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang
> > > > > if queues are full and Tx fails
> > > > >
> > > > > ping
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: Rakesh Kudurumalla
> > > > > > Sent: Monday, December 13, 2021 12:10 PM
> > > > > > To: Thomas Monjalon <thomas@monjalon.net>; Jerin Jacob
> > > > > > Kollanukkaran <jerinj@marvell.com>
> > > > > > Cc: stable@dpdk.org; dev@dpdk.org;
> david.marchand@redhat.com;
> > > > > > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> > > > > > ajit.khaparde@broadcom.com
> > > > > > Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid
> > > > > > hang if queues are full and Tx fails
> > > > > >
> > > > > >
> > > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > > > Sent: Monday, November 29, 2021 2:44 PM
> > > > > > > To: Rakesh Kudurumalla <rkudurumalla@marvell.com>; Jerin
> > > > > > > Jacob Kollanukkaran <jerinj@marvell.com>
> > > > > > > Cc: stable@dpdk.org; dev@dpdk.org;
> > david.marchand@redhat.com;
> > > > > > > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> > > > > > > ajit.khaparde@broadcom.com
> > > > > > > Subject: Re: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid
> > > > > > > hang if queues are full and Tx fails
> > > > > > >
> > > > > > > 29/11/2021 09:52, Rakesh Kudurumalla:
> > > > > > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > > > > > 22/11/2021 08:59, Rakesh Kudurumalla:
> > > > > > > > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > > > > > > > 20/07/2021 18:50, Rakesh Kudurumalla:
> > > > > > > > > > > > Current pmd_perf_autotest() in continuous mode
> > > > > > > > > > > > tries to enqueue MAX_TRAFFIC_BURST completely
> > > > > > > > > > > > before starting the
> > > > > test.
> > > > > > > > > > > > Some drivers cannot accept complete
> > > > > > > > > > > > MAX_TRAFFIC_BURST even though
> > > > > > > > > rx+tx
> > > > > > > > > > > > desc
> > > > > > > > > > > count
> > > > > > > > > > > > can fit it.
> > > > > > > > > > >
> > > > > > > > > > > Which driver is failing to do so?
> > > > > > > > > > > Why it cannot enqueue 32 packets?
> > > > > > > > > >
> > > > > > > > > > Octeontx2 driver is failing to enqueue because
> > > > > > > > > > hardware buffers are full
> > > > > > > > > before test.
> > > > > > >
> > > > > > > Aren't you stopping the support of octeontx2?
> > > > > > > Why do you care now?
> > > > > > >  yes we are not supporting octeontx2,but this  issue is
> > > > > > > observed in cnxk driver ,current patch fixes the same
> > > > > > > > >
> > > > > > > > > Why hardware buffers are full?
> > > > > > > > Hardware buffers are full because number of number of
> > > > > > > > descriptors in continuous mode Is less than
> > > > > > > > MAX_TRAFFIC_BURST, so if enque fails , there is no way
> > > > > > > > hardware
> > can drop the Packets .
> > > > > > > > pmd_per_autotest application evaluates performance after
> > > > > > > > enqueueing
> > > > > packets Initially.
> > > > > > > > >
> > > > > > > > > > pmd_perf_autotest() in continuous mode tries to
> > > > > > > > > > enqueue MAX_TRAFFIC_BURST (2048) before starting the
> test.
> > > > > > > > > >
> > > > > > > > > > > > This patch changes behaviour to stop enqueuing
> > > > > > > > > > > > after few
> > > > > retries.
> > > > > > > > > > >
> > > > > > > > > > > If there is a real limitation, there will be issues
> > > > > > > > > > > in more places than this test program.
> > > > > > > > > > > I feel it should be addressed either in the driver
> > > > > > > > > > > or at ethdev
> > > level.
> > > > > > > > > > >
> > > > > > > > > > > [...]
> > > > > > > > > > > > @@ -480,10 +483,19 @@ main_loop(__rte_unused void
> > > *args)
> > > > > > > > > > > >  			nb_tx = RTE_MIN(MAX_PKT_BURST,
> > > num);
> > > > > > > > > > > >  			nb_tx = rte_eth_tx_burst(portid, 0,
> > > > > > > > > > > >
> > > 	&tx_burst[idx],
> > > > > > > nb_tx);
> > > > > > > > > > > > +			if (nb_tx == 0)
> > > > > > > > > > > > +				retry_cnt++;
> > > > > > > > > > > >  			num -= nb_tx;
> > > > > > > > > > > >  			idx += nb_tx;
> > > > > > > > > > > > +			if (retry_cnt == MAX_RETRY_COUNT)
> > > {
> > > > > > > > > > > > +				retry_cnt = 0;
> > > > > > > > > > > > +				break;
> > > > > > > > > > > > +			}
> > > > > > >
> > > > > > >
> > > >
> > > >
> > >
> > >
> > >
> > >
Thomas Monjalon May 25, 2022, 8:02 a.m. UTC | #15 
I'm pretty sure there is something wrong in the driver cnxk,
but you keep insisting and nobody complained,
so I accept the patch for the test application.

Applied


24/05/2022 07:39, Rakesh Kudurumalla:
> ping
> 
> > From: Rakesh Kudurumalla
> > Sent: Monday, May 9, 2022 3:32 PM
> > 
> > Hi Thomas Monjalon,
> > 
> > Same behavior is observed in cnxk driver as well.
> > Can we please get this patch merged ?
> > 
> > > From: Rakesh Kudurumalla
> > > Sent: Monday, February 14, 2022 10:27 AM
> > > >
> > > > octeontx2 driver is removed
> > > > Can we close this patch?
> > > Same behavior is observed with cnxk driver, so we need  this patch
> > > >
> > > > 01/02/2022 07:30, Rakesh Kudurumalla:
> > > > > ping
> > > > >
> > > > > > From: Rakesh Kudurumalla
> > > > > > Sent: Monday, January 10, 2022 2:35 PM
> > > > > >
> > > > > > ping
> > > > > >
> > > > > > > From: Rakesh Kudurumalla
> > > > > > > Sent: Monday, December 13, 2021 12:10 PM
> > > > > > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > > > > Sent: Monday, November 29, 2021 2:44 PM
> > > > > > > > 29/11/2021 09:52, Rakesh Kudurumalla:
> > > > > > > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > > > > > > 22/11/2021 08:59, Rakesh Kudurumalla:
> > > > > > > > > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > > > > > > > > 20/07/2021 18:50, Rakesh Kudurumalla:
> > > > > > > > > > > > > Current pmd_perf_autotest() in continuous mode
> > > > > > > > > > > > > tries to enqueue MAX_TRAFFIC_BURST completely
> > > > > > > > > > > > > before starting the
> > > > > > test.
> > > > > > > > > > > > > Some drivers cannot accept complete
> > > > > > > > > > > > > MAX_TRAFFIC_BURST even though
> > > > > > > > > > rx+tx
> > > > > > > > > > > > > desc
> > > > > > > > > > > > count
> > > > > > > > > > > > > can fit it.
> > > > > > > > > > > >
> > > > > > > > > > > > Which driver is failing to do so?
> > > > > > > > > > > > Why it cannot enqueue 32 packets?
> > > > > > > > > > >
> > > > > > > > > > > Octeontx2 driver is failing to enqueue because
> > > > > > > > > > > hardware buffers are full
> > > > > > > > > > before test.
> > > > > > > >
> > > > > > > > Aren't you stopping the support of octeontx2?
> > > > > > > > Why do you care now?
> > > > > > > >  yes we are not supporting octeontx2,but this  issue is
> > > > > > > > observed in cnxk driver ,current patch fixes the same
> > > > > > > > > >
> > > > > > > > > > Why hardware buffers are full?
> > > > > > > > > Hardware buffers are full because number of number of
> > > > > > > > > descriptors in continuous mode Is less than
> > > > > > > > > MAX_TRAFFIC_BURST, so if enque fails , there is no way
> > > > > > > > > hardware
> > > can drop the Packets .
> > > > > > > > > pmd_per_autotest application evaluates performance after
> > > > > > > > > enqueueing
> > > > > > packets Initially.
> > > > > > > > > >
> > > > > > > > > > > pmd_perf_autotest() in continuous mode tries to
> > > > > > > > > > > enqueue MAX_TRAFFIC_BURST (2048) before starting the
> > test.
> > > > > > > > > > >
> > > > > > > > > > > > > This patch changes behaviour to stop enqueuing
> > > > > > > > > > > > > after few
> > > > > > retries.
> > > > > > > > > > > >
> > > > > > > > > > > > If there is a real limitation, there will be issues
> > > > > > > > > > > > in more places than this test program.
> > > > > > > > > > > > I feel it should be addressed either in the driver
> > > > > > > > > > > > or at ethdev
> > > > level.
diff mbox series

Patch

diff --git a/app/test/test_pmd_perf.c b/app/test/test_pmd_perf.c
index 3a248d512c..0a95b408e8 100644
--- a/app/test/test_pmd_perf.c
+++ b/app/test/test_pmd_perf.c
@@ -456,6 +456,7 @@  main_loop(__rte_unused void *args)
 #define PACKET_SIZE 64
 #define FRAME_GAP 12
 #define MAC_PREAMBLE 8
+#define MAX_RETRY_COUNT 5
 	struct rte_mbuf *pkts_burst[MAX_PKT_BURST];
 	unsigned lcore_id;
 	unsigned i, portid, nb_rx = 0, nb_tx = 0;
@@ -463,6 +464,8 @@  main_loop(__rte_unused void *args)
 	int pkt_per_port;
 	uint64_t diff_tsc;
 	uint64_t packets_per_second, total_packets;
+	int retry_cnt = 0;
+	int free_pkt = 0;
 
 	lcore_id = rte_lcore_id();
 	conf = &lcore_conf[lcore_id];
@@ -480,10 +483,19 @@  main_loop(__rte_unused void *args)
 			nb_tx = RTE_MIN(MAX_PKT_BURST, num);
 			nb_tx = rte_eth_tx_burst(portid, 0,
 						&tx_burst[idx], nb_tx);
+			if (nb_tx == 0)
+				retry_cnt++;
 			num -= nb_tx;
 			idx += nb_tx;
+			if (retry_cnt == MAX_RETRY_COUNT) {
+				retry_cnt = 0;
+				break;
+			}
 		}
 	}
+	for (free_pkt = idx; free_pkt < (MAX_TRAFFIC_BURST*conf->nb_ports)
+			; free_pkt++)
+		rte_pktmbuf_free(tx_burst[free_pkt]);
 	printf("Total packets inject to prime ports = %u\n", idx);
 
 	packets_per_second = (link_mbps * 1000 * 1000) /